zrepl/endpoint
Goran Mekic bc5e1ede04
metric to detect filesystems rules that don't match any local dataset (#653)
This PR adds a Prometheus counter called
`zrepl_zfs_list_unmatched_user_specified_dataset_count`.
Monitor for increases of the counter to detect filesystem filter rules that
have no effect because they don't match any local filesystem.

An example use case for this is the following story:
1. Someone sets up zrepl with `filesystems` filter for `zroot/pg14<`.
2. During the upgrade to Postgres 15, they rename the dataset to `zroot/pg15`,
   but forget to update the zrepl `filesystems` filter.
3. zrepl will not snapshot / replicate the `zroot/pg15<` datasets.

Since `filesystems` rules are always evaluated on the side that has the datasets,
we can smuggle this functionality into the `zfs` module's `ZFSList` function that
is used by all jobs with a `filesystems` filter.

Dashboard changes:
- histogram with increase in $__interval, one row per job
- table with increase in $__range
- explainer text box, so, people know what the previous two are about
We had to re-arrange some panels, hence the Git diff isn't great.

closes https://github.com/zrepl/zrepl/pull/653

Co-authored-by: Christian Schwarz <me@cschwarz.com>
Co-authored-by: Goran Mekić <meka@tilda.center>
2023-05-02 22:13:52 +02:00
..
context.go [#307] add package trace, integrate it with logging, and adopt it throughout zrepl 2020-05-19 11:30:02 +02:00
endpoint_abstractions_cache.go Reformat all files with make format. 2020-08-31 23:57:45 +02:00
endpoint_guarantees.go Reformat all files with make format. 2020-08-31 23:57:45 +02:00
endpoint_metrics.go replication + endpoint: replication guarantees: guarantee_{resumability,incremental,nothing} 2020-07-26 20:32:35 +02:00
endpoint_zfs_abstraction_last_received_hold.go Reformat all files with make format. 2020-08-31 23:57:45 +02:00
endpoint_zfs_abstraction_replication_cursor.go run go1.19 gofmt and make adjustments as needed 2022-10-24 22:22:41 +02:00
endpoint_zfs_abstraction_step_hold.go replication + endpoint: replication guarantees: guarantee_{resumability,incremental,nothing} 2020-07-26 20:32:35 +02:00
endpoint_zfs_abstraction_test.go zfs.NilBool: document its purpose and move it to its own package 'nodefault' 2021-02-20 17:04:57 +01:00
endpoint_zfs_abstraction.go fix incorrect use of sort.StringSlice 2022-10-24 22:22:41 +02:00
endpoint_zfs_helpers_repr_test.go endpoint: refactor, fix stale holds on initial replication failure, zfs-abstractions subcmd, more efficient ZFS queries 2020-04-18 12:26:03 +02:00
endpoint_zfs_helpers_repr.go endpoint: refactor, fix stale holds on initial replication failure, zfs-abstractions subcmd, more efficient ZFS queries 2020-04-18 12:26:03 +02:00
endpoint_zfs_helpers_types.go endpoint: refactor, fix stale holds on initial replication failure, zfs-abstractions subcmd, more efficient ZFS queries 2020-04-18 12:26:03 +02:00
endpoint.go metric to detect filesystems rules that don't match any local dataset (#653) 2023-05-02 22:13:52 +02:00
jobid.go replication + endpoint: replication guarantees: guarantee_{resumability,incremental,nothing} 2020-07-26 20:32:35 +02:00
placeholdercreationencryptionproperty_enumer.go fix encrypt-on-receive with placeholders 2021-12-18 15:12:47 +01:00
replicationguaranteekind_enumer.go replication + endpoint: replication guarantees: guarantee_{resumability,incremental,nothing} 2020-07-26 20:32:35 +02:00