mirror of
https://github.com/zrepl/zrepl.git
synced 2024-11-25 09:54:47 +01:00
292b85b5ef
- drop HintMostRecentCommonAncestor rpc call
- it is wrong to put faith into the active side of the replication to always make that call
(we might not trust it, ref pull setup)
- clean up step holds + step bookmarks + replication cursor bookmarks on
send RPC instead
- this makes it symmetric with Receive RPC
- use a cache (endpoint.sendAbstractionsCache) to avoid the cost of
listing the on-disk endpoint abstractions state on every step
The "create" methods for endpoint abstractions (CreateReplicationCursor, HoldStep) are now fully
idempotent and return an Abstraction.
Notes about endpoint.sendAbstractionsCache:
- fills lazily from disk state on first `Get` operation
- fill from disk is generally only attempted once
- unless the `ListAbstractions` fails, in which case the fill from
disk is retried on next `Get` (the current `Get` will observe a
subset of the actual on-disk abstractions)
- the `Invalidate` method is called
- it is a global (zrepl process-wide) cache
fixes #316
62 lines
1.3 KiB
Go
62 lines
1.3 KiB
Go
package tests
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/zrepl/zrepl/platformtest"
|
|
"github.com/zrepl/zrepl/zfs"
|
|
)
|
|
|
|
func IdempotentBookmark(ctx *platformtest.Context) {
|
|
|
|
platformtest.Run(ctx, platformtest.PanicErr, ctx.RootDataset, `
|
|
DESTROYROOT
|
|
CREATEROOT
|
|
+ "foo bar"
|
|
+ "foo bar@a snap"
|
|
+ "foo bar@another snap"
|
|
`)
|
|
|
|
fs := fmt.Sprintf("%s/foo bar", ctx.RootDataset)
|
|
|
|
asnap := fsversion(ctx, fs, "@a snap")
|
|
anotherSnap := fsversion(ctx, fs, "@another snap")
|
|
|
|
aBookmark, err := zfs.ZFSBookmark(ctx, fs, asnap, "a bookmark")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
// do it again, should be idempotent
|
|
aBookmarkIdemp, err := zfs.ZFSBookmark(ctx, fs, asnap, "a bookmark")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
assert.Equal(ctx, aBookmark, aBookmarkIdemp)
|
|
|
|
// should fail for another snapshot
|
|
_, err = zfs.ZFSBookmark(ctx, fs, anotherSnap, "a bookmark")
|
|
if err == nil {
|
|
panic(err)
|
|
}
|
|
if _, ok := err.(*zfs.BookmarkExists); !ok {
|
|
panic(fmt.Sprintf("has type %T", err))
|
|
}
|
|
|
|
// destroy the snapshot
|
|
if err := zfs.ZFSDestroy(ctx, fmt.Sprintf("%s@a snap", fs)); err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
// do it again, should fail with special error type
|
|
_, err = zfs.ZFSBookmark(ctx, fs, asnap, "a bookmark")
|
|
if err == nil {
|
|
panic(err)
|
|
}
|
|
if _, ok := err.(*zfs.DatasetDoesNotExist); !ok {
|
|
panic(fmt.Sprintf("has type %T", err))
|
|
}
|
|
|
|
}
|