mirror of
https://github.com/zrepl/zrepl.git
synced 2024-11-25 01:44:43 +01:00
d118bcc717
- `timeoutconn` handles state, yet calls to Read/Write make a copy of
that state (non-pointer receiver) so any outbound calls will not have
the state updated
- Even without the copy issue, the renew methods can in edge cases set a
new deadline _after_ DisableTimeouts have been called, consider the
following racy behavior:
1. `renewReadDeadline` is called, checks `renewDeadlinesDisabled`
(not disabled)
2. `DisableTimeouts` is called, sets `renewDeadlinesDisabled`
3. `DisableTimeouts` invokes `c.SetDeadline`
4. `renewReadDeadline` invokes `c.SetReadDeadline`
To fix the above, the `Conn` receiver was made to be a pointer
everywhere and access to renewDeadlinesDisabled is now guarded
by an RWMutex instead of using atomics.
closes #415
|
||
|---|---|---|
| .. | ||
| dataconn | ||
| grpcclientidentity | ||
| netadaptor | ||
| transportmux | ||
| versionhandshake | ||
| rpc_client.go | ||
| rpc_debug.go | ||
| rpc_doc.go | ||
| rpc_logging.go | ||
| rpc_mux.go | ||
| rpc_server.go | ||