zrepl

mirror of https://github.com/zrepl/zrepl.git synced 2025-07-31 11:55:26 +02:00

Files

Christian Schwarz 193abbe6b1 fix active child tasks panic with endpoint.ListAbstractionsStreamed

The goroutine that does endTask() for
"list-abstractions-streamed-producer" can be preempted
after it has closed the out and outErrs channel,
but before it calls endTask().
If the parent ("handler") then gets scheduled and
and ends itself, it will observe an active child task
"list-abstractions-streamed-producer".

This is easy to demo by injecting a sleep here:

  --- a/endpoint/endpoint_zfs_abstraction.go
  +++ b/endpoint/endpoint_zfs_abstraction.go
  @@ -575,6 +576,7 @@ func ListAbstractionsStreamed(ctx context.Context, query ListZFSHoldsAndBookmark
          ctx, endTask := trace.WithTask(ctx, "list-abstractions-streamed-producer")
          go func() {
                  defer endTask()
  +               defer time.Sleep(10 * time.Second)
                  defer close(out)
                  defer close(outErrs)

fixes https://github.com/zrepl/zrepl/issues/607

2022-07-17 21:44:03 +02:00

context.go

[#307 ] add package trace, integrate it with logging, and adopt it throughout zrepl

2020-05-19 11:30:02 +02:00

endpoint_abstractions_cache.go

Reformat all files with make format.

2020-08-31 23:57:45 +02:00

endpoint_guarantees.go

Reformat all files with make format.

2020-08-31 23:57:45 +02:00

endpoint_metrics.go

replication + endpoint: replication guarantees: guarantee_{resumability,incremental,nothing}