mirror of
https://github.com/zrepl/zrepl.git
synced 2025-01-23 22:58:54 +01:00
1ae087bfcf
- make `logging.GetLogger(ctx, Subsys)` the authoritative `logger.Logger` factory function
- the context carries a linked list of injected fields which
`logging.GetLogger` adds to the logger it returns
- introduce the concept of tasks and spans, also tracked as linked list within ctx
- [ ] TODO automatic logging of span begins and ends, with a unique
ID stack that makes it easy to follow a series of log entries in
concurrent code
- ability to produce a chrome://tracing-compatible trace file,
either via an env variable or a `zrepl pprof` subcommand
- this is not a CPU profile, we already have go pprof for that
- but it is very useful to visually inspect where the
replication / snapshotter / pruner spends its time
( fixes #307 )
59 lines
1.4 KiB
Go
59 lines
1.4 KiB
Go
package client
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/pflag"
|
|
|
|
"github.com/zrepl/zrepl/cli"
|
|
"github.com/zrepl/zrepl/endpoint"
|
|
"github.com/zrepl/zrepl/zfs"
|
|
)
|
|
|
|
var zabsCreateStepHoldFlags struct {
|
|
target string
|
|
jobid JobIDFlag
|
|
}
|
|
|
|
var zabsCmdCreateStepHold = &cli.Subcommand{
|
|
Use: "step",
|
|
Run: doZabsCreateStep,
|
|
NoRequireConfig: true,
|
|
Short: `create a step hold or bookmark`,
|
|
SetupFlags: func(f *pflag.FlagSet) {
|
|
f.StringVarP(&zabsCreateStepHoldFlags.target, "target", "t", "", "snapshot to be held / bookmark to be held")
|
|
f.VarP(&zabsCreateStepHoldFlags.jobid, "jobid", "j", "jobid for which the hold is installed")
|
|
},
|
|
}
|
|
|
|
func doZabsCreateStep(ctx context.Context, sc *cli.Subcommand, args []string) error {
|
|
if len(args) > 0 {
|
|
return errors.New("subcommand takes no arguments")
|
|
}
|
|
|
|
f := &zabsCreateStepHoldFlags
|
|
|
|
fs, _, _, err := zfs.DecomposeVersionString(f.target)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "%q invalid target", f.target)
|
|
}
|
|
|
|
if f.jobid.FlagValue() == nil {
|
|
return errors.Errorf("jobid must be set")
|
|
}
|
|
|
|
v, err := zfs.ZFSGetFilesystemVersion(ctx, f.target)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "get info about target %q", f.target)
|
|
}
|
|
|
|
step, err := endpoint.HoldStep(ctx, fs, v, *f.jobid.FlagValue())
|
|
if err != nil {
|
|
return errors.Wrap(err, "create step hold")
|
|
}
|
|
fmt.Println(step.String())
|
|
return nil
|
|
}
|