Christian Schwarz fa586b493c [#348] fix crash on early-recv error ... * The SendStream.Close() was not called by dataconn.Server, which left the zfs send process dangling. * When the source job's ctx interceptor closed the task, the dangling zfs send was detect by the trace package and panicked. 020-07-25T19:54:41-04:00 [ERRO][latitude][rpc.data][cyZj$J3Ca$J3Ca.CJwB]: cannot write send stream err="frameconn: shutting down" panic: end task: 1 active child tasks: end task: task still has active child tasks goroutine 196966 [running]: github.com/zrepl/zrepl/daemon/logging/trace.WithTask.func1.1(0xc000320680, 0xcde000) /home/jeremy/go/src/github.com/zrepl/zrepl/daemon/logging/trace/trace.go:221 +0x2f7 github.com/zrepl/zrepl/daemon/logging/trace.WithTask.func1() /home/jeremy/go/src/github.com/zrepl/zrepl/daemon/logging/trace/trace.go:237 +0x38 github.com/zrepl/zrepl/daemon/logging/trace.WithTaskAndSpan.func1() /home/jeremy/go/src/github.com/zrepl/zrepl/daemon/logging/trace/trace_convenience.go:41 +0x37 github.com/zrepl/zrepl/daemon/job.(*PassiveSide).Run.func1(0xdcf780, 0xc0000a3560, 0xdc65a0, 0xc00035e620, 0xc0000a34d0) /home/jeremy/go/src/github.com/zrepl/zrepl/daemon/job/passive.go:194 +0x2e7 github.com/zrepl/zrepl/rpc.NewServer.func3(0xdcf780, 0xc0001ce4b0, 0xdc65e0, 0xc00035e600, 0xc0000a34d0) /home/jeremy/go/src/github.com/zrepl/zrepl/rpc/rpc_server.go:82 +0xd5 github.com/zrepl/zrepl/rpc/dataconn.(*Server).serveConn(0xc0000a2ba0, 0xc00018eca0) /home/jeremy/go/src/github.com/zrepl/zrepl/rpc/dataconn/dataconn_server.go:149 +0x3be github.com/zrepl/zrepl/rpc/dataconn.(*Server).Serve.func3(0xc0000b8180, 0xc0000a2ba0, 0xc00018eca0) /home/jeremy/go/src/github.com/zrepl/zrepl/rpc/dataconn/dataconn_server.go:108 +0x5d created by github.com/zrepl/zrepl/rpc/dataconn.(*Server).Serve /home/jeremy/go/src/github.com/zrepl/zrepl/rpc/dataconn/dataconn_server.go:106 +0x24a 2020-07-25T19:58:55-04:00 [ERRO][latitude][rpc.data][Pt4F$gCWT$gCWT.fzhc]: cannot write send stream err="frameconn: shutting down" panic: end task: 1 active child tasks: end task: task still has active child tasks fixes #348		2020-07-26 20:32:35 +02:00
..
base2bufpool	build: drop go Dep, switch to modules, support Go 1.13	2019-09-14 13:36:44 +02:00
frameconn	Spellcheck all files	2020-02-24 16:06:09 +01:00
heartbeatconn	rpc/dataconn: fix I/O timeout on variable receive rate	2019-03-31 14:20:06 +02:00
microbenchmark	[#307] add package trace, integrate it with logging, and adopt it throughout zrepl	2020-05-19 11:30:02 +02:00
stream	[#307] add package trace, integrate it with logging, and adopt it throughout zrepl	2020-05-19 11:30:02 +02:00
timeoutconn	rpc/dataconn/timeoutconn: tests: relax deadline in timeout tests	2020-05-18 19:46:24 +02:00
dataconn_client.go	[#307] add package trace, integrate it with logging, and adopt it throughout zrepl	2020-05-19 11:30:02 +02:00
dataconn_debug.go	run golangci-lint and apply suggested fixes	2019-03-27 13:12:26 +01:00
dataconn_server.go	[#348] fix crash on early-recv error	2020-07-26 20:32:35 +02:00
dataconn_shared.go	[#277] rpc + zfs: drop zfs.StreamCopier, use io.ReadCloser instead	2020-05-18 19:46:24 +02:00
dataconn_test.go	rpc rewrite: control RPCs using gRPC + separate RPC for data transfer	2019-03-13 13:53:48 +01:00