Christian Schwarz fb6a9be954 fix encrypt-on-receive with placeholders ... fixes https://github.com/zrepl/zrepl/issues/504 Problem: plain send + recv with root_fs encrypted + placeholders causes plain recvs whereas user would expect encrypt-on-recv Reason: We create placeholder filesytems with -o encryption=off. Thus, children received below those placeholders won't inherit encryption of root_fs. Fix: We'll have three values for `recv.placeholders.encryption: unspecified (default) | off | inherit`. When we create a placeholder, we will fail the operation if `recv.placeholders.encryption = unspecified`. The exception is if the placeholder filesystem is to encode the client identity ($root_fs/$client_identity) in a pull job. Those are created in `inherit` mode if the config field is `unspecified` so that users who don't need placeholders are not bothered by these details. Future Work: Automatically warn existing users of encrypt-on-recv about the problem if they are affected. The problem that I hit during implementation of this is that the `encryption` prop's `source` doesn't quite behave like other props: `source` is `default` for `encryption=off` and `-` when `encryption=on`. Hence, we can't use `source` to distinguish the following 2x2 cases: (1) placeholder created with explicit -o encryption=off (2) placeholder created without specifying -o encryption with (A) an encrypted parent at creation time (B) an unencrypted parent at creation time		2021-12-18 15:12:47 +01:00
..
context.go	[#307] add package trace, integrate it with logging, and adopt it throughout zrepl	2020-05-19 11:30:02 +02:00
endpoint_abstractions_cache.go	Reformat all files with make format.	2020-08-31 23:57:45 +02:00
endpoint_guarantees.go	Reformat all files with make format.	2020-08-31 23:57:45 +02:00
endpoint_metrics.go	replication + endpoint: replication guarantees: guarantee_{resumability,incremental,nothing}	2020-07-26 20:32:35 +02:00
endpoint_zfs_abstraction_last_received_hold.go	Reformat all files with make format.	2020-08-31 23:57:45 +02:00
endpoint_zfs_abstraction_replication_cursor.go	Reformat all files with make format.	2020-08-31 23:57:45 +02:00
endpoint_zfs_abstraction_step_hold.go	replication + endpoint: replication guarantees: guarantee_{resumability,incremental,nothing}	2020-07-26 20:32:35 +02:00
endpoint_zfs_abstraction_test.go	zfs.NilBool: document its purpose and move it to its own package 'nodefault'	2021-02-20 17:04:57 +01:00
endpoint_zfs_abstraction.go	zfs.NilBool: document its purpose and move it to its own package 'nodefault'	2021-02-20 17:04:57 +01:00
endpoint_zfs_helpers_repr_test.go	endpoint: refactor, fix stale holds on initial replication failure, zfs-abstractions subcmd, more efficient ZFS queries	2020-04-18 12:26:03 +02:00
endpoint_zfs_helpers_repr.go	endpoint: refactor, fix stale holds on initial replication failure, zfs-abstractions subcmd, more efficient ZFS queries	2020-04-18 12:26:03 +02:00
endpoint_zfs_helpers_types.go	endpoint: refactor, fix stale holds on initial replication failure, zfs-abstractions subcmd, more efficient ZFS queries	2020-04-18 12:26:03 +02:00
endpoint.go	fix encrypt-on-receive with placeholders	2021-12-18 15:12:47 +01:00
jobid.go	replication + endpoint: replication guarantees: guarantee_{resumability,incremental,nothing}	2020-07-26 20:32:35 +02:00
placeholdercreationencryptionproperty_enumer.go	fix encrypt-on-receive with placeholders	2021-12-18 15:12:47 +01:00
replicationguaranteekind_enumer.go	replication + endpoint: replication guarantees: guarantee_{resumability,incremental,nothing}	2020-07-26 20:32:35 +02:00