allow access to private share service from unrelated environment (#109)

This commit is contained in:
Michael Quigley
2022-11-29 13:07:49 -05:00
parent 44a95598a3
commit 39302cd4d5
2 changed files with 13 additions and 11 deletions

View File

@ -47,20 +47,14 @@ func (h *accessHandler) Handle(params service.AccessParams, principal *rest_mode
}
} else {
logrus.Errorf("error finding environments for account '%v'", principal.Email)
return service.NewAccessInternalServerError()
return service.NewAccessNotFound()
}
ssvcs, err := str.FindServicesForEnvironment(envId, tx)
svcName := params.Body.SvcName
ssvc, err := str.FindServiceWithName(svcName, tx)
if err != nil {
logrus.Errorf("error finding services for environment")
return service.NewAccessInternalServerError()
}
var ssvc *store.Service
for _, v := range ssvcs {
if v.Name == params.Body.SvcName {
ssvc = v
break
}
logrus.Errorf("error finding service")
return service.NewAccessNotFound()
}
if ssvc == nil {
logrus.Errorf("unable to find service '%v' for user '%v'", params.Body.SvcName, principal.Email)