extern/zrok
1
1
Fork 0
mirror of https://github.com/openziti/zrok.git synced 2024-11-25 01:23:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #115 from openziti-test-kitchen/enable-token

Browse Source 
Improve Token Generation
This commit is contained in:
Michael Quigley 2022-11-28 11:24:55 -05:00 committed by GitHub
commit 9451e269dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.gitignore vendored
View File

@ -2,3 +2,4 @@
.idea .idea
*.db *.db
automated-release-build automated-release-build
etc/dev.yml

4
CHANGELOG.md
View File

@ -1,3 +1,3 @@
# v0.2.18 (WiP) # v0.2.18
* First official release in the `v0.2.x` series. * DEFECT: Token generation has been improved to use an alphabet consisting of `[a-zA-Z0-9]`. Service token generation continues to use a case-insensitive alphabet consisting of `[a-z0-9]` to be DNS-safe.

17
controller/util.go
View File

@ -9,7 +9,6 @@ import (
"github.com/openziti-test-kitchen/zrok/rest_model_zrok" "github.com/openziti-test-kitchen/zrok/rest_model_zrok"
"github.com/openziti/edge/rest_management_api_client" "github.com/openziti/edge/rest_management_api_client"
"github.com/openziti/edge/rest_util" "github.com/openziti/edge/rest_util"
"github.com/teris-io/shortid"
"net/http" "net/http"
"strings" "strings"
) )
@ -44,10 +43,6 @@ func edgeClient() (*rest_management_api_client.ZitiEdgeManagement, error) {
return rest_util.NewEdgeManagementClientWithUpdb(cfg.Ziti.Username, cfg.Ziti.Password, cfg.Ziti.ApiEndpoint, caPool) return rest_util.NewEdgeManagementClientWithUpdb(cfg.Ziti.Username, cfg.Ziti.Password, cfg.Ziti.ApiEndpoint, caPool)
} }
func createToken() (string, error) {
return shortid.Generate()
}
func createServiceName() (string, error) { func createServiceName() (string, error) {
gen, err := nanoid.CustomASCII("abcdefghijklmnopqrstuvwxyz0123456789", 12) gen, err := nanoid.CustomASCII("abcdefghijklmnopqrstuvwxyz0123456789", 12)
if err != nil { if err != nil {
@ -56,18 +51,12 @@ func createServiceName() (string, error) {
return gen(), nil return gen(), nil
} }
func dnsSafeShortId() (string, error) { func createToken() (string, error) {
sid, err := shortid.Generate() gen, err := nanoid.CustomASCII("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789", 12)
if err != nil { if err != nil {
return "", err return "", err
} }
for sid[0] == '-' || sid[0] == '_' { return gen(), nil
sid, err = shortid.Generate()
if err != nil {
return "", err
}
}
return sid, nil
} }
func hashPassword(raw string) string { func hashPassword(raw string) string {