Merge pull request #361 from openziti/js-lint-update

updated ui lintintg to be stricter and fixed relevant errors

.github/workflows/ci-build.yml

@@ -33,8 +33,8 @@ jobs:
       - run: npm run build
         working-directory: ui
         env:
-          CI: ""
-
+          CI: "true"
+          
       - name: go install
         run: go install -ldflags "-X github.com/openziti/zrok/build.Version=${{ github.ref }} -X github.com/openziti/zrok/build.Hash=${{ github.sha }}" ./...
 

.github/workflows/release.yml

@@ -37,7 +37,7 @@ jobs:
       - run: npm run build
         working-directory: ui
         env:
-          CI: ""
+          CI: "true"
 
       - uses: goreleaser/goreleaser-action@v2
         with:
@@ -79,7 +79,7 @@ jobs:
       - run: npm run build
         working-directory: ui
         env:
-          CI: ""
+          CI: "true"
 
       - uses: goreleaser/goreleaser-action@v2
         with:
@@ -121,7 +121,7 @@ jobs:
       - run: npm run build
         working-directory: ui
         env:
-          CI: ""
+          CI: "true"
 
       - uses: goreleaser/goreleaser-action@v2
         with:
@@ -170,7 +170,7 @@ jobs:
       - run: npm run build
         working-directory: ui
         env:
-          CI: ""
+          CI: "true"
 
       - uses: goreleaser/goreleaser-action@v2
         with:
@@ -214,7 +214,7 @@ jobs:
       - run: npm run build
         working-directory: ui
         env:
-          CI: ""
+          CI: "true"
 
       - uses: goreleaser/goreleaser-action@v2
         with:

ui/src/components/password.js

@@ -1,5 +1,5 @@
 import React, {useEffect, useState, Fragment} from "react";
-import {Button, Container, Form, Row} from "react-bootstrap";
+import {Container, Form, Row} from "react-bootstrap";
 
 const PasswordForm = (props) => {
     const [password, setPassword] = useState('');
@@ -38,6 +38,7 @@ const PasswordForm = (props) => {
             return;
         }
         props.setParentPassword(password)
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [password, confirm])
 
     return (

ui/src/console/detail/environment/MetricsTab.js

@@ -21,6 +21,7 @@ const MetricsTab = (props) => {
 			.then(resp => {
 				setMetrics1(buildMetrics(resp.data));
 			});
+			// eslint-disable-next-line react-hooks/exhaustive-deps
 	}, [props.selection.id]);
 
 	useEffect(() => {
@@ -45,6 +46,7 @@ const MetricsTab = (props) => {
 			mounted = false;
 			clearInterval(interval);
 		}
+		// eslint-disable-next-line react-hooks/exhaustive-deps
 	}, [props.selection.id]);
 
 	return (

ui/src/console/visualizer/graph.js

@@ -34,7 +34,6 @@ export const mergeGraph = (oldGraph, user, accountLimited, newOverview) => {
         let allShares = {};
         let allFrontends = [];
         newOverview.forEach(env => {
-            let limited = !!env.limited;
             let envNode = {
                 id: 'env:' + env.environment.zId,
                 envZId: env.environment.zId,