extern/zrok
1
1
Fork 0
mirror of https://github.com/openziti/zrok.git synced 2025-01-18 20:08:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix missing permission modes and access grants in python sdk (#432)

Browse Source
This commit is contained in:
Michael Quigley 2024-03-11 11:51:30 -04:00
parent f1c9f11e4d
commit f51ca98c47
No known key found for this signature in database
GPG Key ID: 9B60314A9DD20A62
3 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -1,5 +1,9 @@
# CHANGELOG # CHANGELOG
## v0.4.27
FIX: Also update the Python SDK to include the permission mode and access grants fields on the `ShareRequest` (https://github.com/openziti/zrok/issues/432)
## v0.4.26 ## v0.4.26
FEATURE: New _permission modes_ available for shares. _Open permission mode_ retains the behavior of previous zrok releases and is the default setting. _Closed permission mode_ (`--closed`) only allows a share to be accessed (`zrok access`) by users who have been granted access with the `--access-grant` flag. See the documentation at (https://docs.zrok.io/docs/guides/permission-modes/) (https://github.com/openziti/zrok/issues/432) FEATURE: New _permission modes_ available for shares. _Open permission mode_ retains the behavior of previous zrok releases and is the default setting. _Closed permission mode_ (`--closed`) only allows a share to be accessed (`zrok access`) by users who have been granted access with the `--access-grant` flag. See the documentation at (https://docs.zrok.io/docs/guides/permission-modes/) (https://github.com/openziti/zrok/issues/432)

8
sdk/python/sdk/zrok/zrok/model.py
View File

@ -13,6 +13,11 @@ ShareMode = str
PRIVATE_SHARE_MODE: ShareMode = "private" PRIVATE_SHARE_MODE: ShareMode = "private"
PUBLIC_SHARE_MODE: ShareMode = "public" PUBLIC_SHARE_MODE: ShareMode = "public"
PermissionMode = str
OPEN_PERMISSION_MODE: PermissionMode = "open"
CLOSED_PERMISSION_MODE: PermissionMode = "closed"
@dataclass @dataclass
class ShareRequest: class ShareRequest:
@ -26,7 +31,8 @@ class ShareRequest:
OauthAuthorizationCheckInterval: str = "" OauthAuthorizationCheckInterval: str = ""
Reserved: bool = False Reserved: bool = False
UniqueName: str = "" UniqueName: str = ""
PermissionMode: PermissionMode = OPEN_PERMISSION_MODE
AccessGrants: list[str] = field(default_factory=list[str])
@dataclass @dataclass
class Share: class Share:

8
sdk/python/sdk/zrok/zrok/share.py
View File

@ -67,7 +67,9 @@ def __newPrivateShare(root: Root, request: model.ShareRequest) -> ShareRequest:
share_mode=request.ShareMode, share_mode=request.ShareMode,
backend_mode=request.BackendMode, backend_mode=request.BackendMode,
backend_proxy_endpoint=request.Target, backend_proxy_endpoint=request.Target,
auth_scheme=model.AUTH_SCHEME_NONE auth_scheme=model.AUTH_SCHEME_NONE,
permission_mode=request.permission_mode,
access_grants=request.access_grants
) )
@ -79,7 +81,9 @@ def __newPublicShare(root: Root, request: model.ShareRequest) -> ShareRequest:
backend_proxy_endpoint=request.Target, backend_proxy_endpoint=request.Target,
auth_scheme=model.AUTH_SCHEME_NONE, auth_scheme=model.AUTH_SCHEME_NONE,
oauth_email_domains=request.OauthEmailAddressPatterns, oauth_email_domains=request.OauthEmailAddressPatterns,
oauth_authorization_check_interval=request.OauthAuthorizationCheckInterval oauth_authorization_check_interval=request.OauthAuthorizationCheckInterval,
permission_mode=request.permission_mode,
access_grants=request.access_grants
) )
if request.OauthProvider != "": if request.OauthProvider != "":
ret.oauth_provider = request.OauthProvider ret.oauth_provider = request.OauthProvider