Update monitor-all.sh

Code refactoring
This commit is contained in:
tteckster 2023-04-30 04:22:09 -04:00 committed by GitHub
parent 485444b07d
commit 15f5285120
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -34,14 +34,8 @@ echo "Excluded instances: ${excluded_instances[@]}"
while true while true
do do
# Get the list of containers and virtual machines
containers=$(pct list | tail -n +2 | cut -f1 -d" ")
virtual_machines=$(qm list | grep -oP "^\s*\K\d+(?=\s)")
# Combine the container and virtual machine lists for instance in $(pct list | awk '\''{if(NR>1) print $1}'\''; qm list | awk '\''{if(NR>1) print $1}'\'')
all_instances="$containers $virtual_machines"
for instance in $all_instances
do do
# Skip excluded instances # Skip excluded instances
if [[ " ${excluded_instances[@]} " =~ " ${instance} " ]]; then if [[ " ${excluded_instances[@]} " =~ " ${instance} " ]]; then
@ -96,7 +90,7 @@ done >> /var/log/ping-instances.log 2>&1' >/usr/local/bin/ping-instances.sh
# Change file permissions to executable # Change file permissions to executable
chmod +x /usr/local/bin/ping-instances.sh chmod +x /usr/local/bin/ping-instances.sh
# Create ping-containers.service # Create ping-instances.service
echo '[Unit] echo '[Unit]
Description=Ping instances every 5 minutes and restarts if necessary Description=Ping instances every 5 minutes and restarts if necessary
@ -112,7 +106,7 @@ StandardError=file:/var/log/ping-instances.log
[Install] [Install]
WantedBy=multi-user.target' >/etc/systemd/system/ping-instances.service WantedBy=multi-user.target' >/etc/systemd/system/ping-instances.service
# Reload daemon, enable and start ping-containers.service # Reload daemon, enable and start ping-instances.service
systemctl daemon-reload systemctl daemon-reload
systemctl enable -q --now ping-instances.service systemctl enable -q --now ping-instances.service
clear clear