holm/Unexpected-Keyboard
1
0
Fork 0
forked from extern/Unexpected-Keyboard
Code Pull Requests Activity

refactoring: safer KeyboardData.load

Browse Source
This commit is contained in:
Jules Aguillon 2024-09-29 22:05:09 +02:00
parent a1be402638
commit fb93d841a5
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
srcs/juloo.keyboard2/KeyboardData.java
View File

@ -193,21 +193,22 @@ public final class KeyboardData
/** Load a layout from a resource ID. Returns [null] on error. */ /** Load a layout from a resource ID. Returns [null] on error. */
public static KeyboardData load(Resources res, int id) public static KeyboardData load(Resources res, int id)
{ {
KeyboardData l = _layoutCache.get(id); if (_layoutCache.containsKey(id))
if (l == null) return _layoutCache.get(id);
KeyboardData l = null;
XmlResourceParser parser = null;
try
{ {
try parser = res.getXml(id);
{ l = parse_keyboard(parser);
XmlResourceParser parser = res.getXml(id);
l = parse_keyboard(parser);
parser.close();
_layoutCache.put(id, l);
}
catch (Exception e)
{
e.printStackTrace();
}
} }
catch (Exception e)
{
Logs.exn("Failed to load layout id " + id, e);
}
if (parser != null)
parser.close();
_layoutCache.put(id, l);
return l; return l;
} }