From 36f9902f2e8cba9fd77da2d39450de92205691e9 Mon Sep 17 00:00:00 2001 From: Mirko Golze Date: Thu, 21 Sep 2023 22:17:46 +0200 Subject: [PATCH 1/2] #191 interpolate header names with variables --- .../RequestPane/RequestHeaders/index.js | 26 ++++++++++++------- .../bruno-cli/src/runner/interpolate-vars.js | 3 ++- .../src/ipc/network/interpolate-vars.js | 3 ++- 3 files changed, 21 insertions(+), 11 deletions(-) diff --git a/packages/bruno-app/src/components/RequestPane/RequestHeaders/index.js b/packages/bruno-app/src/components/RequestPane/RequestHeaders/index.js index 04cb04d8..2cd5ccad 100644 --- a/packages/bruno-app/src/components/RequestPane/RequestHeaders/index.js +++ b/packages/bruno-app/src/components/RequestPane/RequestHeaders/index.js @@ -72,19 +72,27 @@ const RequestHeaders = ({ item, collection }) => { {headers && headers.length - ? headers.map((header, index) => { + ? headers.map((header) => { return ( - handleHeaderValueChange(e, header, 'name')} + theme={storedTheme} + onSave={onSave} + onChange={(newValue) => + handleHeaderValueChange( + { + target: { + value: newValue + } + }, + header, + 'name' + ) + } + onRun={handleRun} + collection={collection} /> diff --git a/packages/bruno-cli/src/runner/interpolate-vars.js b/packages/bruno-cli/src/runner/interpolate-vars.js index bfb0601d..ae30a7b2 100644 --- a/packages/bruno-cli/src/runner/interpolate-vars.js +++ b/packages/bruno-cli/src/runner/interpolate-vars.js @@ -51,7 +51,8 @@ const interpolateVars = (request, envVars = {}, collectionVariables = {}, proces request.url = interpolate(request.url); forOwn(request.headers, (value, key) => { - request.headers[key] = interpolate(value); + delete request.headers[key]; + request.headers[interpolate(key)] = interpolate(value); }); if (request.headers['content-type'] === 'application/json') { diff --git a/packages/bruno-electron/src/ipc/network/interpolate-vars.js b/packages/bruno-electron/src/ipc/network/interpolate-vars.js index 7cdbcd25..fb022150 100644 --- a/packages/bruno-electron/src/ipc/network/interpolate-vars.js +++ b/packages/bruno-electron/src/ipc/network/interpolate-vars.js @@ -51,7 +51,8 @@ const interpolateVars = (request, envVars = {}, collectionVariables = {}, proces request.url = interpolate(request.url); forOwn(request.headers, (value, key) => { - request.headers[key] = interpolate(value); + delete request.headers[key]; + request.headers[interpolate(key)] = interpolate(value); }); if (request.headers['content-type'] === 'application/json') { From 6a2ba0f7462ab5b7a64d1448b071cb9f94d5df9b Mon Sep 17 00:00:00 2001 From: Mirko Golze Date: Wed, 27 Sep 2023 22:39:22 +0200 Subject: [PATCH 2/2] try other way to retrieve icon path for about window --- packages/bruno-electron/src/app/menu-template.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/bruno-electron/src/app/menu-template.js b/packages/bruno-electron/src/app/menu-template.js index 45125bb9..7e091129 100644 --- a/packages/bruno-electron/src/app/menu-template.js +++ b/packages/bruno-electron/src/app/menu-template.js @@ -51,7 +51,7 @@ const template = [ click: () => openAboutWindow({ product_name: 'Bruno', - icon_path: join(__dirname, '../../resources/icons/png/256x256.png'), + icon_path: join(process.cwd(), '/resources/icons/png/256x256.png'), homepage: 'https://www.usebruno.com/', package_json_dir: join(__dirname, '../..') })