holm/bruno
1
0
Fork 0
forked from extern/bruno
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix rounding response size

Browse Source 
I noticed that sometimes the response size is weirdly displayed.
- size `112932` is displayed as `110.28.999999999999996KB`
- size `112990` is displayed as `110.34KB`

The problem is in the decimal calculation. Rounding the value ensure we don't have two `.` in the displayed size.

Also, update the `contributing` to increase the minimum Node version required.
This commit is contained in:
Jeremy Benoist 2023-10-03 10:39:38 +02:00
parent 712319ff34
commit 73c62010b7
No known key found for this signature in database
GPG Key ID: 7168D5DD29F38552
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contributing.md
View File

@ -19,7 +19,7 @@ Libraries we use
### Dependencies ### Dependencies
You would need [Node v14.x or the latest LTS version](https://nodejs.org/en/) and npm 8.x. We use npm workspaces in the project You would need [Node v18.x or the latest LTS version](https://nodejs.org/en/) and npm 8.x. We use npm workspaces in the project
### Lets start coding ### Lets start coding

2
packages/bruno-app/src/components/ResponsePane/ResponseSize/index.js
View File

@ -7,7 +7,7 @@ const ResponseSize = ({ size }) => {
if (size > 1024) { if (size > 1024) {
// size is greater than 1kb // size is greater than 1kb
let kb = Math.floor(size / 1024); let kb = Math.floor(size / 1024);
let decimal = ((size % 1024) / 1024).toFixed(2) * 100; let decimal = Math.round(((size % 1024) / 1024).toFixed(2) * 100);
sizeToDisplay = kb + '.' + decimal + 'KB'; sizeToDisplay = kb + '.' + decimal + 'KB';
} else { } else {
sizeToDisplay = size + 'B'; sizeToDisplay = size + 'B';