From 1ac78955c03c218c73db50fb04ec262d905e51e4 Mon Sep 17 00:00:00 2001 From: Martin Whitehouse Date: Mon, 25 Jul 2022 01:22:05 +0200 Subject: [PATCH] Removed `notifications_to_be_sent` list The whole loop appeared to be doing nothing other than appending email addresses to a list, which was never used. --- helpdesk/email.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/helpdesk/email.py b/helpdesk/email.py index 8f92b521..54b592ca 100644 --- a/helpdesk/email.py +++ b/helpdesk/email.py @@ -466,16 +466,6 @@ def create_object_from_email_message(message, ticket_id, payload, files, logger) new_ticket_ccs = [] new_ticket_ccs.append(create_ticket_cc(ticket, to_list + cc_list)) - notifications_to_be_sent = [sender_email] - - if queue.enable_notifications_on_email_events and len(notifications_to_be_sent): - - ticket_cc_list = TicketCC.objects.filter( - ticket=ticket).all().values_list('email', flat=True) - - for email_address in ticket_cc_list: - notifications_to_be_sent.append(email_address) - autoreply = is_autoreply(message) if autoreply: logger.info(