diff --git a/helpdesk/validators.py b/helpdesk/validators.py index 602917d5..01500a9a 100644 --- a/helpdesk/validators.py +++ b/helpdesk/validators.py @@ -4,6 +4,8 @@ from django.conf import settings +#TODO: can we use the builtin Django validator instead? +# see: https://docs.djangoproject.com/en/4.0/ref/validators/#fileextensionvalidator def validate_file_extension(value): import os from django.core.exceptions import ValidationError @@ -11,13 +13,13 @@ def validate_file_extension(value): # TODO: we might improve this with more thorough checks of file types # rather than just the extensions. - # check if VALID_EXTENSTIONS is defined in settings.py + # check if VALID_EXTENSIONS is defined in settings.py # if not use defaults - if settings.VALID_EXTENSTIONS: - valid_extenstions = settings.VALID_EXTENSTIONS + if settings.VALID_EXTENSIONS: + valid_extensions = settings.VALID_EXTENSIONS else: - valid_extenstions = ['.txt', '.pdf', '.doc', '.docx', '.odt', '.jpg', '.png'] + valid_extensions = ['.txt', '.pdf', '.doc', '.docx', '.odt', '.jpg', '.png'] - if not ext.lower() in valid_extenstions: + if not ext.lower() in valid_extensions: raise ValidationError('Unsupported file extension.')