holm/django-helpdesk
1
0
Fork 0
forked from extern/django-helpdesk
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid saving empty ticket updates. Closes #99.

Browse Source
This commit is contained in:
Ross Poulton 2012-08-07 23:22:39 +10:00
parent eaba930c63
commit dc91771b96
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
helpdesk/views/staff.py
View File

@ -267,6 +267,19 @@ def update_ticket(request, ticket_id, public=False):
due_date = due_date.replace(due_date_year, due_date_month, due_date_day) due_date = due_date.replace(due_date_year, due_date_month, due_date_day)
tags = request.POST.get('tags', '') tags = request.POST.get('tags', '')
no_changes = all([
not request.FILES,
not comment,
new_status == ticket.status,
title == ticket.title,
priority == int(ticket.priority),
due_date == ticket.due_date,
(not owner and not ticket.assigned_to) or (owner and User.objects.get(id=owner) == ticket.assigned_to),
(HAS_TAG_SUPPORT and tags == ticket.tags) or not HAS_TAG_SUPPORT,
])
if no_changes:
return return_to_ticket(request.user, helpdesk_settings, ticket)
# We need to allow the 'ticket' and 'queue' contexts to be applied to the # We need to allow the 'ticket' and 'queue' contexts to be applied to the
# comment. # comment.
from django.template import loader, Context from django.template import loader, Context
@ -469,7 +482,12 @@ def update_ticket(request, ticket_id, public=False):
ticket.save() ticket.save()
if request.user.is_staff or helpdesk_settings.HELPDESK_ALLOW_NON_STAFF_TICKET_UPDATE: return return_to_ticket(request.user, helpdesk_settings, ticket)
def return_to_ticket(user, helpdesk_settings, ticket):
''' Helpder function for update_ticket '''
if user.is_staff or helpdesk_settings.HELPDESK_ALLOW_NON_STAFF_TICKET_UPDATE:
return HttpResponseRedirect(ticket.get_absolute_url()) return HttpResponseRedirect(ticket.get_absolute_url())
else: else:
return HttpResponseRedirect(ticket.ticket_url) return HttpResponseRedirect(ticket.ticket_url)