Commit Graph

212 Commits

Author SHA1 Message Date
Timothy Hobbs
9963a3fe5d Fix utf decoding bug in email parsing code
For some reason mozilla thunderbird sometimes marks email parts as 8bit
even though they are utf-8. I guess the best way to work around this is
to add a try-catch block because this really cannot be predicted.
2020-01-23 16:00:01 +01:00
Timothy Hobbs
2f8b4acf64 Fix pycodestyle errors 2020-01-20 14:17:23 +01:00
Timothy Hobbs
90621f575d Fix ironic ticket creation loop when submitter email == queue email 2020-01-20 13:23:32 +01:00
Timothy Hobbs
0b50b14449 Add kb tests 2020-01-20 13:23:31 +01:00
Timothy Hobbs
24b8e45f66 Add ability to hide fields in public ticket submission form using kwargs 2020-01-20 13:07:45 +01:00
Timothy Hobbs
ef9c4c589a Fix linting errors 2020-01-20 13:03:44 +01:00
Timothy Hobbs
b96d725239 Refactor query code into customizable class 2020-01-20 13:03:44 +01:00
Timothy Hobbs
8985fc759d Remove hardcoded pk from test suit 2020-01-20 13:03:42 +01:00
Garret Wassermann
860a30486c Comments pass PEP-8 2019-12-17 22:38:03 -05:00
Garret Wassermann
103b762779 Disable broken test_autofill, unclear why it is giving integrity errors when it was working just fine not long ago, is this from a django change? 2019-12-17 22:35:32 -05:00
Garret Wassermann
7dbf1c3b68 Possibly fix test_autofill test case integrity fail 2019-12-17 09:11:37 -05:00
Timothy Hobbs
61dd12abd9 Fix tests 2019-10-16 17:36:55 +02:00
Garret Wassermann
182d553356 Fix some renaming issues from most recent merge 2019-10-12 18:58:50 -04:00
Garret Wassermann
7f27eb9428 Merge 0.2.17 release into develop 2019-08-27 21:53:25 -04:00
Janne Alatalo
042e766be1 Add a test that checks that LOGIN_URL can be a view name
This test requires that the admin urls are added to the test
configuration.
2019-08-27 13:04:00 +03:00
Janne Alatalo
0a43b9a160 Add support for custom login handler
The custom login handler can be configured by setting the
settings.LOGIN_URL variable. If LOGIN_URL is None or 'helpdesk:login',
the app uses the default helpdesk login system. LOGIN_URL can be a view
name or raw url.
2019-08-27 13:02:07 +03:00
Garret Wassermann
0de263280f Merged 0.2.16 bugfixes 2019-05-25 01:25:39 -04:00
Garret Wassermann
94eab853af Fix email test, example didn't update the email subject 2019-04-01 22:17:32 -04:00
Garret Wassermann
9ca7f9fb46 Merge remote-tracking branch 'upstream/develop' into develop 2019-04-01 21:29:18 -04:00
Timothy Hobbs
6886a7920e Specify encoding of html email bodies explicitly 2019-03-26 13:59:01 +01:00
Timothy Hobbs
f3ffebc261 Fix test regression from pr #731
https://github.com/django-helpdesk/django-helpdesk/pull/731/files#diff-dc9aca3bb03b3531dc114813db32f3c7R56
2019-03-25 17:13:10 +01:00
Cedric Carrard
9c85b8e8c1 fix redirect loop 2019-03-20 16:12:19 +01:00
Cedric Carrard
e4d6a54659 fix public homepage with kb_category but without kb disabled 2019-03-15 14:10:43 +01:00
Garret Wassermann
6ce11266af Fix broken test with blank body and attachment 2019-03-10 00:04:41 -05:00
Jachym Cepicky
ce82ddb9f9
Merge branch 'develop' into images_for_kb 2019-03-09 23:46:26 +01:00
Jachym Cepicky
db0f286989 adding support for images as knowledgebase attachment 2019-03-09 23:41:26 +01:00
Garret Wassermann
27cf481c0b
Merge pull request #733 from auto-mat/utf
Add test for #732, unicode characters in description
2019-03-09 14:51:29 -05:00
Jachym Cepicky
9127275557 adding support for images as knowledgebase attachment 2019-03-09 18:14:11 +01:00
Timothy Hobbs
5e9fed2d46 Add failing test for #732 2019-03-09 00:00:32 +01:00
Garret Wassermann
37be1346cd
Merge pull request #729 from auto-mat/quoted-printable
Decode quoted-printable html bodies when getting email
2019-03-06 11:27:10 -05:00
Jachym Cepicky
57018e1aa0 adding tests 2019-03-06 15:03:47 +01:00
Timothy Hobbs
2c3ce8903f Decode quoted-printable html bodies when getting email
Fixes #719
2019-03-06 14:21:30 +01:00
Garret Wassermann
4fb6c40c4e
Merge pull request #717 from OpenGeoLabs/time_tracking
Basic support for tracking time spent on tickets and follow-ups
2019-02-24 15:18:01 -05:00
Jachym Cepicky
4bd54e8bf3 adding tests 2019-02-24 20:46:48 +01:00
Garret Wassermann
a7505a1ecd
Merge pull request #720 from auto-mat/issue-700-fail
Add failing test case for issue-700 emails without bodies
2019-02-15 17:01:38 -05:00
Timothy Hobbs
4e35082475 Add failing test case for issue-700 emails without bodies 2019-02-15 15:11:06 +01:00
Jachym Cepicky
8cc0ca47f8 display list of queues only for users with right permissions 2019-02-05 15:44:06 +01:00
Garret Wassermann
43ed3ac773 PEP-8 fixes for mail threading merge 2018-12-28 11:32:49 -05:00
Garret Wassermann
5f0d22a692 Merge brunotikami/master for user and email threading, for #385 and #375 2018-12-28 10:53:28 -05:00
Garret Wassermann
696d10db12 Remove old python2/six code 2018-12-28 03:13:52 -05:00
Timothy Hobbs
9a45d28c95
More refactors of get_email.py 2018-10-31 16:30:19 +01:00
Timothy Hobbs
3f6ae1aefe
Transform UserSettings into a normal django model 2018-10-25 17:54:37 +02:00
Timothy Hobbs
c1750a7461
Require a secret key for viewing tickets unless HELPDESK_VIEW_A_TICKET_PUBLIC is set
Fixes #629, #639
2018-09-08 21:29:59 +02:00
Timothy Hobbs
58cc18d049
Only staff users should be given access to the RSS feeds 2018-09-03 20:29:22 +02:00
Timothy Hobbs
13539e3056
Fix tests 2018-08-30 12:03:54 +02:00
Garret Wassermann
c70cf04e4d Fix codestyle errors, use currying instead of lambdas for determing user access 2018-07-19 00:06:57 -04:00
Garret Wassermann
c71355cfdc is_authenticated is a bool now not a function 2018-03-04 04:24:30 -05:00
Garret Wassermann
54a6b1d21b Merge 0.2.7 bugfixes 2018-03-04 04:01:48 -05:00
Garret Wassermann
95ee61fe90 Fix PEP8 errors 2018-02-16 05:04:10 -05:00
Garret Wassermann
113880bc3a Compare user IDs to determine if same user, and add simple test case, to fix #588 2018-02-16 05:00:22 -05:00
Garret Wassermann
75f54dd233 Testing quicktest.py 2018-01-11 02:19:49 -05:00
Garret Wassermann
31b49ab2f6 Merge branch 'master' into develop 2017-12-28 09:32:14 -05:00
Garret Wassermann
aa63e8f299 Really fix py 2 imp/importlib 2017-12-28 09:26:14 -05:00
Garret Wassermann
4b78704180 Fix error on python 2 2017-12-28 09:22:57 -05:00
Garret Wassermann
3ccd6c8dc8 Merge 0.2.6 Django 2.0 updates 2017-12-28 09:16:01 -05:00
Garret Wassermann
d18ce1f1d5 Bump version to 0.2.6 to fix remaining Django 2.0 warnings 2017-12-28 09:11:34 -05:00
Garret Wassermann
523329eab5 Merge 0.2.5 bugfixes and Django 2.0 changes 2017-12-28 07:43:10 -05:00
Garret Wassermann
5112f0dfd0 Address deprecation warnings to be compatible with Django 2.0 2017-12-28 07:23:51 -05:00
Garret Wassermann
92b43ef495 Merge master 0.2.3 bugfixes into develop 2017-12-09 23:02:12 -05:00
Garret Wassermann
dffab1bb6a PEP8 fixes for test_get_email.py 2017-12-05 03:52:38 -05:00
Garret Wassermann
fca6b483f2 Add PGP signed email test case to get_email tests, for #567 2017-12-05 03:47:05 -05:00
Garret Wassermann
6e2a16e5a6 Fixing unit tests for python3 for custom staff filters 2017-10-30 05:07:44 -04:00
Garret Wassermann
3a1bd76e75 Merge custom staff filter, PR #239 2017-10-30 03:17:40 -04:00
Garret Wassermann
a0fb315c3b Fix PEP8 errors 2017-07-30 20:33:25 -04:00
Garret Wassermann
c8ee3815ec Fix num_to_link error, was leaving off a letter of text if next to the ID, to address #511 2017-07-16 19:58:11 -04:00
Garret Wassermann
9fd170f707 Add test for num_to_link function 2017-07-16 19:53:05 -04:00
Garret Wassermann
d13e87bd3b Last PEP-8 fix? 2017-04-20 02:54:35 -04:00
Garret Wassermann
45c457ead2 More PEP-8 fixes on test_get_email 2017-04-20 02:49:06 -04:00
Garret Wassermann
47f3eb8e89 PEP-8 fixes 2017-04-20 02:44:12 -04:00
Garret Wassermann
bf344b09b1 Check CC'd email against list of User emails, and add the User to the ticket if necessary and not already the assignee, etc. 2017-04-20 02:36:10 -04:00
Garret Wassermann
8963fa694a Prevent adding Users or Queue email to the CC list 2017-04-19 23:47:58 -04:00
Garret Wassermann
220c0460e1 Check number of CCs to ensure no duplicates made it through 2017-04-19 00:04:16 -04:00
Garret Wassermann
34ce553435 Only add CC emails to Ticket if they were not already included (no duplicates), add testing for it 2017-04-18 23:36:39 -04:00
Garret Wassermann
3b22bb655a PEP8 fixes for too many blank lines 2017-04-16 05:14:30 -04:00
Garret Wassermann
e3a378625c Add test with django template tag in email body, to ensure we test for and fix #72 in future changes 2017-04-16 05:10:51 -04:00
Garret Wassermann
7b8426596f Separate out the CC test from plain test so we're testing both possibilities (with and without a CC) 2017-04-16 04:51:46 -04:00
Garret Wassermann
b2ac1fd3a5 #95: save CC'd emails on a comment to the Ticket for future correspondence, set to view only initially, and update tests for CC 2017-04-16 04:19:17 -04:00
Garret Wassermann
5ec985af9b Add explicit encoding hint to top of file to allow Python 2 to read file with Unicode characters, in accordance with PEP-263 2017-04-03 02:34:54 -04:00
Garret Wassermann
0fb9094d01 Remove line for PEP8 2017-04-03 02:29:28 -04:00
Garret Wassermann
f43ef69ec1 Add a MIME multipart email test for get_email 2017-04-03 02:19:29 -04:00
Garret Wassermann
74a7afadb9 Update get_email test to use unicode characters; seem to have found an encoding errory in get_email, provided a fix that satisfies test 2017-04-03 01:53:25 -04:00
Garret Wassermann
6fec1015c3 Work in progress on unicode chars 2017-02-15 18:51:20 -05:00
Alex Seeholzer
a2315eb0c4 added pep8 fix and missing migration 2017-01-13 17:39:56 +01:00
Alex Seeholzer
645f196848 Added tests covering the usersettings_helpdesk occurrences 2017-01-13 17:37:10 +01:00
Jonathan Barratt
5acd891c68
refactor all handling of attached files
Extract attachment processing from forms, views.staff, and management.command.get_email modules, and consolidate it into a unified lib module function.
Also refactor the affected components, most notably lib.send_templated_email, to make it easier (IMO) to reason about changes to them.
Add unit tests for attachments with UTF-8 filenames, and functional tests for submission of same, as well as ASCII versions, through the public ticket-form.
Remove unused Attachment method "get_upload_to".
2016-12-08 19:47:20 +07:00
Jonathan Barratt
391e35065c
per code review, update safe IP addr/port constants, remove commented-out code, and add comments to unexplained code 2016-12-06 09:55:22 +07:00
Jonathan Barratt
e8d0c5b2c7
implement mocked pop3 and imap tests for get_email
also update travis to latest django patch releases
2016-12-02 19:04:52 +07:00
Alex Seeholzer
399b0901f6
newer version of tests 2016-12-02 17:40:46 +07:00
Alex Seeholzer
72a99cc99a
Moved existing test for local mailbox into generation of tests for matrix of email configurations; 2016-12-02 17:40:46 +07:00
Garret Wassermann
c74208325b Removed test_per_queue_staff_permission assertion, report_index no longer returns unassigned_tickets 2016-10-31 02:06:49 -04:00
Garret Wassermann
adf2b16c2c Fix namespaces in test 2016-10-29 04:33:27 -04:00
Garret Wassermann
1f1d477a35 Sync again with master 0.2 2016-10-29 04:11:41 -04:00
Garret Wassermann
d791700582 Fix PEP8 errors 2016-10-29 04:08:57 -04:00
Jonathan Barratt
28308d19fb
cleanup build-breaking whitespace merge errors 2016-10-29 14:59:14 +07:00
Garret Wassermann
cad174468b Sync with namespace and other v0.2 changes 2016-10-29 03:47:15 -04:00
Jonathan Barratt
43c067dd4f
merge changes from updated master 2016-10-29 13:35:03 +07:00
Alex Barcelo
89a6ae01b8 Fixing style (according to branch 'autocodestyle') + quicktest 2016-10-24 08:04:31 +02:00
Alex Barcelo
179ceb2f82 fixing style on tests 2016-10-23 22:10:32 +02:00
Alex Barcelo
24d88be8d9 Initial general clean-up of stuff 2016-10-21 17:14:12 +02:00
Garret Wassermann
d7875587b7 Revert previous change 2016-10-20 12:05:28 -04:00