Commit Graph

1346 Commits

Author SHA1 Message Date
Jonathan Barratt
719b03f186 Merge pull request #476 from flinz/enhancements/issue-460-remerge
Enhancements: issue 460, backlink to helpdesk usersettings via unique name
2017-01-14 01:16:05 +07:00
Alex Seeholzer
a2315eb0c4 added pep8 fix and missing migration 2017-01-13 17:39:56 +01:00
Alex Seeholzer
645f196848 Added tests covering the usersettings_helpdesk occurrences 2017-01-13 17:37:10 +01:00
Alex Seeholzer
4e018db5a6 Added unique related_name “usersetttings_helpdesk” for the one-to-one relation to User in UserSettings. 2017-01-13 15:22:41 +01:00
Alex Seeholzer
9fbe464445 Merge pull request #475 from reduxionist/issue/472/multiple-queue-models-prevent-queue-creation
Make helpdesk work in apps with their own queue models
2017-01-13 14:10:31 +01:00
Jonathan Barratt
2f66c50320
Make helpdesk work in apps with their own queue models
To avoid returning multiple content types when creating custom permissions, use ContentType.objects.get_for_model to lookup the content type for helpdesk.models.queue.
2017-01-13 17:52:29 +07:00
Jonathan Barratt
aa2265ccb1 Merge pull request #473 from tshabs/master
fix mistake in helpdesk/lib.py (subject_part declared twice, second time without stripping newline)
2017-01-13 14:24:58 +07:00
User
787c3aa4f5 make old subject_part pretty 2017-01-09 00:30:36 +01:00
User
b7baf2bf56 fix for error:BadHeaderError: Header values can't contain newlines when running get_email. caused by subject_part being repeated, but second time doesnt strip newlines 2017-01-08 18:52:24 +01:00
Jonathan Barratt
c3d83462a3 Merge pull request #471 from reduxionist/issue/470/no-tickets-datatables-error
fixes 470: datatables error on empty ticket list
2017-01-03 00:51:37 +07:00
Jonathan Barratt
8a2e6c087e
hotfix for #470: datatables error on empty ticket list
handle the no tickets match query case with js rather than python for DataTables compatibility
2017-01-03 00:42:12 +07:00
Jonathan Barratt
1c069f7f08 Merge pull request #469 from gwasser/467
Fix form end tag placement, and remove duplicate unstyled query box
2016-12-29 19:18:19 +07:00
Pawel M
8f751691a4 whitespace removed 2016-12-16 10:38:15 +01:00
Pawel M
97b3444a92 if files condition restored 2016-12-16 10:36:00 +01:00
Pawel M
fc0ae58420 lib as reduxionist + read binary mode 2016-12-16 10:30:50 +01:00
Garret Wassermann
3c6b522464 Fix form end tag placement, and remove duplicate unstyled query box 2016-12-13 23:45:43 -05:00
Pawel M
df7920cd2e missing imports added 2016-12-14 00:04:38 +01:00
Pawel M
3a372fbcb4 White space removed 2016-12-13 23:40:36 +01:00
Pawel M
f5b68772cf Downloaded attachment was not decoded and additionally encoded by default django method (its size after download is bigger than originally attached file). This is the reason why it is illegible 2016-12-13 23:31:26 +01:00
Pawel M
9939f62ebd Attachement should be readed in binary mode ... and attached as payload (regarding docs) 2016-12-13 23:28:16 +01:00
Pawel M
e7c4131ed7 Attachement should be readed in binary mode ... and attached as payload (regarding docs) 2016-12-13 22:43:14 +01:00
Pawel M
8bbe3d2e55 Merge branch 'hotfix/corrupt-forwarding-of-binary-attachments' of https://github.com/reduxionist/django-helpdesk 2016-12-13 19:53:51 +01:00
Jonathan Barratt
8dbd54ac16
stop corrupting binary attachments when delivering them by email
We accomplish this by attching files to out-bound mail diffrently
depending on the versino of Python in effect. In Py2 we can read
the files ourseles and the standard library will still
be able to use the text we pass as if it were bytes. Under Py3,
however, email.message will complain if it doesn't get to decode
the bytes itself, so instead of attaching the contents directly
 we just pass the path to the file as a string instead. Unfortunately,
Django 1.8 does not work with this Python 3 approach, due to its
 not yet having reverted to the newly improved standard library's
mail-message implementation, and thus requiring us to know more
about the character-encoding/mimetype of the attachment than I've
been able to gather cleanly by this point.
2016-12-13 19:41:13 +07:00
Pawel M
e326fea099 merged with upstream 2016-12-12 11:15:45 +01:00
Pawel M
556b6900db merged with upstream 2016-12-12 11:07:08 +01:00
Pawel M
6482c6338d merged with upstream 2016-12-12 10:32:01 +01:00
Pawel M
04ec40bbc8 merged with upstream 2016-12-12 10:31:29 +01:00
Pawel M
c11e360f50 PY3 get_email support in method ticket_from_message (if message isinstance bytes use email.email_from_bytes(msg) else ..from_string(msg)) ... clear 2016-12-12 10:30:38 +01:00
Pawel M
550ca89415 PY3 get_email support in method ticket_from_message (if message isinstance bytes use email.email_from_bytes(msg) else ..from_string(msg)) 2016-12-12 10:30:38 +01:00
Pawel M
905910911d PY3 support and msgNum error solved in process_queue method 2016-12-12 10:30:38 +01:00
Jonathan Barratt
6908e956e0 Merge pull request #465 from reduxionist/bugfix/urlquote-email-in-redirect
urlquote email address when used as get query param
2016-12-11 23:27:52 +07:00
Jonathan Barratt
e82e5fcd5f
urlquote email address when used as get query param 2016-12-11 06:20:03 +07:00
Jonathan Barratt
0edc75fc6c Merge pull request #464 from reduxionist/pr/393
solves Title changed to . (Null title) on failed attachment upload.
2016-12-11 06:18:24 +07:00
Pawel M
94c39cba69
solves Title changed to . (Null title) on failed attachment upload. 2016-12-11 06:00:05 +07:00
Jonathan Barratt
15c67da2a1 Merge pull request #463 from reduxionist/issue/multi/attachments
refactor all handling of attached files
2016-12-11 05:56:37 +07:00
Pawel M
5998faa6a5 PY3 get_email support in method ticket_from_message (if message isinstance bytes use email.email_from_bytes(msg) else ..from_string(msg)) ... clear 2016-12-08 15:17:14 +01:00
Pawel M
4c97ecd0ae PY3 get_email support in method ticket_from_message (if message isinstance bytes use email.email_from_bytes(msg) else ..from_string(msg)) 2016-12-08 15:14:11 +01:00
Pawel M
431d1fa3a5 Merge branch 'master' of https://github.com/django-helpdesk/django-helpdesk 2016-12-08 15:10:53 +01:00
Jonathan Barratt
5acd891c68
refactor all handling of attached files
Extract attachment processing from forms, views.staff, and management.command.get_email modules, and consolidate it into a unified lib module function.
Also refactor the affected components, most notably lib.send_templated_email, to make it easier (IMO) to reason about changes to them.
Add unit tests for attachments with UTF-8 filenames, and functional tests for submission of same, as well as ASCII versions, through the public ticket-form.
Remove unused Attachment method "get_upload_to".
2016-12-08 19:47:20 +07:00
Alex Seeholzer
142c2367d2 Merge pull request #459 from reduxionist/flinz_tests/get-email
Expands testing of get_email
2016-12-08 09:39:20 +01:00
Pawel M
d76fa2c71e PY3 support and msgNum error solved in process_queue method 2016-12-08 09:32:04 +01:00
Jonathan Barratt
391e35065c
per code review, update safe IP addr/port constants, remove commented-out code, and add comments to unexplained code 2016-12-06 09:55:22 +07:00
Jonathan Barratt
e8d0c5b2c7
implement mocked pop3 and imap tests for get_email
also update travis to latest django patch releases
2016-12-02 19:04:52 +07:00
Alex Seeholzer
4a7286f371
added requirements for testing 2016-12-02 17:40:46 +07:00
Alex Seeholzer
399b0901f6
newer version of tests 2016-12-02 17:40:46 +07:00
Alex Seeholzer
72a99cc99a
Moved existing test for local mailbox into generation of tests for matrix of email configurations; 2016-12-02 17:40:46 +07:00
Jonathan Barratt
1f63691dbe Merge pull request #457 from reduxionist/hotfix/456/ticket_from_message-missing-arg
hotfix for #456:  patch calls to ticket_from_message
2016-11-29 00:56:22 +07:00
Jonathan Barratt
3cfa371199
hotfix for #456: patch calls to ticket_from_message
add logger arg where missing in get_email
2016-11-29 00:46:42 +07:00
Jonathan Barratt
cac3267e82 Merge pull request #454 from reduxionist/prune-legacy-code
Prune legacy code
2016-11-21 20:32:35 +07:00
Jonathan Barratt
45a8ce98ac Merge pull request #455 from gwasser/ticket_list_view
Use HTML5 table ordering based on Unix epoch
2016-11-21 20:29:13 +07:00