From 9f9cdeec6c68499b64a0246e5a380d709444821d Mon Sep 17 00:00:00 2001
From: Garret Wassermann <gwasser@gmail.com>
Date: Sun, 16 Jul 2017 19:24:16 -0400
Subject: [PATCH 1/8] Show ticket ID in title of page so easier to use with
 many tabs open, to address #525

---
 helpdesk/templates/helpdesk/ticket.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/helpdesk/templates/helpdesk/ticket.html b/helpdesk/templates/helpdesk/ticket.html
index 09bdbe67..d0f86d16 100644
--- a/helpdesk/templates/helpdesk/ticket.html
+++ b/helpdesk/templates/helpdesk/ticket.html
@@ -1,7 +1,7 @@
 {% extends "helpdesk/base.html" %}
 {% load i18n bootstrap humanize %}
 {% load static from staticfiles %}
-{% block helpdesk_title %}{% trans "View Ticket Details" %}{% endblock %}
+{% block helpdesk_title %}{{ ticket.queue.slug }}-{{ ticket.id }} : {% trans "View Ticket Details" %}{% endblock %}
 {% block helpdesk_head %}
 <script type='text/javascript' language='javascript'>
 $(document).ready(function() {

From 8a49babfe59a9c41f0dd9faa65af450efcfb98f0 Mon Sep 17 00:00:00 2001
From: Garret Wassermann <gwasser@gmail.com>
Date: Sun, 16 Jul 2017 19:30:59 -0400
Subject: [PATCH 2/8] Add documentation for new QUEUE_EMAIL_BOX_UPDATE_ONLY
 setting, to address #530

---
 docs/settings.rst    | 4 ++++
 helpdesk/settings.py | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/docs/settings.rst b/docs/settings.rst
index ae3fb2df..dd6a3ea3 100644
--- a/docs/settings.rst
+++ b/docs/settings.rst
@@ -81,6 +81,10 @@ These changes are visible throughout django-helpdesk
 - **HELPDESK_EMAIL_FALLBACK_LOCALE** Fallback locale for templated emails when queue locale not found
 
   **Default:** ``HELPDESK_EMAIL_FALLBACK_LOCALE= "en"``
+  
+- **QUEUE_EMAIL_BOX_UPDATE_ONLY** Only process mail with a valid tracking ID; all other mail will be ignored instead of creating a new ticket.
+
+  **Default:** ``False``
 
 
 Options shown on public pages
diff --git a/helpdesk/settings.py b/helpdesk/settings.py
index 6fd8e460..18d63a18 100644
--- a/helpdesk/settings.py
+++ b/helpdesk/settings.py
@@ -133,6 +133,8 @@ QUEUE_EMAIL_BOX_SSL = getattr(settings, 'QUEUE_EMAIL_BOX_SSL', None)
 QUEUE_EMAIL_BOX_HOST = getattr(settings, 'QUEUE_EMAIL_BOX_HOST', None)
 QUEUE_EMAIL_BOX_USER = getattr(settings, 'QUEUE_EMAIL_BOX_USER', None)
 QUEUE_EMAIL_BOX_PASSWORD = getattr(settings, 'QUEUE_EMAIL_BOX_PASSWORD', None)
+
+# only process emails with a valid tracking ID? (throws away all other mail)
 QUEUE_EMAIL_BOX_UPDATE_ONLY = getattr(settings, 'QUEUE_EMAIL_BOX_UPDATE_ONLY', False)
 
 # only allow users to access queues that they are members of?

From a42a5b8aeb40766cb45587d46c7aae8dfdc67f78 Mon Sep 17 00:00:00 2001
From: Garret Wassermann <gwasser@gmail.com>
Date: Sun, 16 Jul 2017 19:38:30 -0400
Subject: [PATCH 3/8] Add missing num_to_link in ticket description, to address
 #513

---
 helpdesk/templates/helpdesk/ticket_desc_table.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/helpdesk/templates/helpdesk/ticket_desc_table.html b/helpdesk/templates/helpdesk/ticket_desc_table.html
index b557d0c3..fb2479e5 100644
--- a/helpdesk/templates/helpdesk/ticket_desc_table.html
+++ b/helpdesk/templates/helpdesk/ticket_desc_table.html
@@ -29,7 +29,7 @@
                                             <th colspan='2'>{% trans "Description" %}</th>
                                         </tr>
                                         <tr>
-                                            <td id="ticket-description" colspan='2'>{{ ticket.description|force_escape|urlizetrunc:50|linebreaksbr }}</td>
+                                            <td id="ticket-description" colspan='2'>{{ ticket.description|force_escape|urlizetrunc:50|num_to_link|linebreaksbr }}</td>
                                         </tr>
 
                                         {% if ticket.resolution %}<tr>

From 9fd170f707e9ad9315c4b75de3cd57b3aa6f821e Mon Sep 17 00:00:00 2001
From: Garret Wassermann <gwasser@gmail.com>
Date: Sun, 16 Jul 2017 19:53:05 -0400
Subject: [PATCH 4/8] Add test for num_to_link function

---
 helpdesk/tests/test_ticket_actions.py | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/helpdesk/tests/test_ticket_actions.py b/helpdesk/tests/test_ticket_actions.py
index 42fd11a8..7f9e23b5 100644
--- a/helpdesk/tests/test_ticket_actions.py
+++ b/helpdesk/tests/test_ticket_actions.py
@@ -10,6 +10,7 @@ try:  # python 3
 except ImportError:  # python 2
     from urlparse import urlparse
 
+from helpdesk.templatetags.ticket_to_link import num_to_link
 
 class TicketActionsTestCase(TestCase):
     fixtures = ['emailtemplate.json']
@@ -121,6 +122,26 @@ class TicketActionsTestCase(TestCase):
         }
         response = self.client.post(reverse('helpdesk:update', kwargs={'ticket_id': ticket_id}), post_data, follow=True)
         self.assertContains(response, 'Changed Status from Open to Closed')
+        
+    def test_num_to_link(self):
+        """Test that we are correctly expanding links to tickets from IDs"""
+        # make staff user
+        self.loginUser()
+        
+        initial_data = {
+            'title': 'Some private ticket',
+            'queue': self.queue_public,
+            'assigned_to': self.user,
+            'status': Ticket.OPEN_STATUS,
+        }
+
+        # create ticket
+        ticket = Ticket.objects.create(**initial_data)
+        ticket_id = ticket.id
+        
+        # generate the URL text
+        result = num_to_link('this is ticket#%s' % ticket_id)
+        self.assertEqual(result, "this is ticke <a href='/helpdesk/tickets/%s/' class='ticket_link_status ticket_link_status_Open'>#%s</a>" % (ticket_id, ticket_id))
 
     def test_create_ticket_getform(self):
         self.loginUser()

From c8ee3815ec926c51af0e623046be312a3ebe120e Mon Sep 17 00:00:00 2001
From: Garret Wassermann <gwasser@gmail.com>
Date: Sun, 16 Jul 2017 19:58:11 -0400
Subject: [PATCH 5/8] Fix num_to_link error, was leaving off a letter of text
 if next to the ID, to address #511

---
 helpdesk/templatetags/ticket_to_link.py | 2 +-
 helpdesk/tests/test_ticket_actions.py   | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/helpdesk/templatetags/ticket_to_link.py b/helpdesk/templatetags/ticket_to_link.py
index 1280f846..6cc4023d 100644
--- a/helpdesk/templatetags/ticket_to_link.py
+++ b/helpdesk/templatetags/ticket_to_link.py
@@ -39,7 +39,7 @@ def num_to_link(text):
         if ticket:
             style = ticket.get_status_display()
             text = "%s <a href='%s' class='ticket_link_status ticket_link_status_%s'>#%s</a>%s" % (
-                text[:match.start()], url, style, match.groups()[0], text[match.end():])
+                text[:match.start()+1], url, style, match.groups()[0], text[match.end():])
     return mark_safe(text)
 
 register = template.Library()
diff --git a/helpdesk/tests/test_ticket_actions.py b/helpdesk/tests/test_ticket_actions.py
index 7f9e23b5..ca183c1d 100644
--- a/helpdesk/tests/test_ticket_actions.py
+++ b/helpdesk/tests/test_ticket_actions.py
@@ -125,6 +125,7 @@ class TicketActionsTestCase(TestCase):
         
     def test_num_to_link(self):
         """Test that we are correctly expanding links to tickets from IDs"""
+        
         # make staff user
         self.loginUser()
         
@@ -141,7 +142,10 @@ class TicketActionsTestCase(TestCase):
         
         # generate the URL text
         result = num_to_link('this is ticket#%s' % ticket_id)
-        self.assertEqual(result, "this is ticke <a href='/helpdesk/tickets/%s/' class='ticket_link_status ticket_link_status_Open'>#%s</a>" % (ticket_id, ticket_id))
+        self.assertEqual(result, "this is ticket <a href='/helpdesk/tickets/%s/' class='ticket_link_status ticket_link_status_Open'>#%s</a>" % (ticket_id, ticket_id))
+        
+        result2 = num_to_link('whoa another ticket is here #%s huh' % ticket_id)
+        self.assertEqual(result2, "whoa another ticket is here  <a href='/helpdesk/tickets/%s/' class='ticket_link_status ticket_link_status_Open'>#%s</a> huh" % (ticket_id, ticket_id))
 
     def test_create_ticket_getform(self):
         self.loginUser()

From 4e81d643905074c189dae69b64cf08b36b4349e7 Mon Sep 17 00:00:00 2001
From: Garret Wassermann <gwasser@gmail.com>
Date: Mon, 17 Jul 2017 03:56:22 -0400
Subject: [PATCH 6/8] Put es in list of common translation languages for
 settings

---
 helpdesk/settings.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/helpdesk/settings.py b/helpdesk/settings.py
index 18d63a18..1714fba1 100644
--- a/helpdesk/settings.py
+++ b/helpdesk/settings.py
@@ -51,7 +51,7 @@ HELPDESK_TRANSLATE_TICKET_COMMENTS = getattr(settings,
 # all default google translate languages will be shown.
 HELPDESK_TRANSLATE_TICKET_COMMENTS_LANG = getattr(settings,
                                                   'HELPDESK_TRANSLATE_TICKET_COMMENTS_LANG',
-                                                  ["en", "de", "fr", "it", "ru"])
+                                                  ["en", "de", "es", "fr", "it", "ru"])
 
 # show link to 'change password' on 'User Settings' page?
 HELPDESK_SHOW_CHANGE_PASSWORD = getattr(settings, 'HELPDESK_SHOW_CHANGE_PASSWORD', False)

From f6c323c9ab2d972502534527358ad61685bde685 Mon Sep 17 00:00:00 2001
From: Garret Wassermann <gwasser@gmail.com>
Date: Mon, 17 Jul 2017 05:04:25 -0400
Subject: [PATCH 7/8] Fix binary attachments to outgoing email, and handle case
 when it is plain text, to address #502

---
 helpdesk/lib.py | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/helpdesk/lib.py b/helpdesk/lib.py
index 4f0ded3d..53e2fe9a 100644
--- a/helpdesk/lib.py
+++ b/helpdesk/lib.py
@@ -117,7 +117,15 @@ def send_templated_mail(template_name,
 
     if files:
         for filename, filefield in files:
-            msg.attach(filename, open(filefield.path).read())
+            mime = mimetypes.guess_type(filename)
+            if mime[0] is not None and mime[0] == "text/plain":
+                with open(filefield.path, 'r') as file:
+                    content = file.read()
+                    msg.attach(filename, content)
+            else:
+                with open(filefield.path, 'rb') as file:
+                    content = file.read()
+                    msg.attach(filename, content)
 
     return msg.send(fail_silently)
 

From a0fb315c3b3d0e02fabc1e70d335546f9aeb00cd Mon Sep 17 00:00:00 2001
From: Garret Wassermann <gwasser@gmail.com>
Date: Sun, 30 Jul 2017 20:33:25 -0400
Subject: [PATCH 8/8] Fix PEP8 errors

---
 helpdesk/templatetags/ticket_to_link.py |  2 +-
 helpdesk/tests/test_ticket_actions.py   | 11 ++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/helpdesk/templatetags/ticket_to_link.py b/helpdesk/templatetags/ticket_to_link.py
index 6cc4023d..fc2eae21 100644
--- a/helpdesk/templatetags/ticket_to_link.py
+++ b/helpdesk/templatetags/ticket_to_link.py
@@ -39,7 +39,7 @@ def num_to_link(text):
         if ticket:
             style = ticket.get_status_display()
             text = "%s <a href='%s' class='ticket_link_status ticket_link_status_%s'>#%s</a>%s" % (
-                text[:match.start()+1], url, style, match.groups()[0], text[match.end():])
+                text[:match.start() + 1], url, style, match.groups()[0], text[match.end():])
     return mark_safe(text)
 
 register = template.Library()
diff --git a/helpdesk/tests/test_ticket_actions.py b/helpdesk/tests/test_ticket_actions.py
index ca183c1d..7058ca03 100644
--- a/helpdesk/tests/test_ticket_actions.py
+++ b/helpdesk/tests/test_ticket_actions.py
@@ -12,6 +12,7 @@ except ImportError:  # python 2
 
 from helpdesk.templatetags.ticket_to_link import num_to_link
 
+
 class TicketActionsTestCase(TestCase):
     fixtures = ['emailtemplate.json']
 
@@ -122,13 +123,13 @@ class TicketActionsTestCase(TestCase):
         }
         response = self.client.post(reverse('helpdesk:update', kwargs={'ticket_id': ticket_id}), post_data, follow=True)
         self.assertContains(response, 'Changed Status from Open to Closed')
-        
+
     def test_num_to_link(self):
         """Test that we are correctly expanding links to tickets from IDs"""
-        
+
         # make staff user
         self.loginUser()
-        
+
         initial_data = {
             'title': 'Some private ticket',
             'queue': self.queue_public,
@@ -139,11 +140,11 @@ class TicketActionsTestCase(TestCase):
         # create ticket
         ticket = Ticket.objects.create(**initial_data)
         ticket_id = ticket.id
-        
+
         # generate the URL text
         result = num_to_link('this is ticket#%s' % ticket_id)
         self.assertEqual(result, "this is ticket <a href='/helpdesk/tickets/%s/' class='ticket_link_status ticket_link_status_Open'>#%s</a>" % (ticket_id, ticket_id))
-        
+
         result2 = num_to_link('whoa another ticket is here #%s huh' % ticket_id)
         self.assertEqual(result2, "whoa another ticket is here  <a href='/helpdesk/tickets/%s/' class='ticket_link_status ticket_link_status_Open'>#%s</a> huh" % (ticket_id, ticket_id))