holm/django-helpdeskmig
1
0
Fork 0
mirror of https://gitea.mueller.network/extern/django-helpdesk.git synced 2024-11-25 01:13:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Only show open ticket as dependency/parent candidates

Browse Source 
It makes no sense to make a ticket depend on an already closed
ticket, or to make a closed ticket depend on another.

The only case I can think of is to create such a relationship in
hindsight for documentation purposes.  This can be implemented by
adding an admin interface or giving the administrator more choices.
This commit is contained in:
Georg Lehner 2024-06-08 18:49:53 +02:00
parent 7bf21685b3
commit 2cb9d382cb
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
helpdesk/forms.py
View File

@ -594,8 +594,8 @@ class TicketDependencyForm(forms.ModelForm):
def __init__(self, ticket, *args, **kwargs): def __init__(self, ticket, *args, **kwargs):
super(TicketDependencyForm,self).__init__(*args, **kwargs) super(TicketDependencyForm,self).__init__(*args, **kwargs)
# Exclude duplicate tickets, myself, existing dependencies and parents # Only open tickets except myself, existing dependencies and parents
self.fields['depends_on'].queryset = Ticket.objects.exclude(status=Ticket.DUPLICATE_STATUS).exclude(id=ticket.id).exclude(depends_on__ticket=ticket).exclude(ticketdependency__depends_on=ticket) self.fields['depends_on'].queryset = Ticket.objects.filter(status__in=Ticket.OPEN_STATUSES).exclude(id=ticket.id).exclude(depends_on__ticket=ticket).exclude(ticketdependency__depends_on=ticket)
class TicketResolvesForm(forms.ModelForm): class TicketResolvesForm(forms.ModelForm):
''' Adds this ticket as a dependency for a different ticket ''' ''' Adds this ticket as a dependency for a different ticket '''
@ -608,8 +608,8 @@ class TicketResolvesForm(forms.ModelForm):
def __init__(self, ticket, *args, **kwargs): def __init__(self, ticket, *args, **kwargs):
super(TicketResolvesForm,self).__init__(*args, **kwargs) super(TicketResolvesForm,self).__init__(*args, **kwargs)
# Exclude duplicate tickets, myself, existing dependencies and parents # Only open tickets except myself, existing dependencies and parents
self.fields['ticket'].queryset = Ticket.objects.exclude(status=Ticket.DUPLICATE_STATUS).exclude(id=ticket.id).exclude(depends_on__ticket=ticket).exclude(ticketdependency__depends_on=ticket) self.fields['ticket'].queryset = Ticket.objects.exclude(status__in=Ticket.OPEN_STATUSES).exclude(id=ticket.id).exclude(depends_on__ticket=ticket).exclude(ticketdependency__depends_on=ticket)
class MultipleTicketSelectForm(forms.Form): class MultipleTicketSelectForm(forms.Form):