holm/django-helpdeskmig
1
0
Fork 0
mirror of https://gitea.mueller.network/extern/django-helpdesk.git synced 2024-11-23 00:13:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Bug in test_per_queue_staff_permission.py

Browse Source 
Using the django auth backend allows integers to be passed as a password
Using Peter Sagerson's ldap auth backend there is an error thrown because
some code tries to do a len() on the password.
You could argue that the ldap auth backend should str(password), but
you could also argue that passing an int as a password is bad practice

This PR ensures that a string is sent to the auth module.
This commit is contained in:
Daryl 2016-06-30 11:56:27 +12:00
parent afbfd01fab
commit 44bbcd31e5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
helpdesk/tests/test_per_queue_staff_permission.py
View File

@ -41,7 +41,7 @@ class PerQueueStaffMembershipTestCase(TestCase):
username='User_%d' % identifier, username='User_%d' % identifier,
is_staff=True, is_staff=True,
) )
user.set_password(identifier) user.set_password(str(identifier))
user.save() user.save()
# The prefix 'helpdesk.' must be trimmed # The prefix 'helpdesk.' must be trimmed
@ -74,7 +74,7 @@ class PerQueueStaffMembershipTestCase(TestCase):
# Regular users # Regular users
for identifier in self.IDENTIFIERS: for identifier in self.IDENTIFIERS:
self.client.login(username='User_%d' % identifier, password=identifier) self.client.login(username='User_%d' % identifier, password=str(identifier))
response = self.client.get(reverse('helpdesk_dashboard')) response = self.client.get(reverse('helpdesk_dashboard'))
self.assertEqual( self.assertEqual(
len(response.context['unassigned_tickets']), len(response.context['unassigned_tickets']),
@ -131,7 +131,7 @@ class PerQueueStaffMembershipTestCase(TestCase):
""" """
# Regular users # Regular users
for identifier in self.IDENTIFIERS: for identifier in self.IDENTIFIERS:
self.client.login(username='User_%d' % identifier, password=identifier) self.client.login(username='User_%d' % identifier, password=str(identifier))
response = self.client.get(reverse('helpdesk_list')) response = self.client.get(reverse('helpdesk_list'))
self.assertEqual( self.assertEqual(
len(response.context['tickets']), len(response.context['tickets']),
@ -166,7 +166,7 @@ class PerQueueStaffMembershipTestCase(TestCase):
""" """
# Regular users # Regular users
for identifier in self.IDENTIFIERS: for identifier in self.IDENTIFIERS:
self.client.login(username='User_%d' % identifier, password=identifier) self.client.login(username='User_%d' % identifier, password=str(identifier))
response = self.client.get( response = self.client.get(
reverse('helpdesk_run_report', kwargs={'report': 'userqueue'}) reverse('helpdesk_run_report', kwargs={'report': 'userqueue'})
) )