From 010f9fc7641c85f19445df706e3672a19b882207 Mon Sep 17 00:00:00 2001 From: DavidVadnais Date: Sat, 18 Jan 2025 02:51:15 +0000 Subject: [PATCH 1/3] temp fix for titles not updating --- helpdesk/update_ticket.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/helpdesk/update_ticket.py b/helpdesk/update_ticket.py index 8577472b..6657df43 100644 --- a/helpdesk/update_ticket.py +++ b/helpdesk/update_ticket.py @@ -268,6 +268,9 @@ def update_ticket( files = process_attachments(f, files) if files else [] + if not ticket_title and title: + ticket_title = title + if ticket_title and ticket_title != ticket.title: c = f.ticketchange_set.create( field=_('Title'), From 9cbe8ebcfac2b29b549d4b69f4f5e348ee3bdf1a Mon Sep 17 00:00:00 2001 From: DavidVadnais Date: Tue, 21 Jan 2025 18:38:27 +0000 Subject: [PATCH 2/3] Revert "temp fix for titles not updating" This reverts commit 010f9fc7641c85f19445df706e3672a19b882207. --- helpdesk/update_ticket.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/helpdesk/update_ticket.py b/helpdesk/update_ticket.py index 6657df43..8577472b 100644 --- a/helpdesk/update_ticket.py +++ b/helpdesk/update_ticket.py @@ -268,9 +268,6 @@ def update_ticket( files = process_attachments(f, files) if files else [] - if not ticket_title and title: - ticket_title = title - if ticket_title and ticket_title != ticket.title: c = f.ticketchange_set.create( field=_('Title'), From 6f3549eb5a78c1af9afc4ea892403bd6104826af Mon Sep 17 00:00:00 2001 From: DavidVadnais Date: Tue, 21 Jan 2025 18:49:06 +0000 Subject: [PATCH 3/3] Remove ticket_title in favor of title --- helpdesk/update_ticket.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/helpdesk/update_ticket.py b/helpdesk/update_ticket.py index 8577472b..51ac7d19 100644 --- a/helpdesk/update_ticket.py +++ b/helpdesk/update_ticket.py @@ -198,7 +198,6 @@ def update_ticket( files=None, public=False, owner=-1, - ticket_title=None, priority=-1, queue=-1, new_status=None, @@ -268,13 +267,13 @@ def update_ticket( files = process_attachments(f, files) if files else [] - if ticket_title and ticket_title != ticket.title: + if title and title != ticket.title: c = f.ticketchange_set.create( field=_('Title'), old_value=ticket.title, - new_value=ticket_title, + new_value=title, ) - ticket.title = ticket_title + ticket.title = title if new_status != old_status: c = f.ticketchange_set.create(