From e19666b7299ff095d2c58287f4d91c1ef29f3fbc Mon Sep 17 00:00:00 2001 From: Garret Wassermann Date: Sun, 17 Dec 2017 23:47:48 -0500 Subject: [PATCH] Add a check that the email subject template includes the ticket ID to prevent problems, to address issue raised in #577 --- helpdesk/settings.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/helpdesk/settings.py b/helpdesk/settings.py index fb89da77..cc6e6349 100644 --- a/helpdesk/settings.py +++ b/helpdesk/settings.py @@ -114,6 +114,10 @@ HELPDESK_STAFF_ONLY_TICKET_CC = getattr(settings, 'HELPDESK_STAFF_ONLY_TICKET_CC HELPDESK_EMAIL_SUBJECT_TEMPLATE = getattr( settings, 'HELPDESK_EMAIL_SUBJECT_TEMPLATE', "{{ ticket.ticket }} {{ ticket.title|safe }} %(subject)s") +# since django-helpdesk may not work correctly without the ticket ID +# in the subject, let's do a check for it quick: +if HELPDESK_EMAIL_SUBJECT_TEMPLATE.find("ticket.ticket") < 0: + raise ImproperlyConfigured # default fallback locale when queue locale not found HELPDESK_EMAIL_FALLBACK_LOCALE = getattr(settings, 'HELPDESK_EMAIL_FALLBACK_LOCALE', 'en')