Daryl
3ffe505f29
Wrong method to test the url
...
Forgot that Travis urls have the 'http://testserver ' part at the front
2016-06-30 11:29:35 +12:00
Daryl
a842d1a9c3
Error in class name
...
Copied a test, forgot to change the test class name
2016-06-30 10:50:04 +12:00
Daryl
fb3b024592
Add test for saving a query, fix shared checkbox issue
...
My browser sends 'on' when a checkbox is ticked, django ORM only
recognises '1', 'true' or 't' as valid 'True' responses.
This throws an error
ValidationError at /helpdesk/save_query/
[u"'on' value must be either True or False."]
This could be fixed with " value='1'" in the template, but testing that is harder
My fix is to add a check in the view. 2 more lines, but easier to unittest.
Core devs need to make a call as to which solution is best.
D
2016-06-30 10:49:49 +12:00
Ross Poulton
5a51d96c73
bump version number and release to pypi
2016-06-29 08:23:05 +10:00
Ross Poulton
90e1a3c33a
Merge pull request #407 from mhannig/fixed_remote_code_execution
...
Fixed remote code execution through unpickling untrusted code. Moved to json (de)serialize instead.
2016-06-29 08:16:36 +10:00
Matthias Hannig
5f0191957f
fixed python3 compat issue
2016-06-28 18:44:54 +02:00
Matthias Hannig
895a65fdb9
Fixed remote code execution through unpickling untrusted code.
2016-06-28 18:04:39 +02:00
Ross Poulton
d65c32487c
Merge pull request #406 from mrkiwi-nz/master
...
Fix Issue #404 : Refactor converting query string into queue:id
2016-06-26 19:28:48 +10:00
Daryl
afbfd01fab
Fix Issue #404 : Refactor converting query string into queue:id
2016-06-26 12:45:55 +12:00
Ross Poulton
ecd870663d
Merge pull request #405 from mrkiwi-nz/master
...
Ignore queue name when doing lookups for tickets (means URLs don't break when moving ticket between queues)
2016-06-25 21:55:40 +10:00
Daryl
e5a6686c6d
Ticket #403 - This code changes the behaviour of lookups for tickets and
...
ignores the queue name. This means that queue changes on a ticket dont
break the email links which have already been sent out.
The queue name still exists in the link/url, but is not used in the
lookup
2016-06-24 13:46:37 +12:00
Ross Poulton
acc3b2771f
Merge pull request #402 from janhh/patch-1
...
Make it clearer django.contrib.sites is a requirement
2016-06-23 15:43:41 +10:00
Jan Henrik Hasselberg
4e9bfb6335
django.contrib.sites is an requirement
...
Documentation example should point out django.contrib.sites is a requirement. I thought "sites" was optional looking at example first time.
2016-06-23 06:58:27 +02:00
Ross Poulton
d1d2b9d51e
Merge pull request #401 from mrkiwi-nz/patch-1
...
Update README.rst to include requirement for contrib.sites
2016-06-23 14:11:00 +10:00
Daryl Egarr
14264d34a5
Update README.rst
2016-06-23 16:05:43 +12:00
Ross Poulton
e4dc3e51eb
Merge pull request #399 from mrkiwi-nz/master
...
Changed render_to_response() to render()
2016-06-22 11:05:21 +10:00
Daryl
8a7fe5fcbf
Changed the way the context is passed to render() - this was required
...
to enable django 1.7 to work (otherwise 1.8, 1.9 pass all tests, but 1.7 fails)
2016-06-21 20:56:43 +12:00
Daryl
558f140bfb
Changed render_to_response() to render() - this should work for django1.9.4 plus django1.10
...
Without this change, django1.10 is missing the 'user' object from the context, which results in
a very hard to track down bug manifesting in ;
"NoReverseMatch: Reverse for 'helpdesk_rss_user' with arguments '('',)' and keyword arguments '{}' not found."
At first glance users may think this is the dots-in-usernames bug, but the username is totally missing.
2016-06-21 17:18:06 +12:00
Ross Poulton
33a61898a0
Merge pull request #398 from gleber-diniz/patch-1
...
Fix import error on python 3 get_email command
2016-06-15 10:23:13 +10:00
Gleber Diniz
f8044faf28
Fix import error on python 3
...
"from email.utils import parseaddr, collapse_rfc2231_value" works both for python 2.7 and python 3
2016-06-14 17:10:23 -03:00
Ross Poulton
0837643c17
Merge pull request #397 from mrkiwi-nz/master
...
Changes to templates to make them compatible with django 1.10
2016-06-10 08:58:55 +10:00
mrkiwi-nz
7dd4aa11d7
Update ticket_cc_list.html
2016-06-09 12:41:12 +12:00
mrkiwi-nz
57d341f89f
Update report_output.html
2016-06-09 12:40:48 +12:00
mrkiwi-nz
783aa2481c
Update email_ignore_list.html
2016-06-09 12:40:08 +12:00
mrkiwi-nz
d86b82e689
Update debug.html
2016-06-09 12:39:24 +12:00
Ross Poulton
5ba39a95bf
Merge pull request #395 from smalls12/patch-1
...
Fix Transifex Link
2016-06-02 09:09:11 +10:00
Chathan Driehuys
9117d98aaa
Fix Transifex Link
...
When clicking on the previous link, I got a 403 message. This new link actually takes me to the project.
2016-06-01 14:16:06 -04:00
Ross Poulton
034758bce7
Merge pull request #394 from mgalgs/patch-1
...
install.rst: Fix typo
2016-05-17 10:43:28 +10:00
Mitchel Humpherys
fe261a1e54
install.rst: Fix typo
...
setnd => send
2016-05-15 00:55:59 -07:00
Bruno Tikami
c5101a2873
UP: When multiple emails are used on the "To" field, subscribe them as well.
2016-03-23 13:16:49 -03:00
Bruno Tikami
5933d2a59b
UPDATED: Strip inputed emails before creating TicketCC instances
2016-03-17 01:39:17 -03:00
Bruno Tikami
9e64354d8a
Merge branch 'master' into feature/2__mail_threading
...
* master:
UPDATED: When notifying users about creation / updates on tickets, notify everybody using a single email message.
2016-03-17 01:21:34 -03:00
Bruno Tikami
978e6d5c9b
UPDATED: When notifying users about creation / updates on tickets, notify everybody using a single email message.
2016-03-17 01:12:42 -03:00
Bruno Tikami
11f28d175b
Merge branch 'master' into feature/2__mail_threading
...
* master:
BUGFIX: Capture invalid email exceptions and ignore those inputs.
ADDED: Test cases for the new enable_notifications_on_email_events flag
2016-03-15 14:16:34 -03:00
Bruno Tikami
99ae4bb801
BUGFIX: Capture invalid email exceptions and ignore those inputs.
2016-03-15 14:13:19 -03:00
Ross Poulton
303872d7c2
Merge pull request #392 from DarrenRiedlinger/login_view_ticketlist_AttributeError
...
Fixes #391 getattr on usersettings.setting dict always returns False.
2016-03-07 09:26:28 +11:00
Darren Riedlinger
ac8ead52c8
getattr on usersettings.setting dict always returns False. Use settings.get() instead
2016-03-06 12:46:36 -08:00
Bruno Tikami
4124677f10
ADDED: Test cases for the new enable_notifications_on_email_events flag
2016-03-03 13:47:15 -03:00
Ross Poulton
e52ae206c6
Merge pull request #388 from pawelmarkowski/master
...
dashboard error queues are null
2016-03-02 10:38:08 +11:00
Ross Poulton
bd7dca3a19
Merge pull request #387 from brunotikami/hotfix/make_print_statements_3x_compatible
...
Make print statements Python 3.x compatible
2016-03-02 09:27:01 +11:00
Pawel M
2b6c23db9f
(1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ')\n GROUP BY queue, name\n ORDER BY q.id' at line 9") helpdesk/views/staff.py in dashboard 149 solved. When queues is null do not add to sql q.id in ()
2016-03-01 22:53:33 +01:00
Bruno Tikami
4e4f481428
Merge branch 'hotfix/make_print_statements_3x_compatible' into feature/2__mail_threading
...
* hotfix/make_print_statements_3x_compatible:
UPDATED: print statements to be Python 3.x compatible
2016-03-01 17:09:28 -03:00
Bruno Tikami
2efe8255c5
UPDATED: print statements to be Python 3.x compatible
2016-03-01 17:01:58 -03:00
Bruno Tikami
26fc6cb1de
ADDED: Flag to enable notifications on every interaction that occurs over email.
2016-03-01 16:49:34 -03:00
Bruno Tikami
1511e0e72c
UPDATED: Better separation of HTTP and e-mail test cases
2016-02-28 15:19:08 -03:00
Bruno Tikami
45fbd605e5
UPDATED: Separate HTTP and e-mail TestCases
2016-02-28 15:00:15 -03:00
Bruno Tikami
5058790995
BUGFIX: Fixing migration merge conflict.
2016-02-24 10:42:14 -03:00
Bruno Tikami
a9f073cc48
Merge branch 'master' of https://github.com/rossp/django-helpdesk
2016-02-24 10:25:57 -03:00
Bruno Tikami
b55eaabebd
UPDATED: Renaming methods after reading through the pull request
2016-02-22 10:17:28 -03:00
Bruno Tikami
0c480b4abd
UPDATE: Removed an unnecessary migration created by mistake.
2016-02-22 10:00:29 -03:00