From 9c34d42a50452965d89b7ed40178e10e67ef034a Mon Sep 17 00:00:00 2001
From: JeLuF <jf@mormo.org>
Date: Wed, 28 Jun 2023 19:11:37 +0200
Subject: [PATCH] Download dialog redesign, code cleanup

---
 ui/index.html                                | 52 +++++++++++---------
 ui/media/css/main.css                        | 12 ++++-
 ui/media/css/themes.css                      |  2 +-
 ui/media/js/image-modifiers.js               |  9 +---
 ui/media/js/main.js                          | 11 +++--
 ui/media/js/utils.js                         | 11 +++++
 ui/plugins/ui/tiled-image-download.plugin.js | 11 +----
 7 files changed, 60 insertions(+), 48 deletions(-)

diff --git a/ui/index.html b/ui/index.html
index 9565c726..bf72e2f2 100644
--- a/ui/index.html
+++ b/ui/index.html
@@ -313,7 +313,7 @@
             <div id="preview-content">
                 <div id="preview-tools" class="displayNone">
                     <button id="clear-all-previews" class="secondaryButton"><i class="fa-solid fa-trash-can icon"></i> Clear All</button>
-                    <button class="tertiaryButton" id="show-download-popup"><i class="fa-solid fa-download"></i> Download images</button>
+                    <button class="tertiaryButton" id="show-download-dialog"><i class="fa-solid fa-download"></i> Download images</button>
                     <div class="display-settings">
                         <button id="undo" class="displayNone primaryButton">
                             Undo <i class="fa-solid fa-rotate-left icon"></i>
@@ -464,31 +464,37 @@
         </div>
     </div>
 
-    <div class="popup" id="download-images-popup">
-        <div>
-            <i class="close-button fa-solid fa-xmark"></i>
-            <h1>Download all images</h1>
-            <div class="parameters-table">
-                <div>
-                    <div><i class="fa fa-file-zipper"></i></div>
-                    <div><label for="theme">Download as a ZIP file</label><small>Instead of downloading individual files, generate one zip file with all images</small></div>
-                    <div><div class="input-toggle"><input id="zip_toggle" name="zip_toggle" checked="" type="checkbox"><label for="zip_toggle"></label></div></div>
-                </div>
-                <div id="download-add-folders">
-                    <div><i class="fa fa-folder-tree"></i></div>
-                    <div><label for="theme">Add per-job folders</label><small>Place images into job folders</small></div>
-                    <div><div class="input-toggle"><input id="tree_toggle" name="tree_toggle" checked="" type="checkbox"><label for="tree_toggle"></label></div></div>
-                </div>
-                <div>
-                    <div><i class="fa fa-sliders"></i></div>
-                    <div><label for="theme">Add metadata files</label><small>For each image, also download a JSON file with all the settings used to generate the image</small></div>
-                    <div><div class="input-toggle"><input id="json_toggle" name="json_toggle" checked="" type="checkbox"><label for="json_toggle"></label></div></div>
-                </div>
+    <dialog id="download-images-dialog">
+        <div class="dialog-header">
+            <div class="dialog-header-left">
+                <h4>Download all images</h4>
+                <span></span>
             </div>
-            <br/>
+            <div>
+                <i id="download-images-close-button" class="fa-solid fa-xmark fa-lg"></i>
+            </div>
+        </div>
+        <div class="parameters-table">
+            <div>
+                <div><i class="fa fa-file-zipper"></i></div>
+                <div><label for="theme">Download as a ZIP file</label><small>Instead of downloading individual files, generate one zip file with all images</small></div>
+                <div><div class="input-toggle"><input id="zip_toggle" name="zip_toggle" checked="" type="checkbox"><label for="zip_toggle"></label></div></div>
+            </div>
+            <div id="download-add-folders">
+                <div><i class="fa fa-folder-tree"></i></div>
+                <div><label for="theme">Add per-job folders</label><small>Place images into job folders</small></div>
+                <div><div class="input-toggle"><input id="tree_toggle" name="tree_toggle" checked="" type="checkbox"><label for="tree_toggle"></label></div></div>
+            </div>
+            <div>
+                <div><i class="fa fa-sliders"></i></div>
+                <div><label for="theme">Add metadata files</label><small>For each image, also download a JSON file with all the settings used to generate the image</small></div>
+                <div><div class="input-toggle"><input id="json_toggle" name="json_toggle" checked="" type="checkbox"><label for="json_toggle"></label></div></div>
+            </div>
+        </div>
+        <div class="center">
             <button id="save-all-images" class="primaryButton"><i class="fa-solid fa-images"></i> Start download</button>
         </div>
-    </div>
+    </dialog>
     <div id="save-settings-config" class="popup">
         <div>
             <i class="close-button fa-solid fa-xmark"></i>
diff --git a/ui/media/css/main.css b/ui/media/css/main.css
index 922aabff..5bce8a24 100644
--- a/ui/media/css/main.css
+++ b/ui/media/css/main.css
@@ -484,7 +484,7 @@ dialog {
 }
 
 dialog::backdrop {
-    background: rgba(0, 0, 0, 0.5);
+    background: var(--backdrop-color);
 }
 
 dialog > div {
@@ -1447,10 +1447,18 @@ button#save-system-settings-btn {
     line-height: 200%;
 }
 
-#download-images-popup .parameters-table > div {
+#download-images-dialog .parameters-table > div {
     background: var(--background-color1);
 }
 
+.center {
+    text-align: center;
+}
+
+.fa-xmark {
+    cursor: pointer;;
+}
+
 /* SCROLLBARS */
 :root {
     --scrollbar-width: 14px;
diff --git a/ui/media/css/themes.css b/ui/media/css/themes.css
index 1fd77b25..30d20a28 100644
--- a/ui/media/css/themes.css
+++ b/ui/media/css/themes.css
@@ -1,4 +1,4 @@
-:root {
+:root, ::backdrop {
     --main-hue: 222;
 	--main-saturation: 4%;
 	--value-base: 13%;
diff --git a/ui/media/js/image-modifiers.js b/ui/media/js/image-modifiers.js
index a92a3e40..a5de2949 100644
--- a/ui/media/js/image-modifiers.js
+++ b/ui/media/js/image-modifiers.js
@@ -565,12 +565,5 @@ modifierSettingsCloseBtn.addEventListener("click", (e) => {
     modifierSettingsDialog.close()    
 })
 
-modifierSettingsDialog.addEventListener('mousedown', function (event) {
-    var rect = modifierSettingsDialog.getBoundingClientRect();
-    var isInDialog=(rect.top <= event.clientY && event.clientY <= rect.top + rect.height
-      && rect.left <= event.clientX && event.clientX <= rect.left + rect.width);
-    if (!isInDialog) {
-        modifierSettingsDialog.close();
-    }
-});
+modalDialogCloseOnBackdropClick(modifierSettingsDialog)
 
diff --git a/ui/media/js/main.js b/ui/media/js/main.js
index 20299b10..5aecf73d 100644
--- a/ui/media/js/main.js
+++ b/ui/media/js/main.js
@@ -132,9 +132,10 @@ let initialText = document.querySelector("#initial-text")
 let versionText = document.querySelector("#version")
 let previewTools = document.querySelector("#preview-tools")
 let clearAllPreviewsBtn = document.querySelector("#clear-all-previews")
-let showDownloadPopupBtn = document.querySelector("#show-download-popup")
-let saveAllImagesPopup = document.querySelector("#download-images-popup")
+let showDownloadDialogBtn = document.querySelector("#show-download-dialog")
+let saveAllImagesDialog = document.querySelector("#download-images-dialog")
 let saveAllImagesBtn = document.querySelector("#save-all-images")
+let saveAllImagesCloseBtn = document.querySelector("#download-images-close-button")
 let saveAllZipToggle = document.querySelector("#zip_toggle")
 let saveAllTreeToggle = document.querySelector("#tree_toggle")
 let saveAllJSONToggle = document.querySelector("#json_toggle")
@@ -1503,9 +1504,9 @@ clearAllPreviewsBtn.addEventListener("click", (e) => {
 })
 
 /* Download images popup */
-showDownloadPopupBtn.addEventListener("click", (e) => {
-    saveAllImagesPopup.classList.add("active")
-})
+showDownloadDialogBtn.addEventListener("click", (e) => { saveAllImagesDialog.showModal() }) 
+saveAllImagesCloseBtn.addEventListener("click", (e) => { saveAllImagesDialog.close() })
+modalDialogCloseOnBackdropClick(saveAllImagesDialog)
 
 saveAllZipToggle.addEventListener("change", (e) => {
     if (saveAllZipToggle.checked) {
diff --git a/ui/media/js/utils.js b/ui/media/js/utils.js
index 4c65bd00..a47114e3 100644
--- a/ui/media/js/utils.js
+++ b/ui/media/js/utils.js
@@ -1055,3 +1055,14 @@ async function deleteKeys(keyToDelete) {
         });
     }
 }
+
+function modalDialogCloseOnBackdropClick(dialog) {
+    dialog.addEventListener('mousedown', function (event) {
+        var rect = dialog.getBoundingClientRect()
+        var isInDialog=(rect.top <= event.clientY && event.clientY <= rect.top + rect.height
+          && rect.left <= event.clientX && event.clientX <= rect.left + rect.width)
+        if (!isInDialog) {
+            dialog.close()
+        }
+    })
+}
diff --git a/ui/plugins/ui/tiled-image-download.plugin.js b/ui/plugins/ui/tiled-image-download.plugin.js
index 277234e2..fbc9fd28 100644
--- a/ui/plugins/ui/tiled-image-download.plugin.js
+++ b/ui/plugins/ui/tiled-image-download.plugin.js
@@ -35,7 +35,7 @@
                    <h4>Download tiled image</h4>
                    <span>Generate a larger image from this tile</span>
                </div>
-               <div id="modifier-settings-header-right">
+               <div id="download-header-right">
                    <i id="downnload-tiled-close-button" class="fa-solid fa-xmark fa-lg"></i>
                </div>
            </div>
@@ -139,14 +139,7 @@
     // ---- Close popup
     document.getElementById("dti-cancel").addEventListener("click", (e) => downloadTiledImageDialog.close())
     document.getElementById("downnload-tiled-close-button").addEventListener("click", (e) => downloadTiledImageDialog.close())
-    downloadTiledImageDialog.addEventListener('click', function (event) {
-        var rect = downloadTiledImageDialog.getBoundingClientRect();
-        var isInDialog=(rect.top <= event.clientY && event.clientY <= rect.top + rect.height
-          && rect.left <= event.clientX && event.clientX <= rect.left + rect.width);
-        if (!isInDialog) {
-            downloadTiledImageDialog.close();
-        }
-    });
+    modalDialogCloseOnBackdropClick(downloadTiledImageDialog)
 
     // ---- Stylesheet
     const styleSheet = document.createElement("style")