holm/easydiffusion
1
0
Fork 0
forked from extern/easydiffusion
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix auto-scroll setting management

Browse Source 
After thinking about it, the auto-save toggle is meant for the *Editor* fields listed behind the Configure button. The auto-scroll toggle is not part of the Editor, and is more akin to a system setting, although it's placed in the main UI for convenience reasons related to its nature. As such, and especially considering it's a plugin, I lean towards decoupling auto-scroll from the auto-save settings, and just storing it independently.
This commit is contained in:
patriceac 2022-12-09 19:34:41 -08:00 committed by GitHub
parent e3184622e8
commit b330c34b29
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ui/plugins/ui/Autoscroll.plugin.js
View File

@ -17,17 +17,11 @@
prettifyInputs(document); prettifyInputs(document);
let autoScroll = document.querySelector("#auto_scroll") let autoScroll = document.querySelector("#auto_scroll")
/** // save/restore the toggle state
* the use of initSettings() in the autoscroll plugin seems to be breaking the models dropdown and the save-to-disk folder field autoScroll.addEventListener('click', (e) => {
* in the settings tab. They're both blank, because they're being re-initialized. Their earlier values came from the API call, localStorage.setItem('auto_scroll', autoScroll.checked)
* but those values aren't stored in localStorage, since they aren't user-specified. })
* So when initSettings() is called a second time, it overwrites the values with an empty string. autoScroll.checked = localStorage.getItem('auto_scroll') == "true"
*
* We could either rework how new components can register themselves to be auto-saved, without having to call initSettings() again.
* Or we could move the autoscroll code into the main code, and include it in the list of fields in auto-save.js
*/
// SETTINGS_IDS_LIST.push("auto_scroll")
// initSettings()
// observe for changes in the preview pane // observe for changes in the preview pane
var observer = new MutationObserver(function (mutations) { var observer = new MutationObserver(function (mutations) {