From 2de3cdb780c4b30f63f1365b1d7b72ee6a3d456c Mon Sep 17 00:00:00 2001
From: Ralf Becker <ralfbecker@outdoor-training.de>
Date: Thu, 12 Dec 2013 02:40:31 +0000
Subject: [PATCH] fix encoding of favorites, so they can eg. contain single
 quotes

---
 phpgwapi/inc/class.egw_framework.inc.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/phpgwapi/inc/class.egw_framework.inc.php b/phpgwapi/inc/class.egw_framework.inc.php
index 188f875a08..7ee49fe3b9 100644
--- a/phpgwapi/inc/class.egw_framework.inc.php
+++ b/phpgwapi/inc/class.egw_framework.inc.php
@@ -1811,7 +1811,7 @@ $LAB.setOptions({AlwaysPreserveOrder:true,BasePath:"'.$GLOBALS['egw_info']['serv
 		{
 			$href = "javascript:app.$app.setState(" . json_encode($filter,JSON_FORCE_OBJECT) . ');';
 			$html .= "<li data-id='$name' class='ui-menu-item' role='menuitem'>\n";
-			$html .= "<a href='$href' class='ui-corner-all' tabindex='-1'>";
+			$html .= '<a href="'.htmlspecialchars($href).'" class="ui-corner-all" tabindex="-1">';
 			$html .= "<div class='" . ($name == $default_filter ? 'ui-icon ui-icon-heart' : 'sideboxstar') . "'></div>".
 				$filter['name'] .($filter['group'] != false ? " ♦" :"");
 			$html .= ($filter['group'] != false && !$is_admin || $name == 'blank' ? "" :
@@ -1822,7 +1822,7 @@ $LAB.setOptions({AlwaysPreserveOrder:true,BasePath:"'.$GLOBALS['egw_info']['serv
 		// If were're here, the app supports favorites, so add a 'Add' link too
 		$html .= "<li class='ui-menu-item' role='menuitem'><a href='javascript:app.$app.add_favorite()' class='ui-corner-all'>";
 		$html .= html::image($app, 'new') . lang('Add current'). '</a></li>';
-		
+
 		$html .= '</ul></span>';
 
 		return $html;