holm/egroupware
1
1
Fork 0
forked from extern/egroupware
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- Add some more parameter types

Browse Source 
- Solve the uninitialized attribute issue (for insertChild() called from constructor at least)
This commit is contained in:
nathangray 2020-01-22 10:19:07 -07:00 committed by Hadi Nategh
parent 0b50545cc1
commit 43a9100c91
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
api/js/etemplate/et2_core_widget.ts
View File

@ -368,7 +368,7 @@ export class et2_widget extends ClassWithAttributes
* @param _node is the node which should be added. It has to be an instance * @param _node is the node which should be added. It has to be an instance
* of et2_widget * of et2_widget
*/ */
addChild(_node) addChild(_node : et2_widget)
{ {
this.insertChild(_node, this._children.length); this.insertChild(_node, this._children.length);
} }
@ -380,7 +380,7 @@ export class et2_widget extends ClassWithAttributes
* of et2_widget * of et2_widget
* @param _idx is the position at which the element should be added. * @param _idx is the position at which the element should be added.
*/ */
insertChild(_node, _idx) insertChild(_node : et2_widget, _idx: number)
{ {
// Check whether the node is one of the supported widget classes. // Check whether the node is one of the supported widget classes.
if (this.isOfSupportedWidgetClass(_node)) { if (this.isOfSupportedWidgetClass(_node)) {
@ -391,13 +391,15 @@ export class et2_widget extends ClassWithAttributes
_node._parent = this; _node._parent = this;
this._children.splice(_idx, 0, _node); this._children.splice(_idx, 0, _node);
/*
if (_node.implements(et2_IDOMNode) && this.implements(et2_IDOMNode) && _node.parentNode) { Comment this out (for now)
if (_node.implements(et2_IDOMNode) && this.implements(et2_IDOMNode) && typeof _node.hasOwnProperty('parentNode') )
{
_node.detachFromDOM(); _node.detachFromDOM();
_node.parentNode = (<et2_IDOMNode><unknown>this).getDOMNode(_node); _node.parentNode = (<et2_IDOMNode><unknown>this).getDOMNode(_node);
_node.attachToDOM(); _node.attachToDOM();
} }
*/
} else { } else {
this.egw().debug("error", "Widget " + _node._type + " is not supported by this widget class", this); this.egw().debug("error", "Widget " + _node._type + " is not supported by this widget class", this);
// throw("Widget is not supported by this widget class!"); // throw("Widget is not supported by this widget class!");