forked from extern/egroupware
Et2Select: In some cases the change event from the search input was triggering an extra widget change event
This commit is contained in:
parent
6fb464d90b
commit
46b172c88e
@ -146,7 +146,6 @@ export class Et2Select extends Et2WithSearchMixin(Et2WidgetWithSelect)
|
||||
|
||||
this.updateComplete.then(() =>
|
||||
{
|
||||
this.addEventListener("sl-clear", this._triggerChange)
|
||||
this.addEventListener("sl-change", this._triggerChange);
|
||||
this.addEventListener("sl-after-show", this._doResize)
|
||||
});
|
||||
|
@ -448,18 +448,16 @@ export const Et2WithSearchMixin = <T extends Constructor<LitElement>>(superclass
|
||||
this.addEventListener("sl-blur", this._handleSearchAbort);
|
||||
this.addEventListener("sl-select", this._handleSelect);
|
||||
this.addEventListener("sl-clear", this._handleClear)
|
||||
if(this._oldChange && this.onchange)
|
||||
this.updateComplete.then(() =>
|
||||
{
|
||||
this.updateComplete.then(() =>
|
||||
{
|
||||
// Search messes up event order. Since it throws its own bubbling change event,
|
||||
// selecting an option fires 2 change events - 1 before the widget is finished adjusting, losing the value
|
||||
// We catch all change events, then call this._oldChange only when value changes
|
||||
this.removeEventListener("change", this._oldChange);
|
||||
this.addEventListener("change", this._handleChange);
|
||||
});
|
||||
}
|
||||
|
||||
// Search messes up event order. Since it throws its own bubbling change event,
|
||||
// selecting an option fires 2 change events - 1 before the widget is finished adjusting, losing the value
|
||||
// We catch all change events, then call this._oldChange only when value changes
|
||||
this.removeEventListener("change", this._oldChange);
|
||||
// Need our own change to catch the change event from search input
|
||||
this.addEventListener("change", this._handleChange);
|
||||
});
|
||||
|
||||
this._searchButtonNode.addEventListener("click", this._handleSearchButtonClick);
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user