The issue that this fix addresses is the following:

When using the uiaccountsel widget to select accounts, when you accidently
select something and want to deselect it, when you delete the item, the item
is only unhighlighted, and not removed from the uiaccountsel_popup_selection
select box in the opener document. This patch simply deletes the child node
from the uiaccountsel_popup_selection select box instead of setting the
selected false.

I've tested this with some variant of msie6/xp, mozilla 1.6/win32, firefox 0.9.3/linux
and mozilla 1.4.3/linux.
This commit is contained in:
mgalgoci 2004-08-18 19:42:23 +00:00
parent 02d78c172d
commit 484765bd96
2 changed files with 2 additions and 2 deletions

View File

@ -30,7 +30,7 @@
if (selectBox.options[i].selected) { if (selectBox.options[i].selected) {
for (j=0; j < openerSelectBox.length; j++) { for (j=0; j < openerSelectBox.length; j++) {
if (openerSelectBox[j].value == selectBox.options[i].value) { if (openerSelectBox[j].value == selectBox.options[i].value) {
openerSelectBox[j].selected = false; openerSelectBox.removeChild(openerSelectBox[j]);
} }
} }
selectBox.options[i--] = null; selectBox.options[i--] = null;

View File

@ -30,7 +30,7 @@
if (selectBox.options[i].selected) { if (selectBox.options[i].selected) {
for (j=0; j < openerSelectBox.length; j++) { for (j=0; j < openerSelectBox.length; j++) {
if (openerSelectBox[j].value == selectBox.options[i].value) { if (openerSelectBox[j].value == selectBox.options[i].value) {
openerSelectBox[j].selected = false; openerSelectBox.removeChild(openerSelectBox[j]);
} }
} }
selectBox.options[i--] = null; selectBox.options[i--] = null;