holm/egroupware
1
1
Fork 0
forked from extern/egroupware
Code Issues Pull Requests Packages Projects Releases Wiki Activity

To improve performance for people/installations with large amounts of infologs and many customfields who want to use customfields in customized

Browse Source 
templates, but do not want to use the customfields in listview, reworked the logic of the retrieval of customfields. 
Fix for the retrieve more fields, than selected - problem, when customfields start with the same string. Replaced stripos by in_array after a split 
of the selected cols.
This commit is contained in:
Klaus Leithoff 2008-02-26 13:16:59 +00:00
parent 8afe9094b7
commit 75b824bced
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
infolog/inc/class.soinfolog.inc.php
View File

@ -804,16 +804,24 @@ class soinfolog // DB-Layer
$ids[$info['info_id']] = $info;
}
if ($ids && $query['custom_fields'])
// prepare selected cols array
$sca=explode(',',$query['selectcols']);
if ($ids)
{
$this->db->select($this->extra_table,'*',array('info_id'=>array_keys($ids)),__LINE__,__FILE__);
while ($row = $this->db->row(true))
{
if ((isset($row['info_extra_value'])&&strlen($row['info_extra_value'])>0) &&
(stripos($query['selectcols'],'#'.$row['info_extra_name'])!==FALSE || !isset($query['selectcols']) ||
(stripos($query['selectcols'],'#')===FALSE && stripos($query['selectcols'],'customfields')!==FALSE) ))
if ((isset($row['info_extra_value'])&&strlen($row['info_extra_value'])>0))
{
$ids[$row['info_id']]['#'.$row['info_extra_name']] = $row['info_extra_value'];
if ((in_array('#'.$row['info_extra_name'],$sca) || !isset($query['selectcols']) ||
(stripos($query['selectcols'],'#')===FALSE && stripos($query['selectcols'],'customfields')!==FALSE) ))
{
$ids[$row['info_id']]['#'.$row['info_extra_name']] = $row['info_extra_value'];
} else {
if (!$query['custom_fields']) {
$ids[$row['info_id']]['#'.$row['info_extra_name']] = $row['info_extra_value'];
}
}
} else {
unset($ids[$row['info_id']]['#'.$row['info_extra_name']]);
}