holm/egroupware
1
1
Fork 0
forked from extern/egroupware
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Et2LinkList: Fire change event when link is removed

Browse Source 
Avoid error if instance manager is missing
This commit is contained in:
nathan 2023-03-03 14:06:11 -07:00
parent 33058c4744
commit a35d3d8778
2 changed files with 45 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
api/js/etemplate/Et2Link/Et2LinkList.ts
View File

@ -113,6 +113,7 @@ export class Et2LinkList extends Et2LinkString
this._handleRowContext = this._handleRowContext.bind(this); this._handleRowContext = this._handleRowContext.bind(this);
this._handleChange = this._handleChange.bind(this); this._handleChange = this._handleChange.bind(this);
this._handleLinkToChange = this._handleLinkToChange.bind(this);
} }
connectedCallback() connectedCallback()
@ -121,20 +122,29 @@ export class Et2LinkList extends Et2LinkString
this._createContextMenu(); this._createContextMenu();
// Look for LinkTo and listen for change so we can update // Look for LinkTo and listen for change so we can update
if(this.getInstanceManager())
{
this.getInstanceManager().DOMContainer.querySelectorAll("et2-link-to").forEach(link => this.getInstanceManager().DOMContainer.querySelectorAll("et2-link-to").forEach(link =>
{ {
link.addEventListener("et2-change", this._handleChange); link.addEventListener("et2-change", this._handleLinkToChange);
}) })
} }
this.addEventListener("change", this._handleChange);
}
disconnectedCallback() disconnectedCallback()
{ {
super.disconnectedCallback(); super.disconnectedCallback();
if(this.getInstanceManager())
{
this.getInstanceManager().DOMContainer.querySelectorAll("et2-link-to").forEach(link => this.getInstanceManager().DOMContainer.querySelectorAll("et2-link-to").forEach(link =>
{ {
link.removeEventListener("et2-change", this._handleChange); link.removeEventListener("et2-change", this._handleLinkToChange);
}) })
} }
this.removeEventListener("change", this._handleChange);
}
protected _listTemplate() protected _listTemplate()
{ {
@ -247,13 +257,27 @@ export class Et2LinkList extends Et2LinkString
} }
} }
/**
* Handle & pass on an internal change
* @param {ChangeEvent} _event
* @protected
*/
protected _handleChange(_event : Event)
{
if(!this.onchange)
{
return;
}
this.onchange(this, _event.data, _event)
}
/** /**
* We listen to LinkTo widgets so we can update * We listen to LinkTo widgets so we can update
* *
* @param _ev * @param _ev
* @protected * @protected
*/ */
protected _handleChange(_ev) protected _handleLinkToChange(_ev)
{ {
if(_ev && typeof _ev.currentTarget) if(_ev && typeof _ev.currentTarget)
{ {
@ -301,7 +325,9 @@ export class Et2LinkList extends Et2LinkString
return html``; return html``;
} }
return html` return html`
<et2-image class="delete_button" slot="${this._get_row_id(link)}" src="delete" ._parent=${this} <et2-image class="delete_button" slot="${this._get_row_id(link)}" src="delete"
part="delete-button"
._parent=${this}
.onclick=${() => .onclick=${() =>
{ {
this._delete_link(link); this._delete_link(link);
@ -341,6 +367,9 @@ export class Et2LinkList extends Et2LinkString
this._link_list.splice(this._link_list.indexOf(link), 1); this._link_list.splice(this._link_list.indexOf(link), 1);
} }
this.dispatchEvent(new CustomEvent("et2-delete", {bubbles: true, detail: link})); this.dispatchEvent(new CustomEvent("et2-delete", {bubbles: true, detail: link}));
let change = new Event("change", {bubbles: true});
change['data'] = link;
this.dispatchEvent(change);
}; };
// Unsaved entry, had no ID yet // Unsaved entry, had no ID yet
@ -391,7 +420,12 @@ export class Et2LinkList extends Et2LinkString
for(let id in list) for(let id in list)
{ {
let link = list[id]; let link = list[id];
if(link.app) if(!link.app && typeof list.splice !== "undefined")
{
list.splice(parseInt(id), 1);
continue;
}
else if(link.app)
{ {
// Temp IDs can cause problems since the ID includes the file name or : // Temp IDs can cause problems since the ID includes the file name or :
if(link.link_id && typeof link.link_id != 'number') if(link.link_id && typeof link.link_id != 'number')
@ -415,9 +449,9 @@ export class Et2LinkList extends Et2LinkString
{ {
link.title = link.id.name || ''; link.title = link.id.name || '';
} }
(<LinkInfo[]>this._link_list).push(<LinkInfo>link);
} }
} }
this._addLinks(list);
} }
else else
{ {

2
api/js/etemplate/Et2Link/Et2LinkString.ts
View File

@ -248,7 +248,7 @@ export class Et2LinkString extends Et2Widget(LitElement) implements et2_IDetache
); );
*/ */
this.dispatchEvent(new Event("change", {bubbles: true}));
} }
/** /**