holm/egroupware
1
1
Fork 0
forked from extern/egroupware
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Etemplate - fully implement label widget's "for" attribute

Browse Source
This commit is contained in:
nathangray 2019-08-13 13:28:56 -06:00
parent 45ea4cb81a
commit be6325a68c
1 changed files with 31 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
api/js/etemplate/et2_widget_description.js
View File

@ -118,11 +118,7 @@ var et2_description = (function(){ "use strict"; return expose(et2_baseWidget.ex
this.span = jQuery(document.createElement(this.options["for"] ? "label" : "span")) this.span = jQuery(document.createElement(this.options["for"] ? "label" : "span"))
.addClass("et2_label"); .addClass("et2_label");
if (this.options["for"])
{
// TODO: Get the real id of the widget in the doLoadingFinished method.
this.span.attr("for", this.options["for"]);
}
et2_insertLinkText(this._parseText(this.options.value), this.span[0], et2_insertLinkText(this._parseText(this.options.value), this.span[0],
this.options.href ? this.options.extra_link_target : '_blank'); this.options.href ? this.options.extra_link_target : '_blank');
@ -144,6 +140,36 @@ var et2_description = (function(){ "use strict"; return expose(et2_baseWidget.ex
} }
}, },
doLoadingFinished: function() {
this._super.apply(this, arguments);
// Get the real id of the 'for' widget
var for_widget = null;
if (this.options["for"] && (
(for_widget = this.getParent().getWidgetById(this.options.for)) ||
(for_widget = this.getRoot().getWidgetById(this.options.for))
) && for_widget && for_widget.id)
{
if(for_widget.dom_id)
{
this.span.attr("for", for_widget.dom_id);
}
else
{
// Target widget is not done yet, need to wait
var tab_deferred = jQuery.Deferred();
window.setTimeout(function() {
this.span.attr("for", for_widget.dom_id);
tab_deferred.resolve();
}.bind(this),0);
return tab_deferred.promise();
}
}
return true;
},
set_label: function(_value) { set_label: function(_value) {
// Abort if ther was no change in the label // Abort if ther was no change in the label
if (_value == this.label) if (_value == this.label)