holm/egroupware
1
1
Fork 0
forked from extern/egroupware
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make sure favorite group widget gets cleaned up

Browse Source
This commit is contained in:
Nathan Gray 2013-10-09 12:14:36 +00:00
parent 33a88ea089
commit bfe208c013
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
etemplate/js/et2_widget_favorites.js
View File

@ -178,6 +178,11 @@ var et2_favorites = et2_dropdown_button.extend([et2_INextmatchHeader],
destroy: function() { destroy: function() {
if(this.popup != null) if(this.popup != null)
{ {
if(this.popup.group)
{
this.popup.group.free();
delete this.popup.group;
}
this.popup.dialog("destroy"); this.popup.dialog("destroy");
this.popup = null; this.popup = null;
} }
@ -290,7 +295,7 @@ var et2_favorites = et2_dropdown_button.extend([et2_INextmatchHeader],
{ {
options.add = "<img src='"+this.egw().image("new") +"'/>Add current"; options.add = "<img src='"+this.egw().image("new") +"'/>Add current";
} }
widget.set_select_options(options); widget.set_select_options.call(widget,options);
// Set radio to current value // Set radio to current value
$j("input[value='"+ this.preferred +"']:radio", this.menu).attr("checked",true); $j("input[value='"+ this.preferred +"']:radio", this.menu).attr("checked",true);
@ -452,6 +457,13 @@ var et2_favorites = et2_dropdown_button.extend([et2_INextmatchHeader],
{ {
var self = this; var self = this;
// Clear old, if existing
if(this.popup && this.popup.group)
{
this.popup.group.free();
delete this.popup;
}
// Create popup // Create popup
this.popup = $j('<div id="'+this.dom_id + '_nm_favorites_popup" title="' + egw().lang("New favorite") + '">\ this.popup = $j('<div id="'+this.dom_id + '_nm_favorites_popup" title="' + egw().lang("New favorite") + '">\
<form>\ <form>\