Prevent apps from modifying favorites by reference.

Fixes projectmanager favorites stop working
2015-10-01 14:55:01 +00:00 · 2015-10-01 14:55:01 +00:00 · cace3b27c9
commit cace3b27c9
parent 2240eb3105
1 changed files with 2 additions and 1 deletions
--- a/phpgwapi/js/jsapi/app_base.js
+++ b/phpgwapi/js/jsapi/app_base.js
@ -385,7 +385,8 @@ var AppJS = Class.extend(
 					var pref = egw.preference('favorite_' + this.dataset.id, self.appname);
 					if(pref)
 					{
-						state = pref;
+						// Extend, to prevent changing the preference by reference
+						jQuery.extend(true, state, pref);
 					}
 					if(this.dataset.id != 'add')
 					{