From dc073f858ab6daabd527dc3728fcaf7c8ec36224 Mon Sep 17 00:00:00 2001 From: Ralf Becker Date: Tue, 4 Dec 2018 17:05:39 +0100 Subject: [PATCH] fix tabs added by code where not reported and sometimes missing clickable class for image buttons --- api/js/etemplate/et2_widget_button.js | 1 + api/js/etemplate/et2_widget_tabs.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/api/js/etemplate/et2_widget_button.js b/api/js/etemplate/et2_widget_button.js index d35d6e9c33..71a3ff0c14 100644 --- a/api/js/etemplate/et2_widget_button.js +++ b/api/js/etemplate/et2_widget_button.js @@ -91,6 +91,7 @@ var et2_button = (function(){ "use strict"; return et2_baseWidget.extend([et2_II { this.image = jQuery(document.createElement("img")) .addClass("et2_button et2_button_icon"); + if (!this.options.readonly) this.image.addClass("et2_clickable"); this.setDOMNode(this.image[0]); return; } diff --git a/api/js/etemplate/et2_widget_tabs.js b/api/js/etemplate/et2_widget_tabs.js index 257f1b0d0b..76e176df4b 100644 --- a/api/js/etemplate/et2_widget_tabs.js +++ b/api/js/etemplate/et2_widget_tabs.js @@ -216,7 +216,7 @@ var et2_tabbox = (function(){ "use strict"; return et2_valueWidget.extend([et2_I tab_options.content = tab.id; } tabData[tab.prepend ? 'unshift' : 'push'].call(tabData, { - "id": tab.id, + "id": tab_id, "label": this.egw().lang(tab.label), "widget": null, "widget_options": tab_options,