Fix couple of IDE warnings

This commit is contained in:
Hadi Nategh 2015-08-06 09:43:32 +00:00
parent a4b850cd8d
commit e109d06e0d

View File

@ -1499,7 +1499,7 @@ app.classes.mail = AppJS.extend(
{ {
var res = _rowID.split('::'); var res = _rowID.split('::');
// as a rowID is perceeded by app::, should be mail! // as a rowID is perceeded by app::, should be mail!
if (res.length==4 && parseInt(res[0])!=NaN ) if (res.length==4 && !isNaN(parseInt(res[0])))
{ {
// we have an own created rowID; prepend app=mail // we have an own created rowID; prepend app=mail
res.unshift('mail'); res.unshift('mail');
@ -2666,7 +2666,7 @@ app.classes.mail = AppJS.extend(
egw_openWindowCentered(url,'import_mail_'+_elems[0].id,w_h[0],w_h[1]); egw_openWindowCentered(url,'import_mail_'+_elems[0].id,w_h[0],w_h[1]);
} }
},this,true,this).sendRequest(); },this,true,this).sendRequest();
} };
if (mail_import_hook && typeof mail_import_hook.app_entry_method != 'undefined') if (mail_import_hook && typeof mail_import_hook.app_entry_method != 'undefined')
{ {
@ -3371,7 +3371,7 @@ app.classes.mail = AppJS.extend(
that._do_action(typeId, actionData['data'],ruleID); that._do_action(typeId, actionData['data'],ruleID);
} }
}; };
var confirmDeleteDialog = et2_dialog.show_dialog(callbackDeleteDialog, this.egw.lang("Do you really want to DELETE this Rule"),this.egw.lang("Delete"), {},et2_dialog.BUTTONS_YES_CANCEL, et2_dialog.WARNING_MESSAGE); et2_dialog.show_dialog(callbackDeleteDialog, this.egw.lang("Do you really want to DELETE this Rule"),this.egw.lang("Delete"), {},et2_dialog.BUTTONS_YES_CANCEL, et2_dialog.WARNING_MESSAGE);
break; break;
case 'add' : case 'add' :
@ -3558,7 +3558,7 @@ app.classes.mail = AppJS.extend(
if (egwIsMobile()) if (egwIsMobile())
{ {
var nm = this.et2.getWidgetById(this.nm_index); var nm = this.et2.getWidgetById(this.nm_index);
nm.set_disabled(!!_url) nm.set_disabled(!!_url);
iframe.set_disabled(!_url); iframe.set_disabled(!_url);
} }
// Set extra_iframe a class with height and width // Set extra_iframe a class with height and width
@ -4300,7 +4300,7 @@ app.classes.mail = AppJS.extend(
{ {
emails.splice(itemIndex,1); emails.splice(itemIndex,1);
// Resolve the dist list and normal emails // Resolve the dist list and normal emails
var dist = resolveDistList(_widget, emails) var dist = resolveDistList(_widget, emails);
// Add normal emails // Add normal emails
_widget.set_value(emails); _widget.set_value(emails);