holm/egroupware
1
1
Fork 0
forked from extern/egroupware
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Hopefully fix missing non-reflected attributes in nm rows without too much of a speed penalty

Browse Source
This commit is contained in:
nathan 2022-07-28 09:56:59 -06:00
parent 0113a93ffd
commit e1885983d5
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
api/js/etemplate/et2_extension_nextmatch_rowProvider.ts
View File

@ -266,18 +266,18 @@ export class et2_nextmatch_rowProvider
*/
_cloneWebComponent(entry, row, data)
{
/*
// N.B. cloneNode widget is missing its unreflected properties and we need to use widget.clone()
// instead to get them. This slows things down and is to be avoided if we can.
let c = widget.clone();
let partial = entry.nodeFuncs[0](row);
partial.parentNode.insertBefore(c, partial);
partial.parentNode.removeChild(partial);
widget = c;
*/
// Use the clone, not the original
// Widget was already cloned from original row, just get it
let widget = entry.nodeFuncs[0](row);
// Original widget
let original = entry.nodeFuncs[0](this._dataRow);
// N.B. cloneNode widget is missing its unreflected properties and we need to get them from original
let widget_class = window.customElements.get(widget.localName);
let properties = widget_class ? widget_class.properties : [];
for(let key in properties)
{
widget[key] = original[key];
}
if(!widget || widget.localName !== entry.widget.localName)
{