holm/egroupware
1
1
Fork 0
forked from extern/egroupware
Code Issues Pull Requests Packages Projects Releases Wiki Activity

replace unnecessary post submits with regular ajax submits, also added a couple more todos

Browse Source
This commit is contained in:
Ralf Becker 2013-10-04 14:43:56 +00:00
parent 2a502c3a16
commit ec2de1c7e6
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
etemplate/js/et2_core_legacyJSFunctions.js
View File

@ -6,7 +6,7 @@
* @subpackage api * @subpackage api
* @link http://www.egroupware.org * @link http://www.egroupware.org
* @author Andreas Stöckel * @author Andreas Stöckel
* @copyright Stylite 2011 * @copyright Stylite 2011-13
* @version $Id: et2_core_phpExpressionCompiler.js 38256 2012-03-05 13:07:38Z igel457 $ * @version $Id: et2_core_phpExpressionCompiler.js 38256 2012-03-05 13:07:38Z igel457 $
*/ */
@ -30,6 +30,9 @@
* *
* @param string _val onclick, onchange, ... action * @param string _val onclick, onchange, ... action
* @param string _cname name-prefix / name-space * @param string _cname name-prefix / name-space
* @ToDo replace xajax_doXMLHTTP with egw.json()
* @ToDo replace (common) cases of confirm with new dialog, idea: calling function supplys function to call after confirm
* @ToDo template::styles(name) inserts the styles of a named template
* @return string * @return string
*/ */
function js_pseudo_funcs(_val,widget) function js_pseudo_funcs(_val,widget)
@ -81,7 +84,7 @@
if (_val.indexOf('this.form.submit()') != -1) if (_val.indexOf('this.form.submit()') != -1)
{ {
_val = _val.replace('this.form.submit()','widget.getInstanceManager().postSubmit()'); _val = _val.replace('this.form.submit()','widget.getInstanceManager().submit()');
} }
return _val; return _val;
} }
@ -93,8 +96,7 @@
// Check whether _code is simply "1" -- if yes replace it accordingly // Check whether _code is simply "1" -- if yes replace it accordingly
if (_code === '1') if (_code === '1')
{ {
_code = 'widget.getInstanceManager().postSubmit(); return true;'; _code = 'widget.getInstanceManager().submit(); return true;';
egw().debug("warn", "Widget uses 1 as JS. Full submit used instead, but this should be changed", _widget, _context);
} }
// Check whether some pseudo-variables still reside inside of the code, // Check whether some pseudo-variables still reside inside of the code,