From edd8be4355cda16318b1261d93451719da68c887 Mon Sep 17 00:00:00 2001 From: Hadi Nategh Date: Wed, 13 Nov 2019 11:50:30 +0100 Subject: [PATCH] * All apps favorites: fix issue add favorites popup dialog no longer works after add/remove columns from list --- api/js/jsapi/app_base.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/api/js/jsapi/app_base.js b/api/js/jsapi/app_base.js index ace55f5af0..1e9085c17b 100644 --- a/api/js/jsapi/app_base.js +++ b/api/js/jsapi/app_base.js @@ -598,7 +598,9 @@ var AppJS = (function(){ "use strict"; return Class.extend( */ add_favorite: function(state) { - if(typeof this.favorite_popup == "undefined") + if(typeof this.favorite_popup == "undefined" || // Create popup if it's not defined yet + (this.favorite_popup && typeof this.favorite_popup.group !="undefiend" + && !this.favorite_popup.group.isAttached())) // recreate the favorite popup if the group selectbox is not attached (eg. after et2 submit) { this._create_favorite_popup(); }