holm/egroupware
1
1
Fork 0
forked from extern/egroupware
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use custom field name to toggle row visibility, not order, as order doesn't always work.

Browse Source
This commit is contained in:
Nathan Gray 2014-06-11 18:03:19 +00:00
parent 44ae90b8d3
commit f3ba7f692f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
etemplate/js/et2_extension_customfields.js
View File

@ -219,6 +219,7 @@ var et2_customfields_list = et2_valueWidget.extend([et2_IDetachedDOM, et2_IInput
// Add field label & help as data attribute to row, so it can be stylied with CSS (title should be disabled) // Add field label & help as data attribute to row, so it can be stylied with CSS (title should be disabled)
row.attr('title', field.label); row.attr('title', field.label);
row.attr('data-label', field.label); row.attr('data-label', field.label);
row.attr('data-field', field_name);
row.attr('data-help', field.help); row.attr('data-help', field.help);
this.detachedNodes.push(row[0]); this.detachedNodes.push(row[0]);
} else { } else {
@ -539,12 +540,11 @@ var et2_customfields_list = et2_valueWidget.extend([et2_IDetachedDOM, et2_IInput
// Individual widgets are detected and handled by the grid, but the interface is needed for this to happen // Individual widgets are detected and handled by the grid, but the interface is needed for this to happen
// Show the row if there's a value, hide it if there is no value // Show the row if there's a value, hide it if there is no value
var cf_index = 0 for(var i = 0; i < _nodes.length; i++)
for(var key in _values.fields)
{ {
// toggle() needs a boolean to do what we want // toggle() needs a boolean to do what we want
$j(_nodes[cf_index]).toggle(_values.fields[key] && _values.value[this.prefix + key]?true:false); var key = _nodes[i].dataset.field;
cf_index++; $j(_nodes[i]).toggle(_values.fields[key] && _values.value[this.prefix + key]?true:false);
} }
} }
}); });