Commit Graph

394 Commits

Author SHA1 Message Date
nathan
1faeffebee Stop Widget::get_array() creating unwanted indexes
When some widgets checked for value in beforeSendToClient() or validate(), they were accidentally creating a numeric index in nm content.  When these indexes built up over several submits, they caused problems with grids with repeating rows.

Fixes addressbook organisation column goes missing
2023-02-03 11:32:20 -07:00
nathan
2ab7079f13 Et2LinkString: Can now fetch its own link data, given application & entryId
Includes some fixes for only_app filter
2023-01-17 14:03:28 -07:00
nathan
374ba994a4 Customfield validation fixes
- customfield did not pass required setting on to widgets
- link entry did not support required
2023-01-13 11:28:02 -07:00
nathan
4f7b54c6bb Fix some more select attribute / legacy options issues 2023-01-11 15:49:56 -07:00
nathan
bc4423498a Fix option groups only kept the first group 2023-01-11 14:20:31 -07:00
nathan
f332b7bba5 Fully remove "tabs" attribute for tabbox, it overwrites the internal tabs collection.
Even checking for it sets 'tabs' attribute to null.  Use "extraTabs" instead.
2023-01-11 13:21:01 -07:00
nathan
18764aab64 Fix select-number could not get options server-side 2023-01-11 13:00:50 -07:00
nathan
9722716d1a Fix category select fails server-side validation, probably related to 8ec106f22b 2023-01-09 11:46:54 -07:00
nathan
c403edc49a Fix incorrect suggested password length 2023-01-05 15:35:04 -07:00
nathan
10ad1ae7c4 Also keep working for previous tag names 2023-01-05 14:21:38 -07:00
nathan
3ecd9c222b Fix switch widget did not validate value server-side 2023-01-05 14:06:39 -07:00
nathan
233b2f472c Fix duration in nextmatch row did not show correct value 2023-01-05 10:24:49 -07:00
nathan
578f2fc4b1 Fix customfields did not save 2023-01-05 10:04:29 -07:00
ralf
fefe82162e WIP converting filesystem templates to new syntax
- basically commiting what the preprocessor currently generates for the client-side
- server-side need to understand new syntax (et2-prefix and camelCase attribute-names) too
- preprocessor can now be called as cli to either echo-out the new template or replace in-place
- for now only modified edit-templates of addressbook, infolog and timesheet
- setting a new (not yet existing) DTD
2023-01-01 11:49:31 -06:00
nathan
3e54b25a91 Fix for option group validation 2022-12-20 15:45:50 -07:00
nathan
8764d51701 Force / respect password requirements set in site configuration when suggesting passwords 2022-12-06 14:32:14 -07:00
nathan
d38681279a Fix et2-number did not validate 2022-11-18 11:42:45 -07:00
ralf
8e3cedbf08 fix error deleting links to files (they have negative ids!) 2022-10-17 12:11:59 +02:00
nathan
479c90dc33 Pass custom filter attributes along
Fixes Status filter shows all possible values
2022-10-07 16:24:42 -06:00
nathan
f8e56edc20 Limit number of accounts (& other select/taglist search results) sent to client 2022-10-04 15:49:07 -06:00
nathan
00c9550465 Fix selects without empty_label were not allowed to be empty in some cases, even without required=true
For example select-account multiple=true, or customfield select-account with rows > 1 would give error "'' is NOT allowed ('not found')"
2022-09-23 09:39:50 -06:00
nathan
cfbb74b83e Fix some Et2DateDuration bugs
- Duration did not validate correctly
- Validation errors were not actually shown
- Empty duration ('') did not work consistently
2022-09-13 13:00:25 -06:00
ralf
26824323e5 got mailing lists working again in mail compose using includeLists=true attribute
using "$list_name <$list_id@lists.egroupware.org>" instead of just integer ids for the list, thought et2-select-mail is NOT displaying the mailing-list icon, after a mailing-list is selected
2022-09-12 14:51:13 +02:00
ralf
c31b99112d * Mail: remove left (and right) margin of p and div, which can interact bad with the signature 2022-09-06 15:41:45 +02:00
nathan
a3d2674757 Et2Select + search: Fix some bugs
- Select a searched value didn't validate due to different attribute name
- et2-searchbox inside et2-select threw an additional change event, needed to catch that
- fix_bad_value() needs different handling when you can search, otherwise it just gets cleared again
2022-08-31 13:28:20 -06:00
nathan
33dcbc218f Revert "Calendar: Fix some kanban listen problems"
This reverts commit 59e64cd908.
2022-08-25 10:16:05 -06:00
nathan
59e64cd908 Calendar: Fix some kanban listen problems
- Status filter isn't really applicable
- Priority was missing its options
2022-08-25 10:13:32 -06:00
nathan
0ae69429b5 Fix CustomFilterHeader did not work properly
Some transformations were not correctly handled, and events were therefor not bound
2022-08-16 09:29:08 -06:00
ralf
cad42eb6aa fix validation of taglist now send to select, specially using "id" attribute, if there is no "value"
also check modifications of select_options, as done in preferences
fixes not validating mail preferences: toggleOnActions and contactLabel
2022-08-10 14:39:19 +02:00
ralf
ea0cbd0441 account selection currently only need to use server-side search, for pref "Primary group and search"
for all other types the local search is sufficient, as everything is already local!
fix Taglist::ajax_search for accounts to pass the icon to client-side and always set value instead of id
2022-08-09 10:47:57 +02:00
ralf
e7eb9f42e3 fix many errors around et2-select emulating old taglist:
- preprocessor: translate attributes autocomplete_url -> searchUrl, autocomplete_params -> searchOptions, and allow options
- sending search query as URL/GET parameter with default of app: <appname>
- handle searchUrl like allowFreeEntries by adding selected result to select_options via createFreeEntries, as they otherwise get removed by fix_bad_value not finding the value in select_options
- change taglist validation (again) to not validate search values
- still requires changes in application code, as taglist always behaved like multiple=true (returning and expecting an array of values) and did automatically search from client-side for it's initial value(s)
--> maybe more changes are in order to NOT require changing application code
--> fixes editing Sieve rules
2022-08-08 17:28:51 +02:00
ralf
bb28500ef7 fix mail preferences could not be saved 2022-08-05 20:20:46 +02:00
ralf
d540576656 do NOT allow to call Api\Etemplate\Widget\Link::ajax_delete() without a positive link_id 2022-08-04 19:37:23 +02:00
nathan
e984ccf9a4 Fix double categories in nextmatch 2022-08-03 10:51:28 -06:00
nathan
7375768e25 Fix tabs=>extraTabs did not validate properly 2022-08-02 16:45:01 -06:00
ralf
b1660cc799 fix missing-eT2-request redirects sometimes use the webserver_url twice and therefore getting a 404 Not found 2022-07-31 09:29:43 +02:00
ralf
e90ae88a20 fix preprocessor and transformer can't know if application widget is a web-component or a legacy widget
- white-list now records-* like et2-* widgets for camelCase attribute names
- server-side transformer also transforms attribute-names to camelCase for widget-type et2-*
- client-side transformAttributes() also transforms attribute-names to camelCase for widget-type et2-*
--> hopefully this can be dropped, once als widgets are web-components
2022-07-22 11:08:55 +02:00
nathan
b20f57d5ba Fix select-type would not validate server side 2022-07-19 11:55:08 -06:00
nathan
1a2e691cbb Fix some bugs with static options being repeated
- Select Tab options being sent from server & cached
- Static options not properly set for all selects
2022-07-19 11:47:03 -06:00
nathan
dc23a18f85 Categories are cached client side now 2022-07-19 10:32:33 -06:00
ralf
bec95a4a9d et2-select-tab widget to fix common preferences not storing and some fixes 2022-07-19 15:17:43 +02:00
nathan
4256b589e7 Use substr instead of str_starts_with to avoid PHP 8.0 2022-07-15 13:40:18 -06:00
nathan
5793b462ba Fix et2-select widgets in template did not validate 2022-07-15 12:48:25 -06:00
nathan
96354be5ec Get text editor toolbar preference working with webcomponents 2022-07-14 13:22:48 -06:00
nathan
53e5e45a5d Better handling for options with more properties set (title, icon)
Previously they were being discarded
2022-07-14 13:16:48 -06:00
nathan
ed16ce52a2 Change nextmatch headers to use web components 2022-07-07 13:18:42 -06:00
nathan
c8ccf78550 Accept search & search options from SearchMixin
We want it in the signature, even if we don't use it right now.
2022-07-05 10:13:06 -06:00
ralf
a5fbb5c4ef fix 404 Not Found / wrong redirect after expired/no longer existing eT2 session 2022-07-05 08:43:53 +02:00
nathan
4f4b83733c Mail: Re-size header labels in display popup, change mail date widget to date-time-today 2022-06-28 10:18:42 -06:00
ralf
f2e20eddba fix addressbook edit for new Et2SelectCountry&State:
- using allowFreeEntries for custom country-names and storing, as before, region-name not the -code
- also fix flags to show nothing for custom / free country-names
Not entirely happy about it, but not willing to spend/waste more time on this tiny feature
2022-06-23 10:06:01 +02:00