Commit Graph

1142 Commits

Author SHA1 Message Date
Nathan Gray
726798c8cb Fix order, escape quotes first or the field delimiters get doubled 2010-12-17 16:59:02 +00:00
Nathan Gray
855c601f98 Escape double quotes 2010-12-17 16:45:57 +00:00
Klaus Leithoff
e3ee0b34fd * CSV Export: Replace CRLF with LF so excel does not break lines early (myStylite#974) 2010-12-16 15:07:19 +00:00
Klaus Leithoff
cc1310b6de Addressbook / Merge functions: remove error logging 2010-12-15 12:06:53 +00:00
Klaus Leithoff
f42b5cdbe9 * Addressbook / Merge functions: allow pagerepeat for merge in text/plain mimetypes/documents 2010-12-15 10:50:29 +00:00
Ralf Becker
92ebc10cef give current value higher priority then $value[default_sel] when determining $app 2010-11-12 08:17:30 +00:00
Ralf Becker
43d2411ba1 fixing some warnings 2010-11-10 08:26:41 +00:00
Ralf Becker
5cd2b962ea split merge taking a path as argument in second method merge_string taking the document as string 2010-10-27 09:34:42 +00:00
Ralf Becker
5efac64eff fixed wrong parameter type warning 2010-10-26 13:29:09 +00:00
Ralf Becker
af7a24eb9a framework->navbar() now automatically calls framework->header(), this way navbar or sidebox can include JS or CSS, because header is called after 2010-10-18 10:46:47 +00:00
Ralf Becker
0dd58b36cf quiten warning if $cell[size] is an array 2010-10-12 07:48:35 +00:00
Klaus Leithoff
e4ef70dd02 dont try to translate text from textfields when in listview 2010-10-04 11:50:37 +00:00
Nathan Gray
9f6c1c1994 Add a parameter to allow an extra 'Custom' country option when using 2 letter codes 2010-09-28 20:53:00 +00:00
Nathan Gray
272d30c3a7 Add parameter 'show_deleted' to include 'deleted' links waiting for purge 2010-09-27 16:29:50 +00:00
Ralf Becker
d29205529b removed use of PHP 5.3 deprecated eregi 2010-09-17 19:32:11 +00:00
Ralf Becker
201f0d33e3 also quote quotes in variables surounded by curly brackets, eg. '{[nm][path]}' 2010-09-14 16:33:33 +00:00
Ralf Becker
3c58ef8473 fixed historylog widget shows "unknow type" for selectboxes with explicit options containing key 0 2010-08-27 16:11:02 +00:00
Ralf Becker
ea97fc438f using utf-8 encoding for html merge-print 2010-08-23 12:03:03 +00:00
Ralf Becker
3835e9acbc reverted r31570/7: using label as blur text, as label is already used (as label), using blur text field now, no idea why I didnt used it in the first place ;-) 2010-08-16 07:28:58 +00:00
Ralf Becker
f156301f25 fixed wrongly display blur text for value "0" 2010-08-12 18:03:03 +00:00
Ralf Becker
5a03cff75d set span & class from original cell for single fields 2010-08-05 15:36:23 +00:00
Ralf Becker
bb468774f7 quitened warning 2010-08-01 12:47:26 +00:00
Ralf Becker
a1c9f68a1e remove not used advanced-search-widget 2010-08-01 10:02:04 +00:00
Ralf Becker
3dc949d08e display readonly link-entry widgets as links to the linked entry 2010-07-30 15:27:51 +00:00
Ralf Becker
4fc00c03ae forgot to translate the label 2010-07-30 14:02:19 +00:00
Ralf Becker
55463e493b displaying label of link-entry widget as blur text 2010-07-30 08:36:41 +00:00
Klaus Leithoff
72610fb3ad allow minus and underscore in validation as part of the LocalPart of the eMailaddress; even directly in front of the @ sign 2010-07-23 12:10:52 +00:00
Ralf Becker
b9bfd285a5 fixed not working checkboxes after r31472 2010-07-22 13:09:33 +00:00
Ralf Becker
f597385a9c fixed caching of etemplates:
- never read timestamp of last import from cache
- check timestamps only once per session and app
2010-07-21 13:50:29 +00:00
Ralf Becker
4da973400c allow and validate needed (required) attribute for file uploads, checkboxes and radio buttons 2010-07-21 08:21:42 +00:00
Ralf Becker
4ad95007b5 using call_user_func instead of depricated call_user_method, which seems at least under PHP5.3 not to allow static calls 2010-07-20 14:34:20 +00:00
Ralf Becker
b5f35a4b75 validating (string) === '' (instead === ''), as on ajax commit no yet set inputs are returned as null instead of '' 2010-07-13 20:47:25 +00:00
Nathan Gray
48ba641cb3 Avoid conflicts with other objects that have ->db defined by using the global db 2010-07-13 14:22:14 +00:00
Klaus Leithoff
b78a9865cc explicitly process fields to order by, as cutomfields may have names with spaces, so we examine each order by criteria, as our preg did not do the job properly 2010-07-08 11:37:56 +00:00
Klaus Leithoff
82e8bdbd9e allow for like wildcard.val.wildcard in filtersearch for customfields (needed for advanced search, as criteria are now remapped to be filters for customfields) 2010-07-07 14:11:33 +00:00
Klaus Leithoff
07930ecd58 fix advanced search for customfields (multiple field criteria, combined by AND) in addressbook 2010-07-07 11:38:52 +00:00
Ralf Becker
c1fa529fc8 new optional parameter "extra_args" for link widget, to add further get parameters to the link 2010-07-07 10:10:23 +00:00
Klaus Leithoff
c8abf9eacc fix a problem with content validation; was returned as array 2010-06-28 14:09:59 +00:00
Ralf Becker
30ce2262dd if search pattern alread contains a wildcard, do NOT add further ones automatic (eg. in extended search in addressbook) 2010-06-25 07:11:39 +00:00
Nathan Gray
97cdb61ea5 Fix for searching with custom fields in 2010-06-18 11:15:35 +00:00
Jörg Lehrke
a4b36620dd Fix excess of maximum column length issue 2010-06-18 09:33:57 +00:00
Ralf Becker
88ebb437c2 methods to set or get all body tags or javascript files, replacing direct access to variables of old javascript class 2010-06-15 16:08:10 +00:00
Ralf Becker
8c913bb95a correct validation errors, if no file selected or file could not be attached 2010-06-14 20:17:55 +00:00
Nathan Gray
e37b4807c2 Fix searching for a given custom field value using criteria parameter 2010-06-14 10:18:23 +00:00
Ralf Becker
58ce706d2c Use json_encode() instead of removed convert_phparray_jsarray() 2010-06-10 14:41:05 +00:00
Ralf Becker
8b49db5a57 new framework method to return javascript to call manual 2010-06-07 22:06:35 +00:00
Ralf Becker
f80f79a98a removing unnecessary diagnostics 2010-05-30 11:19:50 +00:00
Klaus Leithoff
3d99f3e9b3 if is not a string but 0, the comparsion == ->autoinc_id is true, which leads to an SQL Query error, if an extra column is used in sorting/filtering together with the lettersearch 2010-05-28 11:08:36 +00:00
Ralf Becker
579cf86bbc fix for bug #2624: SQL error - CONCAT not supported by postgres 2010-05-26 15:44:09 +00:00
Nathan Gray
2760915be4 Always understand english search operators 2010-05-25 19:04:40 +00:00
Ralf Becker
b43a3843d2 fixing bug #2609: Saving attached files to the filemanager doesn't work 2010-05-25 13:17:46 +00:00
Ralf Becker
04601a486e "understand run_lang for settings, to NOT return already translated phrases with replaced placeholders" 2010-05-21 07:21:30 +00:00
Ralf Becker
6799864392 fixed wrong language in notifications 2010-05-20 19:32:52 +00:00
Ralf Becker
a3a3fa1671 "new feature to explicitly set an id for widgets: prefix name with a hash --> id is the name without the hash, and NOT the form_name as before
Should not create any backward compatibilty issues - fingers crossed ;-)"
2010-05-20 09:06:53 +00:00
Ralf Becker
3a1412d8fe "fixed warning: explode expects 2. parameter to be string, array given" 2010-05-15 13:44:42 +00:00
Ralf Becker
71a7c20326 "fix for bug #2588 and #2592: links/popups in resources are not working
--> seems to be an aftermath of the new quoting
Thanks to Yudhi Kusnanto for a patch"
2010-05-12 19:17:01 +00:00
Ralf Becker
55f5a80a5e refining regular expressesion for PHP variables (replies[$row][reply_message] returned more then $row) and removed quoting from submitit call in button, as quotes in vars get quoted double 2010-05-12 07:50:13 +00:00
Ralf Becker
dbf8a15b55 "disable permanent error_log" 2010-05-11 18:12:55 +00:00
Ralf Becker
fd56fb27c3 Correct quoting of special chars in vfs:
- # has special meaning in url and is intern always urlencoded as %23
- ? has special meaning in url and is intern always urlencoded as %3F
- % need to be urlencoded as %25, as it's the escape char in urlencoding
  (it has not been stored urlencoded in sqlfs so far, there's some
   workaround in filemanger_ui to deal with the old unencoded % chars)
- space and + are NOT urlencoded in sqlfs in the DB, they get urlencoded
  only for download urls
- " get urlencoded for download urls only as it messes up the html
  markup
--> Filenames get urldecoded, before displayed to user
- done manually eg. in messages
- done automatically in new vfs-name widget (both ways)
2010-05-11 15:02:30 +00:00
Ralf Becker
2d0c33bb90 Some more quoting (and unquoting) of quotes in variable used eg. as
button names: eg. "delete[$row_cont[path]]" with path containing " or '
- they need to get quoted for correct html markup
- etemplate_request::set_to_process() need to use unquoted version, as
  this is how it get returned in $_POST
2010-05-11 14:52:45 +00:00
Ralf Becker
db23b1d746 - correctly quote single and double quotes in html element id's
- correctly quote quotes in parameters of javascript functions used
  eg. as eventhandlers, eg. onchange="do_something('$cont[name]');"
  --> if $cont[name] is an array: do_something([ 'val1', 'val2' ]) is used
- correctly quote & in get parameters of url's
2010-05-09 14:06:35 +00:00
Ralf Becker
4ecc2c0360 "allowing (at least) German umlauts in domain names" 2010-05-06 08:02:32 +00:00
Klaus Leithoff
ed040955bb prevent foreach warning, when & is not an array 2010-04-27 10:37:50 +00:00
Nathan Gray
f47cced6ed Fix for Postgres DB error loading eTemplate from Yudhi Kusnanto 2010-04-25 23:47:16 +00:00
Jörg Lehrke
334a8c6fc3 Fix addressbook_bo::find_contact() 2010-04-21 17:41:34 +00:00
Nathan Gray
6c3ba68ca1 If only_keys is true, expand it in so_sql_cf so the table_name can be prepended. Fixes last part of #2543, adding link when importing mail to infolog 2010-04-21 15:40:58 +00:00
Klaus Leithoff
69da1000b2 if only keys is passed to search return only the DISTINCT result-set (was not implemented when only_keys where passed as array) 2010-04-21 12:14:04 +00:00
Klaus Leithoff
7a4f191fb3 fix to provide (return) data even if a shortname is used as column name 2010-04-20 13:58:01 +00:00
Ralf Becker
423dbbc567 "an other fix: if there's already an explicit named column, just use that name" 2010-04-20 08:12:22 +00:00
Ralf Becker
765a1d5c09 "fixed not returned (explicitly given) columns: you need to use $table.'.'.$col.' AS '.$col, without AS column get NOT returned as name is different" 2010-04-20 07:39:23 +00:00
Klaus Leithoff
a9fd21325d fixing a bug, when trying to sanitize possible ambiguous columns 2010-04-16 10:35:09 +00:00
Nathan Gray
2aed9e476f Fix copy/paste error to get address merging working 2010-04-15 14:56:37 +00:00
Klaus Leithoff
1ec94a70fe set cat_app with value from get_row (, if not set) to ensure the cats of the template/listview in question are to be loaded 2010-04-12 07:23:21 +00:00
Nathan Gray
549626cbf9 Add some extra handling for potentially ambiguous columns in 2010-04-08 22:13:22 +00:00
Nathan Gray
215da11fae Add some extra handling for ambiguous columns 2010-04-08 20:21:40 +00:00
Nathan Gray
79dfab8005 Custom field widget can be limited to (or exclude) certain fields. Put the list of fieldnames to display as the 3rd (4th, etc) option. Using a ! as the first character will negate the list, and exclude the named fields. 2010-04-07 17:00:09 +00:00
Nathan Gray
97727d41ce Fix filtering on a multi-select custom field. Any entry with the filter value will be included. 2010-04-07 16:06:01 +00:00
Ralf Becker
f2e9a38ff4 "fixed ambiguous column sql-error by adding table-name to id over which we join" 2010-04-04 09:08:25 +00:00
Ralf Becker
a45ea03b19 "fixed ambiguous column sql-error by adding table-name to id over which we join" 2010-04-04 08:59:37 +00:00
Nathan Gray
5e23cfb764 Working on searching...
- Check default column names to avoid DB errors
- Prefix default column names with table name to avoid ambiguity
- Handle single words in quotes
2010-04-01 20:48:16 +00:00
Nathan Gray
93cf9c2e84 Don't need to pass ->extra_value, search2criteria() will take care of it 2010-04-01 20:20:08 +00:00
Nathan Gray
4b134dfc9e Extra column check needs to be escaped 2010-04-01 20:19:28 +00:00
Nathan Gray
fa6c1d4a9c Need to set numeric types to check 2010-04-01 20:07:01 +00:00
Nathan Gray
d22773d04d Add extra search functionality to custom fields. 2010-04-01 19:59:50 +00:00
Nathan Gray
3d8fca332b More sensible handling of numeric columns:
- If app doesn't specify columns to search, all columns except numerics with '_id', 'modified', 'modifier', 'status', 'cat_id', 'owner' will be considered
- Numeric columns will be searched only if the search string contains a numeric token.  'maintenance 50' is ok to search for, but for numeric columns only 50 will be searched.  
- Numeric columns are searched using equality, unless user puts in a wildcard.  Searching for 50 will only match 50, not 150 or 1950/04/10, but *50 will match 150.
- Text columns are searched using LIKE, including numeric search terms, as before.
2010-04-01 17:03:51 +00:00
Nathan Gray
cc0f8f3c28 An attempt to add more functionality to searching
- All words are trimmed
- Double quotes require the exact phrase ("Nathan Gray" will not match Nathan Brown or Gray Power)
- Modifiers + and - before a word will require or exclude the word (+test -fail), otherwise word is ORed
- User language modifiers AND, OR and NOT (uppercase) will be parsed.
- Combinations: tracker entry -testing -"fatal error"
Note that "entry" will not match "entries", and the results are not sorted by match strength.

All applications that use so_sql for searching should gain these benefits.
2010-03-31 21:29:11 +00:00
Ralf Becker
a858db5eb8 "for iPhone and Android: replace evtl. configured telephony integration link with tel: protocoll" 2010-03-28 13:33:40 +00:00
Ralf Becker
c60a1ad94d "for iPhone and Android: replace evtl. configured telephony integration link with tel: protocoll" 2010-03-28 13:27:30 +00:00
Ralf Becker
99a9132cd5 "fixed not working activation of tab with different prefix" 2010-03-23 19:34:40 +00:00
Ralf Becker
71960a6d02 Fixed some more php53 Warnings after latest fix_depricated.php
improvment.
2010-03-21 09:37:52 +00:00
Ralf Becker
4cc9586e39 xajax uses xml to transport the label, therefore we have to replace not only CR, LF (not allowed unencoded in Javascript strings) but also all utf-8 C0 and C1 plus CR and LF 2010-03-19 13:05:20 +00:00
Ralf Becker
6c7e9b0062 fixed regular expression to NOT "eat" 8 and , from merge print replacements 2010-03-16 13:38:20 +00:00
Klaus Leithoff
d9c39caf7e removing possible CR/LF from content for ajax search result javascript, as it breaks the options 2010-03-15 17:17:33 +00:00
Ralf Becker
bb580029c1 "fixed handling of linebreaks from text and rich text fields for xml based formats (Open Office and MS Office)" 2010-03-08 21:56:05 +00:00
Ralf Becker
3f8da06a9e "replace all control chars (C0+C1) but CR, LF and TAB (eg. vertical tabulators) with space as they are not allowed in xml" 2010-03-08 11:34:22 +00:00
Ralf Becker
83b60b81fc Fixed r29141: "Add a checkbox to allow user to prevent notification of
changes to a ticket", to NOT prevent history logging, if checked
2010-03-07 14:45:12 +00:00
Ralf Becker
3eb38935bb caching etemplates using egw_cache class on instance level (instead off old not egw_cached based code on request level), to ease the load on the db 2010-03-05 08:18:46 +00:00
Ralf Becker
0f2eceefb8 Preseed link title-cache for link-list and link-string widget
(Performance improvment, as all titles of an application get queried in
a single query and NOT once for every link)
2010-03-04 17:07:10 +00:00
Nathan Gray
4424d49c30 Handle case when ID is missing, happens the time after clearing the cf search 2010-02-22 22:46:17 +00:00
Nathan Gray
48886af55c Blur text can affect regular searches, not just array searches 2010-02-22 20:56:59 +00:00