holm/egroupware
1
1
Fork 0
forked from extern/egroupware
Code Issues Pull Requests Packages Projects Releases Wiki Activity
39,508 Commits 27 Branches 330 Tags 157 MiB
570edaa1e0
Commit Graph

299 Commits

Author SHA1 Message Date
nathan
7ba5730251 Change properties to camelCase 2022-12-05 09:42:55 -07:00
nathan
6eebabe472 SearchMixin: Fix tag edit 
Double clicking just cleared the input, edit was immediately stopped due to search blur
 2022-12-01 14:54:34 -07:00
nathan
404a29b985 SearchMixin: If user enters a valid free entry then changes focus without pressing Tab or Enter key, accept the free entry 2022-12-01 14:15:40 -07:00
nathan
6d41c9c30b Et2SelectAccount: Avoid error if option does not have an image 2022-11-21 09:16:38 -07:00
nathan
1d540aa74c Fix additional options to a static list were not properly added if they were in correct format with value & label 2022-11-21 09:14:27 -07:00
nathan
6a5d189489 Better fix for Et2SelectState not getting country set 2022-11-14 14:41:08 -07:00
nathan
47a48b386f Et2Select: Fix change event got fired too early 
Don't need to block the event if we didn't actually change the value.  This fixes changing to common preferences
 2022-11-09 15:34:28 -07:00
nathan
32bd2a1084 SearchMixin: Make sure dropdown doesn't cover bottom border 2022-11-09 09:30:53 -07:00
nathan
4dffd24feb Et2Select: Fix change event got fired too early 
Second attempt.  If fix_bad_value() made a change, that was triggering change event before Et2App.et2_ready() had been called.  Now making sure that event does not get fired.
 2022-11-08 11:04:03 -07:00
nathan
78333613fa Et2Select: Fix change event got fired too early 
If fix_bad_value() made a change, that was triggering change event before Et2App.et2_ready() had been called
 2022-11-07 09:57:00 -07:00
nathan
74f7f4dcb5 Et2SelectReadonly: Allow additional supplied options, but fix bug where they overwrote account options 2022-11-02 14:03:12 -06:00
nathan
48eb9c1968 Fix duplicate option warning from customfield select filter 2022-10-18 16:06:28 -06:00
nathan
bd62279f55 Et2Select: Cancel search timer on blur and menu close 
If we don't, results might come back after we leave/close and re-open
 2022-10-17 09:56:58 -06:00
nathan
0004aa5bb4 SearchMixin: Avoid errors if searchInputNode is not created 2022-10-14 15:12:08 -06:00
nathan
69ce014aa6 Et2Select: Vertically center multiple tags 2022-10-13 09:33:04 -06:00
nathan
08e899e91c Fix Et2SelectCategory had category border when multiple 
Now only shows category border for single select, when there's a value
 2022-10-13 08:41:42 -06:00
nathan
690e89157e Et2Listbox: Make rows set the height, not the max 2022-10-07 15:33:43 -06:00
nathan
8514792efc Fix changing select options did not properly clear previous options 2022-10-07 15:31:06 -06:00
ralf
c5b8261ec2 do NOT split RFC822 addresses containing comma in quoted name part eg. 'Becker, Ralf <rb@egroupware.org>' 2022-10-06 13:14:34 +02:00
nathan
3ce5aebe12 Collabora: Get insert placeholder dialog working again 2022-10-05 10:50:54 -06:00
nathan
f8e56edc20 Limit number of accounts (& other select/taglist search results) sent to client 2022-10-04 15:49:07 -06:00
nathan
7bb4332961 Et2SelectCategory: Fix loading with initial value did not get category color or icon in the displayed label 2022-10-04 09:17:31 -06:00
nathan
b5a2778168 Fix category did not display value on first load 2022-10-03 09:12:00 -06:00
nathan
12f8b2cb3e Et2SelectEmail: Add some documentation 2022-09-28 11:14:02 -06:00
nathan
ffd6c21ed4 Et2Select: Avoid errors if freeEntry has single quote 2022-09-27 13:55:32 -06:00
nathan
086d92e957 Et2Select: All selectboxes now stop scroll event from bubbling to prevent parent (sidemenu) from scrolling too 2022-09-23 10:54:02 -06:00
nathan
171c9c02cb Pressing escape while in search now closes dropdown 2022-09-23 10:40:16 -06:00
nathan
bea34ad403 Fix adding a freeEntry did not trigger change event 2022-09-22 15:18:34 -06:00
nathan
5a8f7c3c70 More fixing of missing search options / tags 
Fixes new free entries don't show up after removing a free entry
 2022-09-22 11:15:25 -06:00
nathan
8da8c14a00 Et2SelectEmail: Change multiple default to false to match other selects 2022-09-22 08:59:31 -06:00
nathan
2952df2799 Et2Select + SearchMixin: Fix some bugs with display and selecting entries 
- Fix clicking on text while editing triggered re-display
- Avoid unneeded node re-creation when editing free entry, handle empty value as removal
multiple=true:
- Fix clearing search removed previously selected remote results
- Fix adding a free entry did not move search down, covering the new value
multiple=false:
- Fix search & edit inputs were shown at the same time
- Fix edit free entry always took over making it impossible to search
 2022-09-21 17:13:29 -06:00
nathan
7dd0165cd2 Et2Select + search: Fix position adjustment did not work in all cases 
Subsequent searches did not give space for searchbox
 2022-09-20 10:07:36 -06:00
nathan
66368c6d3a Et2Select + search: Adjust dropdown position based on if it opens up or down 2022-09-20 09:43:25 -06:00
nathan
606e2688d4 Et2SelectEmail: Do not create image in tag, Et2EmailTag uses CSS for image 
Fixes doubled image
 2022-09-19 09:23:23 -06:00
nathan
1deeee207f Better way to show "no suggestions" indicator, works with local options now too 2022-09-16 11:17:06 -06:00
nathan
30c3000e87 Et2Select fixes 
- Search with no results blocked any futher searches from displaying results
- Only show "no suggestions" after searching
 2022-09-16 10:20:47 -06:00
nathan
9a036b1dfe Et2Select: Fix "required" styling did not show in a better way 
Previous method (38e8df2) made widget entirely transparent
 2022-09-15 15:26:06 -06:00
nathan
38e8df223d Et2Select: Fix "required" styling did not show 2022-09-15 12:36:31 -06:00
nathan
c8b6a5760b Et2Select: Re-add accidentally removed chunk that sets initial value when initial value is an array 
Fixes mail preview didn't show to/from addresses
 2022-09-15 08:49:36 -06:00
nathan
1b72eb4a00 Revert "Revert "Et2Search: Fix some UI bugs" as it no longer renders values and therefore easily destroys existing content" 
This reverts commit 0287e06df2.
 2022-09-15 08:30:50 -06:00
ralf
0287e06df2 Revert "Et2Search: Fix some UI bugs" as it no longer renders values and therefore easily destroys existing content 
This reverts commit 56eb4d64ac.
 2022-09-15 12:56:12 +02:00
nathan
56eb4d64ac Et2Search: Fix some UI bugs 
- Fix missing loading spinner while searching
Clear button was in the way, now hiding clear button when displaying the spinner

- Fix searching for the same thing twice displays no results the second time
repeat() and map() directives were not putting the DOM nodes back in, worked around by using a temp div to render into.  There were some lifecycle mistakes as well leading to collisions & re-doing.
 2022-09-14 15:47:36 -06:00
nathan
9096c17348 Et2Select: Tabbing out of search field now closes the dropdown 2022-09-13 09:06:59 -06:00
ralf
d8d8429622 an other fix for 4c00b812ee fixing error when trying to reply 2022-09-13 10:17:59 +02:00
ralf
c00c6f9e07 readonly et2-select-mail caused error with 4c00b812ee eg. in mail.display 2022-09-13 09:15:55 +02:00
nathan
4c00b812ee Fix edit inputbox covered new freeEntries 2022-09-12 12:48:21 -06:00
nathan
43cce1940d Fix selecting search result does not display label 
Infolog contact filter still filtered, but did not show label for selected search result.
 2022-09-12 10:19:38 -06:00
Hadi Nategh
1489944d49 Fix category border styling 2022-09-12 15:16:04 +02:00
ralf
26824323e5 got mailing lists working again in mail compose using includeLists=true attribute 
using "$list_name <$list_id@lists.egroupware.org>" instead of just integer ids for the list, thought et2-select-mail is NOT displaying the mailing-list icon, after a mailing-list is selected
 2022-09-12 14:51:13 +02:00
nathan
f85de279c6 Fix some property bugs 
- Parse values that should have been objects but came as strings
- Decode SearchMixin.searchUrl
 2022-09-08 11:17:34 -06:00
nathan
a10938ab2b Fix select account readonly did not properly show names with CSV 2022-09-07 15:12:06 -06:00
nathan
151df0f76b Et2Select + search fixes 
- Fix multiple=false had gap between widget and dropdown
- Add clearSearch() to clear the (remote) search results
 2022-09-07 08:40:46 -06:00
nathan
6b4a16357f Et2LinkAppSelect: Fix displayed icon did not change when value changed 2022-09-06 11:11:13 -06:00
ralf
1ec9ef63fe fix Uncaught TypeError: Failed to execute 'getComputedStyle' 
thought the image no longer changes, when selecting another one :(
 2022-09-05 13:59:07 +02:00
nathan
daf63d9c23 Et2Select: If multiple and no value, overlap the search onto the widget 2022-09-01 11:53:19 -06:00
nathan
24daafb9ef Et2Select: If somebody set '' as an option value then '' is not a bad value and doesn't need to be fixed. 2022-09-01 09:58:08 -06:00
nathan
1bbcdbfeb7 Fix Et2SelectAccount couldn't have non-account options, so freeEntries didn't show up 2022-09-01 08:30:43 -06:00
nathan
2e319319d1 Fix general free entries did not validate with 0 validators 2022-09-01 08:29:46 -06:00
nathan
a3d2674757 Et2Select + search: Fix some bugs 
- Select a searched value didn't validate due to different attribute name
- et2-searchbox inside et2-select threw an additional change event, needed to catch that
- fix_bad_value() needs different handling when you can search, otherwise it just gets cleared again
 2022-08-31 13:28:20 -06:00
nathan
6458511d75 Et2Select: Fix some missing "emptyLabel" bugs 
- If there were no select_options, and an invalid value, empty label was not shown (Infolog pricelist)
- Select Number had numeric values for options which did not match string values (Infolog completed)
 2022-08-30 14:27:19 -06:00
Hadi Nategh
31e83ddf05 Stop tags being drawn to the max width 2022-08-29 16:47:58 +02:00
nathan
234b2c78b9 Et2SelectCountry: Fix limited size of search box 
There was a conflict between flag style & search styles.  Now using a specific element for the current value flag instead of styling the whole slot.
 2022-08-26 11:48:02 -06:00
nathan
b136958425 Et2Select: (multiple=false) When searching and user selects a value, abort search and show all non-matching entries again 2022-08-25 15:51:15 -06:00
nathan
19d4b9a8b6 Make nm filters always the same size (33% each) and show ellipsis when the current value is too long 2022-08-23 11:07:02 -06:00
nathan
6e30a68121 Get automatic search when more than 20 select_options working for all cases 
StaticOptions, change after init previously didn't work
 2022-08-19 11:07:16 -06:00
nathan
d5d9dd6164 Select + search improvements 
- Use et2-search widget with clearable for search
- Add focus(), which opens & focuses search
 2022-08-16 16:46:20 -06:00
nathan
6095b0e2ae Fix Et2LinkSearch did not always get correct option when it was loaded with a value 
SearchMixin was incorrectly allowing it as a free entry, so it wasn't being properly loaded by Et2LinkSearch
 2022-08-15 10:38:19 -06:00
nathan
ddee9a2b59 Et2Select: Move option rendering into its own function, call it for Et2SelectAccount. This fixes missing option/label in some cases 
eg: Kanban edit column Add/Remove assigned
 2022-08-15 10:31:49 -06:00
Hadi Nategh
a456f509f5 Let the tags styling matches the rest of the framework 2022-08-12 12:46:48 +02:00
ralf
429886139b change default remoteQuery to send query and options as parameters and additional as GET parameters 
to support old taglist style callbacks and the select callbacks
 2022-08-11 11:24:07 +02:00
ralf
75a263a047 automatic enable search for more than 20 options on Birgits request 2022-08-10 13:29:15 +02:00
ralf
a54c100470 fix email selection after changing selects client- and server-side to no longer send id attribute, but value 
thought we still accept id, if there is no value
 2022-08-10 13:28:48 +02:00
ralf
9ddfba4a24 fix no category was selected (because of numeric value) and color was not shown 2022-08-09 17:24:28 +02:00
ralf
ea0cbd0441 account selection currently only need to use server-side search, for pref "Primary group and search" 
for all other types the local search is sufficient, as everything is already local!
fix Taglist::ajax_search for accounts to pass the icon to client-side and always set value instead of id
 2022-08-09 10:47:57 +02:00
ralf
e7eb9f42e3 fix many errors around et2-select emulating old taglist: 
- preprocessor: translate attributes autocomplete_url -> searchUrl, autocomplete_params -> searchOptions, and allow options
- sending search query as URL/GET parameter with default of app: <appname>
- handle searchUrl like allowFreeEntries by adding selected result to select_options via createFreeEntries, as they otherwise get removed by fix_bad_value not finding the value in select_options
- change taglist validation (again) to not validate search values
- still requires changes in application code, as taglist always behaved like multiple=true (returning and expecting an array of values) and did automatically search from client-side for it's initial value(s)
--> maybe more changes are in order to NOT require changing application code
--> fixes editing Sieve rules
 2022-08-08 17:28:51 +02:00
ralf
79a395e3e6 fix missing scrollbar in longer then visible dropdown 2022-08-08 14:44:37 +02:00
nathan
e8a93ab782 Handle initial value sometimes not set after Shoelace version bump 2022-08-05 11:32:59 -06:00
nathan
36d74dd91f Select search term after selecting a search result 2022-08-05 11:10:50 -06:00
nathan
045f322bf6 Et2Select changes: 
- Position search & edit inputs to avoid reflow
- When editing a freeEntry, blurring accepts the current value, before it canceled the edit
 2022-08-04 15:50:52 -06:00
nathan
098c2ab3f0 Fix some issues from the shoelace version bump 
- SlSelect.getItemLabel() not there anymore
- SlSelect.menuItems is now a real list, and fails when parent tries to write to it
- Tabs didn't hide properly when not active, giving a scrollbar
 2022-08-04 13:47:16 -06:00
nathan
aabda23bbd Et2Select: Turn on hoist, we want it on more than off 
In particular, ACL dialog, but there's a bunch of other places too.
 2022-08-03 16:28:18 -06:00
nathan
f7cf372f09 Et2Select: Better handling for when select_options & value get set one after the other 
This caused selectbox to look empty, even though it had a value since the new menu-items hadn't been created when value was set
 2022-08-03 16:04:08 -06:00
ralf
3a92e104da fix TypeError for account-selection type "primary_group" 2022-07-29 09:24:57 +02:00
ralf
dbdb124c1c fix not displayed selected account, caused by egw.accounts() returning value as number, not string 2022-07-27 11:46:45 +02:00
nathan
de73241166 Fix historylog multi-part entries did not actually show values 
Also deals with some issues setting and missing cleaning of select_options
 2022-07-26 11:41:07 -06:00
ralf
9f15169ced convert hierarchical options / optgroups to a flat list and enable search for more than 100 options automatic 
fixes timezone selection in preferences
 2022-07-26 18:57:18 +02:00
nathan
df0b4f3afb Fix free entries didn't get added properly for static option selects 2022-07-26 09:15:05 -06:00
nathan
c45661bbe4 Et2Select: No horizontal scrollbar on options 2022-07-26 09:12:52 -06:00
ralf
dee28cb53f noLang only affects options, label, statustext, placeholder, emptyLabel get always translated 2022-07-26 15:46:42 +02:00
ralf
aa80b4027a fix not translated tooltip, select options and emptyLabel 2022-07-26 15:06:07 +02:00
nathan
3cb8b1ecce Get select hover border back 2022-07-22 10:44:37 -06:00
nathan
379ceeb3e5 Switch Et2Template to extend SlInput instead of LionInput 
Also includes changes to how validation messages are handled to use our own stuff
 2022-07-21 12:39:00 -06:00
ralf
b9d96ea3e9 change all attribute-names of new et2-* widgets to camelCase 
only exception is select_options, never used in templates
 2022-07-21 17:57:50 +02:00
ralf
d26ed9bfce fix not displayed r/o et2-select-cat values 2022-07-21 11:50:05 +02:00
nathan
f72b842031 Let search take full size - empty label margin was taking some 2022-07-20 15:03:15 -06:00
nathan
3b147eaa49 Make sure options are clean before trying to merge them. Fixers broken historylog. 
Also filter out duplicate options.
 2022-07-19 14:20:39 -06:00
nathan
2bcebeed42 Add Et2SelectEmail.full_email property. Set to true when you need to see the full, original value 2022-07-19 13:18:51 -06:00
nathan
1a2e691cbb Fix some bugs with static options being repeated 
- Select Tab options being sent from server & cached
- Static options not properly set for all selects
 2022-07-19 11:47:03 -06:00
nathan
5ee60c0af1 Fix option merge unique filter left out some options 2022-07-19 10:31:45 -06:00
ralf
6ab34234f5 fix error changing app in preferences 2022-07-19 18:10:12 +02:00