holm/egroupware
1
1
Fork 0
forked from extern/egroupware
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,742 Commits 27 Branches 330 Tags 157 MiB
6aa0366330
Commit Graph

1785 Commits

Author SHA1 Message Date
nathangray
16278dd064 Fix PHP warnings for PHP 8 compatability 2021-07-22 11:36:24 +02:00
Ralf Becker
45d77b594d keep original REQUEST_URI in ORIG_REQUEST_URI when modifying it 2021-07-22 11:29:11 +02:00
Ralf Becker
10c24c1830 * Filemanager/VFS: when creating a new file as root eg. via (docker exec) filemanager/cli.php do NOT create files unreadable by webserver 2021-07-22 11:26:42 +02:00
Ralf Becker
fdaac697e2 got symlinks working for filesystem streamwrapper and fix one bug in Vfs with symlinks 2021-07-22 11:25:15 +02:00
nathan
f7aef98666 Implement symlink for filesystem StreamWrapper with test 
Whether it works or not depends on filesystem though.
 2021-07-22 11:25:15 +02:00
nathan
ac41289ecd Fix wrong permission constant used, resulting in permissions when there shouldn't be 2021-07-22 11:19:00 +02:00
Ralf Becker
8a411e7f46 need to call Vfs\StreamWrapper::init_static() after setting Vfs::$user 
Vfs::$user should be protected and moved to Vfs\Base plus a getter and setter method added for public access,
as after setting it in 21.1+, Api\Vfs\StreamWrapper::init_static() need to be called to set the default user context!
 2021-07-22 09:13:46 +02:00
nathan
7a5804c2e7 Fix symlink directory problem from 2a64e79 and add a unit test to avoid that in the future 2021-07-21 11:29:38 -06:00
nathangray
4606a29408 Api: Fix bug where StreamWrappers that mapped onto other StreamWrappers would be parsed earlier than we want, leading to the first StreamWrapper not getting used. 2021-07-21 11:29:26 -06:00
nathan
e75bef4415 Missed part of b021767ac1, not sure why it didn't come 2021-07-12 16:38:18 -06:00
nathangray
7f63e612dd Make sure nested document actions open in new tab, same as others. 2021-07-12 16:37:20 -06:00
nathangray
a728276a15 Change merge download/Collabora to a common generation method, avoiding need to POST. 
This allows Kanban to download merge files
 2021-07-12 16:30:01 -06:00
Hadi Nategh
32edce1626 Try to take only quoted_printable to decode and avoid decoding url params as quoted 2021-07-01 17:14:13 +02:00
nathangray
12591f3911 Api: Fix Asyncservice did not have proper filesystem access as the job user 2021-06-24 08:20:26 -06:00
Hadi Nategh
001d5168ee Fix 404 errors caused by none existing html editor icons 2021-06-15 12:12:11 +02:00
Ralf Becker
4ef9b08457 fix class Api\Mail\Config not found 2021-06-15 10:53:31 +02:00
Ralf Becker
5c7925773b * Mail/Dovecot: allow to disable caching of flags in site config to support Dovecot private seen flags on shared folders 2021-06-15 10:24:55 +02:00
nathangray
00e5c1e521 * Api: Prevent invalid customfield names 2021-06-11 10:05:44 -06:00
nathangray
96fd9153d3 Etemplate: Better error message for parse errors in xml strings (not files) 
This happens in things like Transformer, where we generate some XML for parsing
 2021-06-10 11:36:05 -06:00
nathangray
1334d963d9 * Api: Clear initial load URL after using it, so F5 takes you to the app's normal entry point 2021-06-10 09:08:39 -06:00
Hadi Nategh
134aa92712 Clear xml errors in buffer after using xml in Mail otherwise it may get caught wrongly further in etemplate widget 2021-06-04 14:05:29 +02:00
Ralf Becker
8bb4f56149 implement (increment|decrement)Cache to avoid race-conditions if multiple processes update a value 
implemented in memcached and APCu backends, default implementation using get&set in base-class
 2021-05-31 20:32:10 +02:00
Ralf Becker
cda95d8188 store some lock-data, so only a single callback calculate data on cache-miss 
done to avoid race-conditions where many processes try to fetch and therefore calculate some expensive to calculate data
eg. mass-mailings in our hosting
 2021-05-27 08:52:58 +02:00
Ralf Becker
691fb06de5 * Setup: skip files backup on update even if configured 
It might takes the server down for hours and updates usually dont affect the files
 2021-05-27 08:50:02 +02:00
Ralf Becker
d733cb48e9 report and log enabling push (and other IMAP errors) 
don't switch regular reload handling off in that case
 2021-05-25 18:26:13 +02:00
Ralf Becker
a117e4cf6a port csv-export from old eTemplate nextmatch to separate Api\Etemplate\Export class to not have to rely on old eTemplate 2021-05-23 09:20:36 +02:00
nathangray
35bc2ffe70 Api: Fix accounts list (Sql) would be empty after refresh if there were less than 50 accounts 
- Fix some accounts backend were not returning results indexed by account ID
 2021-05-21 09:18:09 -06:00
Hadi Nategh
e919523a51 Merge login Ui changes 2021-05-21 16:46:54 +02:00
Hadi Nategh
3037191ea8 WIP login Ui: 
- Re-arrange registration links
- Fix bg colors
- Fix social icons padding
 2021-05-21 16:17:49 +02:00
Hadi Nategh
33951a6377 WIP login Ui: 
- Get login messages the same style as egw messages
- Arrange logo and social icons
 2021-05-21 16:17:00 +02:00
Hadi Nategh
a2d182c11a Add extra icons for login apps content 2021-05-21 16:10:56 +02:00
Ralf Becker
f2d349cf2c fix PHP Warning on login page 2021-05-21 09:52:41 +02:00
nathangray
4b9ec7ec13 Api: Respect do_symlink flag to keep links as links 
Fixes troubles with syncing
 2021-05-20 13:00:55 -06:00
Ralf Becker
50fcb69225 fix some real typos 2021-05-19 19:30:21 +02:00
Ralf Becker
65405790e3 * AD: fix account-selection type "groupmembers" caused high load on AD 
also caching groups now on instance level instead of session
 2021-05-19 19:30:21 +02:00
nathangray
ded8cdecf9 Fix symlinks were opened read-only in Collabora 2021-05-19 08:37:51 -06:00
Ralf Becker
e14d2ef332 * ADS/LDAP: improve caching of searching/listing 2021-05-16 20:44:04 +02:00
Ralf Becker
1e2c7de6f7 allow to pass JSON serialized date-array with date&timezone to constructor 2021-05-15 15:57:37 +02:00
Ralf Becker
46e97f8975 fix typo causing number of failed attempts on IP whitelist not to be used 2021-05-11 11:21:21 +02:00
Ralf Becker
a218faf73e * AD/Login: fix login always reports "account is expired", if account-selection "group-members" is set for AD 2021-05-05 15:46:11 +02:00
Hadi Nategh
82ab8d9092 WIP login Ui: add motion into apps list 2021-05-03 17:13:04 +02:00
Hadi Nategh
635ca0a89d WIP login ui: 
- Move login.json file into pixelegg
- Include icons into json file
 2021-05-03 13:21:01 +02:00
Hadi Nategh
1d843eabcd WIP login Ui: 
- Arrange apps in the json file and add more details
- Open app's url in a new window
 2021-05-03 12:03:28 +02:00
nathangray
84e03fe334 Addressbook: Fix contact categories were cleared when DAVx5 synced some Android clients 2021-04-30 09:26:00 -06:00
Hadi Nategh
41ab849ecc WIP login Ui 
- Implements apps tooltip
 2021-04-30 14:58:41 +02:00
Hadi Nategh
faadfbdc23 Fix loading login json file 2021-04-29 18:22:38 +02:00
Hadi Nategh
39eef44217 WIP login page Ui 2021-04-29 15:24:25 +02:00
Hadi Nategh
59dbd27719 Fix mail integration fails for mails with having not encoded ampersands on their html content 2021-04-27 17:41:34 +02:00
Hadi Nategh
a49ac9648e Implement throbber for mobile framework 2021-04-22 16:00:52 +02:00
Ralf Becker
df5cce7a74 * SAML/Shibboleth: fix metadata-URL to container eduPersonUniqueId or a custom OID, if specified 2021-04-20 17:34:20 +02:00
Ralf Becker
8df0ba3d70 fixes required for EPL firewall 2021-04-20 15:51:36 +02:00
nathangray
f89c8cfb03 Add hrules to sidebox menus 2021-04-19 16:02:41 -06:00
nathangray
df8251603f Add missing parameter type 2021-04-19 16:01:17 -06:00
nathangray
35fd51da86 Add table name in when parsing search 
Also, some code quality fixes
 2021-04-19 14:34:53 -06:00
nathangray
51f9177634 Try harder for nextmatch template name so it can be passed to hooks. If it can't be found in value, look in original attributes. 2021-04-19 10:42:48 -06:00
Hadi Nategh
fb83d97150 Implement loading aware framework animation 2021-04-19 10:17:47 +02:00
Ralf Becker
fb30713cbb fix not working load_via parameter 2021-04-18 21:07:38 +02:00
Ralf Becker
d144d65fe9 fix double encoding of backlash in class-names 2021-04-17 09:45:44 +02:00
nathangray
4f0c7250da Fix error when linking to new entry 
"Invalid datetime format: 1366 Incorrect integer value: '#97056a438e3c1ab04fd0f0ae46ad6b13' for column ... fs_dir"
 2021-04-15 10:25:18 -06:00
nathangray
d9b29fa82a Fix shares could not find files after fe79fe390f 2021-04-14 10:58:42 -06:00
Hadi Nategh
4af0bec278 * Mail: fix losing inline images after being re-saved as draft or created as new 2021-04-13 13:23:09 +02:00
nathangray
fe79fe390f Avoid caching when the url contains links, avoids problems with eg: /apps/InfoLog/Open/2021 2021-04-12 10:31:35 -06:00
Hadi Nategh
e88c4edea2 Fix php 8 errors 2021-04-08 18:36:46 +02:00
Hadi Nategh
b5540c7288 Fix mail content styles 2021-04-08 11:31:36 +02:00
Ralf Becker
8daf1f43f7 fix PHP error: Call to a member function contentTypeMap() on null 2021-04-08 10:19:15 +02:00
Ralf Becker
dfdb300f5f fix PHP 8 error: array_merge() does not accept unknown named parameters 2021-04-07 21:41:11 +02:00
Ralf Becker
e03b1aeb16 fix PHP 8 error: key() Argument #1 must be of type array, null given 2021-04-07 13:12:32 +02:00
Ralf Becker
673760f59d * Setup/SAML: fix not stored custome OID and added eduPersonUniqueId 2021-04-07 10:07:56 +02:00
Ralf Becker
4045c06896 fix PHP 8 errors 2021-04-06 15:32:21 +02:00
Ralf Becker
c92bfa822f fix PHP 8 Fatal error caused by not parsable URL like "<scheme>://<user>@/path" (missing domain) 2021-04-06 09:19:54 +02:00
nathangray
060710a74a Make sure we can log all throwables, not just exceptions 2021-04-05 10:46:50 -06:00
Ralf Becker
7ae4d44308 fix PHP 8 errors 2021-04-02 19:34:11 +02:00
Ralf Becker
7135243d06 nicer implementation of CreateObject and some small fixes 2021-04-02 10:47:52 +02:00
nathangray
4ab170541e Api: Fix incorrect extended ACL check was done when symlinking 2021-04-01 10:28:06 -06:00
Ralf Becker
fed41622c2 fixing all sorts of PHP 8 errors and PHPStorm errors 2021-03-31 17:50:01 +02:00
Ralf Becker
0efa9ae141 docu update 2021-03-31 17:50:01 +02:00
Ralf Becker
37e5e12c3c PHP 8 fix: adding explicit cast for comparing DB-version to a float major number 2021-03-31 13:31:42 +02:00
Ralf Becker
79040d1524 disable warnings under PHP 8 for now, as the hide fatal errors and log errors in xet files 2021-03-31 11:30:34 +02:00
nathangray
72b00c0422 Fix missing translation 2021-03-30 11:04:19 -06:00
nathangray
d5aacd190d Add 'no_quick_add' link registry setting so apps can opt out of the quick add 2021-03-30 10:12:29 -06:00
Ralf Becker
8f1383b973 replace create_function no longer available in PHP 8 2021-03-29 20:33:07 +02:00
Ralf Becker
868135775c PHP 8 fixes 2021-03-29 16:47:19 +02:00
Ralf Becker
05cd66fa09 set minimum PHP version for 21.1 to 7.3 and recommend to 7.4 (PHP 8.0 is still NOT supported) 2021-03-24 08:04:54 +01:00
nathangray
e3a1d1b338 Fix static var accessed as a constant 2021-03-23 16:23:23 -06:00
Ralf Becker
0faafe8eee fix "Virtual List View error" caused by not set search attribute 
also retry without VLV control in that case
 2021-03-23 13:55:17 +01:00
Ralf Becker
84845d05b5 Fix PHP 8.0 Fatal error: Unparenthesized a ? b : c ?: d is not supported 2021-03-21 21:46:10 +01:00
Ralf Becker
ab9c089f70 fix PHP 8 Fatal error Array and string offset access syntax with curly braces is no longer supported 2021-03-21 21:13:07 +01:00
Ralf Becker
52e8aff9ae fix PHP 8 Fatal error undefined constant EGW_API_INC 2021-03-21 21:10:37 +01:00
Ralf Becker
3e278b3bd3 fix PHP 8.0 Fatal error: Array and string offset access syntax with curly braces is no longer supported 2021-03-21 18:47:15 +01:00
Ralf Becker
ffc048d472 fix PHP 8.0 Fatal error unknown function get_magic_quotes_gpc 2021-03-21 18:27:09 +01:00
Ralf Becker
dac55616af fix PHP 8.0 Fatal error 2021-03-21 18:25:14 +01:00
Ralf Becker
eb2b3943d7 fix Db errors with PHP 7.4+ 
caused by private $this->app not stored in session when Db\Depricated was instaciated
also move $GLOBALS[egw]->ADOdb to a static class var to fix session restore order caused $GLOBALS[egw] not yet restored giving a warning
 2021-03-21 17:39:34 +01:00
Ralf Becker
b79971a1e9 set columns to search for phoneSearch for non-SQL backends too 2021-03-21 12:56:59 +01:00
Ralf Becker
fc50aa6312 phonesearch: LDAP or AD backend only search for local part hopefully stored without any formatting 2021-03-21 10:39:26 +01:00
nathangray
ce17d087c1 Fix hidden upload share link would not work for logged in user that was not share owner 2021-03-17 11:34:09 -06:00
nathangray
c21af32c1b Fix hidden upload share link would not work for logged in user 2021-03-17 11:17:06 -06:00
nathangray
47d2f433d6 Fix missed fstab mount kept unmounted shares around 2021-03-16 11:38:44 -06:00
Ralf Becker
06907d040b fix hidden upload sharing incl. use of multiple share-links in tabs 2021-03-16 15:03:15 +02:00
Ralf Becker
2aff05757e fix home-directories where created with wrong permissions, as Vfs::$is_root was wrongly evaluated 2021-03-15 11:41:53 +02:00
nathangray
1ffde3b692 Change global sharing variable to be a list of shares in use, indexed by token. This should resolve the issues with multiple shares being accessed in the same session. 2021-03-11 17:00:16 -07:00
nathangray
ba84d3170d Api: Improve handling of accessing multiple shares (Collabora or directory) in new tabs while logged in 2021-03-11 09:50:12 -07:00
Ralf Becker
fcc5c80244 match tel_assistent last, as it moves contacts to the end of the search result 2021-03-10 09:14:30 +02:00
Ralf Becker
dc41db9741 fix reverted regular sort order 2021-03-09 20:57:39 +02:00
Ralf Becker
646a04630d sort assisten phone matches to the end of the list 2021-03-09 20:49:12 +02:00
Ralf Becker
a10b772516 fix PHP Notice: Undefined offset 2021-03-09 09:19:15 +02:00
nathangray
8063d65303 Check that some things exist before trying to use them 2021-03-05 09:30:02 -07:00
nathangray
95f84454be Silence some warnings & debug 2021-03-05 09:13:12 -07:00
Ralf Becker
58ae23c74c allow "app.<appname>.<method>" in link registry and use it to open CRM view 2021-03-04 11:50:13 +02:00
nathangray
a8278b37ff Fix editable link opened by original user in new tab gave "Requested resource '/' does NOT exist!" 2021-03-03 14:23:42 -07:00
Ralf Becker
89d6dc8650 Fixing the fix Undefined constant DateTime 2021-03-02 10:25:11 +02:00
Ralf Becker
b1af8449fd Fix ErrorException: Object of class EGroupware\Api\DateTime could not be converted to string 
It's happening as we removed __toString method from Api\DateTime to allow again direct comparing with comparison operators
 2021-03-02 09:37:43 +02:00
Ralf Becker
a41865209c stop SQL error, when using account-type with name2id($name, "person_id", "u") 2021-02-26 21:57:11 +02:00
Hadi Nategh
2a2f0bf390 Keep darkmode state in serverside session too. Fix darkmode state in egroupware iframes. 2021-02-24 12:22:27 +01:00
Hadi Nategh
a67e433396 WIP Mobile and Compact theme styling improvements: 
- Fix logout button not displayed in Compact theme
 2021-02-23 16:21:38 +01:00
Ralf Becker
319c0e6af4 use CRM view preference in CTI 2021-02-19 21:30:50 +02:00
Ralf Becker
fdecefebd4 fix exception when trying to store a DateTime 2021-02-19 21:30:50 +02:00
Ralf Becker
e1b9d993a5 missing phoneSearch commit to only search certain numbers, if specified and fix for a typo causing a warning 2021-02-19 21:30:50 +02:00
nathangray
c319478816 Fix readonly shares were mounted as writable when shared to another user 2021-02-16 16:14:32 -07:00
Ralf Becker
e54aebebca xml tags must not include undeclared namespaces like: <link-entry:infolog 
Reinstating "throw an exception on XML errors in eTemplates for easier fixing"

This reverts commit 18b7d9311c.
 2021-02-16 21:52:40 +02:00
nathangray
4b6551c5a3 - Fix missing quote when updating shares with VFS changes 
- Fix user delete entry search for single user
 2021-02-16 11:53:32 -07:00
nathangray
18b7d9311c Revert "throw an exception on XML errors in eTemplates for easier fixing" 
This reverts commit 81b4737710.
 2021-02-16 11:39:38 -07:00
Ralf Becker
81b4737710 throw an exception on XML errors in eTemplates for easier fixing 2021-02-16 17:38:47 +02:00
Ralf Becker
57d5176080 remove non-digits and only search phone-numbers in phoneSearch 2021-02-15 21:28:39 +02:00
Ralf Becker
ee6a74a40f fixed CRM view opened for id=0 2021-02-15 17:20:17 +02:00
Ralf Becker
31b7db5bbe some more logging 2021-02-15 16:19:53 +02:00
Ralf Becker
a64590d3db moving opening of CRM view code into Contacts class 2021-02-15 15:11:24 +02:00
Ralf Becker
10fd1cd76b fix typo 2021-02-14 17:55:04 +02:00
Ralf Becker
2291cc8df0 WIP incomming CTI / open CRM view when phone rings 2021-02-14 17:46:08 +02:00
Ralf Becker
cfc7c1cbdf some more tolerant searches to find numbers in EGroupware GmbH database 2021-02-14 14:52:33 +02:00
Ralf Becker
f8ec1618d9 * Adressbook: phone-number in search only returns contacts having that (normalized) number 2021-02-14 14:06:21 +02:00
Ralf Becker
c37581f43c * EPL/mail: support SpamTitan REST API to manage spam, requires an API token 2021-02-08 17:31:49 +02:00
nathangray
98d5e86121 Avoid some warnings 2021-02-05 08:57:48 -07:00
Ralf Becker
04f4a327c2 implement date-duration select_unit="false" to show durations like "0:01:20" 2021-02-05 15:57:59 +02:00
nathangray
be9fcea5c5 Etemplate: Make sure all attributes get expanded 2021-02-04 14:48:22 -07:00
Ralf Becker
15c72f284f change client-side to only deal with a duration converted server-side from an end-datetime or a duration like "+123seconds" 2021-01-28 19:53:14 +02:00
Hadi Nategh
e98a8b372e Only apply darkmode preference on top level window for initiation because the rest is supposed to get set from client-side state 2021-01-28 18:03:27 +01:00
Ralf Becker
5b4a436ab3 countdown: convert datetime server-side into a duration to avoid problems with wrong time or timezone on client 2021-01-28 16:02:38 +02:00
Ralf Becker
69b33e9288 make countdown a value-widget to get automatic timezone handling by date widgets beforeSendToClient method 2021-01-28 12:08:29 +02:00
Ralf Becker
511325570a fix empty accounts addressbook after 20.1.20210125 update 2021-01-26 12:51:33 +02:00
Ralf Becker
1259ae8d04 More automatic timezone handling schema for new code (hopefully not breaking existing code): 
1. SO converts all timestamps to Api\DateTime objects using Api\DateTime::server2user($ts, 'object')
 - Api\Storage and Api\Storage\Base class do that automatic if using 'object' as $timestamp_type constructor parameter
 - if using just Api\Db you need to iterate over your selects manually and apply Api\DateTime::server2user($ts, 'object')
 - timestamps are store in DB in server timezone and above conversation honors that and additionally set the user TZ
2. Rest of the app should keep all timestamps as Api\DateTime objects
 - direct comparison works for Api\DateTime (and PHP \DateTime) as __toString() method automatic converts to UTC timestamps
 - do NOT convert them to timezone-less timestamps and no further timezone conversation needed for output with eTemplate
3. eTemplate2 converts automatic to user timezone for displaying dates and times
 - you need to use <date-time ... data_format="object"/> to get Api\DateTime objects back from eTemplate!
4. Api\Db converts automatic to server timezone when quoting DateTime objects for integer or timestamp columns
5. only output other then eTemplate might need to set a timezone different from the user TZ before calling $ts->format()
 2021-01-26 11:16:42 +02:00
Ralf Becker
8425f380fe some fixes for int/float widget: server-side was not expanding min/max attribute and client-side considers empty min/max attr as 0 2021-01-22 17:24:55 +02:00
Ralf Becker
fe320938e5 document EGroupware timestamps and remove own __toString() method to be able to compare objects 2021-01-22 15:18:39 +02:00
Ralf Becker
3eaab63bfa new $output_mode=5 for exec to allow validating client-side created templates, see SmallParT\\Questions\\ajax_answer() 2021-01-19 14:55:27 +02:00
Ralf Becker
b892c54797 allow to format link-registry entries "add", "edit", ... as "url" parameter for actions 2021-01-14 15:59:03 +02:00
Ralf Becker
e588d63291 allow *-wildcard in egw:uses path eg. "/smallpart/js/overlay_plugins/*.js" 2021-01-03 21:06:45 +02:00
Ralf Becker
5bcbde4f88 * LDAP/Addressbook: use accounts filter from setup for accounts addressbook too 2020-12-29 19:37:21 +02:00
nathangray
0a95588642 Preference needs this to not get changed here, otherwise validation doesn't find what it needs 2020-12-22 11:54:31 -07:00
nathangray
6af3e37bed * Etemplate: Add context menu action on linked files to copy them somewhere else 
Also, update vfsSelect to use request(), so it processes the additional stuff in response so we can have a success message.
 2020-12-21 13:53:24 -07:00
nathangray
93b64235a2 Etemplate: Fix customfield prefix attribute length assumption 2020-12-17 10:07:50 -07:00
Hadi Nategh
467a9cad42 WIP darkmode theme: Implement darkmode switch for mobile view 2020-12-17 17:20:04 +01:00