Commit Graph

1794 Commits

Author SHA1 Message Date
Ralf Becker
dd8e9c6269 use full url-encoding for all clients as required by most clients and RFC 2018-11-22 18:15:43 +08:00
Ralf Becker
630c340ce8 * WebDAV: fix encoding for Cyberduck or Mountain Duck clients 2018-11-22 18:15:43 +08:00
nathangray
bc5c3c161c Etemplate - for value widget sums, treat empty fields as 0 2018-11-21 15:10:43 -07:00
Ralf Becker
0ea9d513e5 fix PHP 7.2 Warning count(): Parameter must be an array or an object that implements Countable 2018-11-20 08:09:13 +08:00
nathangray
132b0fca1c Change tests to try and make Widget scan happy 2018-11-15 15:11:52 -07:00
nathangray
38939f1f38 Improvements for entry widget for robustness, includes automatic server side tests. 2018-11-15 11:15:35 -07:00
Hadi Nategh
5745919c5a Fix broken tutorial onclick handler 2018-11-14 09:57:40 +01:00
nathangray
5ca429b972 ID reset has to go after parent call, or things break 2018-11-13 15:06:46 -07:00
nathangray
2bf7e14477 Etemplate - add custom field sub-fields for app-entry widgets
- add regex & regex_replace attributes to change value around
2018-11-13 14:11:26 -07:00
Hadi Nategh
48ad4f6d25 Make sure value is set before using it 2018-11-06 16:31:17 +01:00
Hadi Nategh
bb60ddd040 * Api: fix radiobox not return current selected value but the first value 2018-11-06 14:32:15 +01:00
nathangray
78752738d2 Fix Select All sometimes misses rows if there's between 50 and 1000 and you scroll down 2018-11-05 15:54:26 -07:00
Hadi Nategh
7089489db9 Hide editor statusbar from compose dialog 2018-11-05 15:35:13 +01:00
nathangray
5c03107500 Fix Select All sometimes misses rows if there's between 50 and 1000 2018-11-02 14:54:13 -06:00
Hadi Nategh
b86e2e2e6f Try to pass context on when binding events because there might be some other plugins using those events too. Fix broken avatar cropper. 2018-11-02 10:00:08 +01:00
nathangray
9437c89d74 Missed translations reported by Stefan Unverricht 2018-11-01 11:56:09 -06:00
nathangray
4f111e69d3 Etemplate - change default empty label for multiple user/group selection to more appropriate 'Select user or group' 2018-11-01 11:54:50 -06:00
Ralf Becker
2f1333a116 return and show in browser JSON parsing errors maybe caused by network problems
server sends HTTP status "400 Bad Request" with JSON payload with "error" and "errno" attributes.
error is json_last_error_msg() prefixed with "JSON ".
Not yet implemented is resending the request (max. twice) for JSON parsing errors to try to work around network problems
2018-11-01 12:00:08 +01:00
Hadi Nategh
a635ac34b4 Fix wrong constructed src url 2018-10-31 14:41:36 +01:00
Hadi Nategh
2690ec5053 Introduces avatar.php and replaces all addressbook.photo urls accordingly 2018-10-31 13:49:51 +01:00
Ralf Becker
6b633b2c50 fix added extra line in front of content 2018-10-30 15:38:31 +01:00
Hadi Nategh
e6735f635d W.I.P. migration of mainscreen to et2:
- Fix extra space added when save the entry
- Fix htmlarea not getting a right height when is in inactive tab
2018-10-30 12:02:55 +01:00
Hadi Nategh
8339ddd962 Complement part for the previous commit 2018-10-29 15:19:25 +01:00
Hadi Nategh
9c08c4cee7 Fix et2_htmlarea disabled not working 2018-10-29 15:11:32 +01:00
Ralf Becker
0f80e158ff also set Error/Errno, if database is readonly 2018-10-28 09:29:25 +01:00
Hadi Nategh
9b993e5484 Revert unintentional commit 2018-10-25 18:23:36 +02:00
Hadi Nategh
16fe435de4 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Fix language setting
- Update TinyMCE
2018-10-25 18:18:47 +02:00
Hadi Nategh
e60d061183 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Fix selector fails when textarea id includes some specific chars
- Fix width and height
2018-10-25 16:16:39 +02:00
Hadi Nategh
b00b37efa8 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Fix image upload via old file_selector for etemplate apps
2018-10-25 15:31:41 +02:00
Hadi Nategh
39944322b5 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Replace fckEditor with tinymce for old etemplate apps
2018-10-25 12:32:18 +02:00
Hadi Nategh
b0891483cc W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Add language packages
2018-10-25 10:54:31 +02:00
nathangray
2fc4caec71 * Infolog - Exclude current entry from parent select/search results to avoid loop 2018-10-24 11:11:25 -06:00
Hadi Nategh
908ee59d1a W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Add missing icon
2018-10-24 14:59:31 +02:00
Hadi Nategh
7e25284816 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Add configurable toolbar as preference
- Do not load CkEditor until it's used
2018-10-24 14:48:19 +02:00
Hadi Nategh
44ef6a0a30 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Fix CKEditor widget
- Fix editor doesn't work if no imageUpload is set
2018-10-23 17:10:33 +02:00
Hadi Nategh
345c3c2611 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Add d-n-d image upload
2018-10-23 15:50:55 +02:00
Hadi Nategh
f62c5d8ea5 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Implement vfs file selector
- Add/remove more actions from toolbar
2018-10-23 13:04:20 +02:00
Hadi Nategh
987727f5fa W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Add code plugin in order to be able to edit html script
2018-10-23 10:28:13 +02:00
Hadi Nategh
236006b795 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Keep editor toolbar in one line at least for mail compose
- Add a preference to enable/disable menubar at the top of editor
- Respects mode preference
2018-10-22 12:37:45 +02:00
Hadi Nategh
1cbd0aa2a3 W.I.P. implementing TinyMCE editor and deprecating CKEditor 2018-10-19 16:35:18 +02:00
Hadi Nategh
b39bcc8c36 Remove unintentional commited part from commit a9a303a 2018-10-19 14:59:20 +02:00
Ralf Becker
8ae20c34b9 fix PHP Warning: array_shift() expects parameter 1 to be array, null given 2018-10-19 13:55:23 +02:00
Ralf Becker
1d826e798a fix SQLSTATE[42000]: Syntax error or access violation in filemanager
caused by not correctly quoted empty string instead of id in extended ACL
2018-10-19 13:46:06 +02:00
Ralf Becker
180c07e23c fix PHP Warning: A non-numeric value encountered 2018-10-19 09:46:30 +02:00
Ralf Becker
9e99c8608c copy 17.1 changelog to master to satisfy update checker 2018-10-18 14:33:14 +00:00
Ralf Becker
adee0b4c52 fix warning about unknown option 'ro' by filesystem streamwrapper
it is handled by vfs, so ignoring it here
2018-10-18 11:13:04 +02:00
nathangray
9be59b55bf - Accept an extra array from ajax_create
- Filter extra array by db columns
2018-10-15 14:57:24 -06:00
nathangray
289e6079f7 Last / Next date
- Fix list title back to just date
- Link leads to actual recurrence for recurring events
2018-10-12 10:51:46 -06:00
Hadi Nategh
97eb04e75c Fix broken inline images because of wrong url 2018-10-12 16:58:38 +02:00
Hadi Nategh
01a54413a2 Unbind events after widget gets cleared from DOM to avoid calling events like onchange for second time (eg. infolog projectmanager selection) 2018-10-12 11:29:21 +02:00
nathangray
747e0ecda1 - Last / next event date for accounts too
- Fix bug showing deleted events
- Fix bug showing wrong next date if recurring
2018-10-11 17:09:12 -06:00
nathangray
117b559a5e Entry share changes
- Writable share is now a checkbox
- Add Sharing -> Merge entry into email template, share gets selected options
- Add {{share}} placeholder which creates (by default) read only share
2018-10-11 12:54:17 -06:00
Hadi Nategh
970fb80675 Respect async flag with set false value 2018-10-11 14:14:21 +02:00
nathangray
233832b889 Remove unused title, use Api\DateTime for time conversion 2018-10-10 10:28:28 -06:00
nathangray
16ddefcecf Use custom query for last/next event instead of search 2018-10-09 15:05:35 -06:00
Ralf Becker
9f6a7e3187 fixing no grant required for inviting contacts 2018-10-09 18:59:56 +02:00
nathangray
cb902a3219 Fix complex name finding to handle select options with label & value set, not just simple key => values 2018-10-09 10:20:51 -06:00
Ralf Becker
d8e6c3b919 fix storing and retrieval of urls containing % or %25
- PUT with url containing an encoded % (%25) was stored as is, due to minimal encoding in HTTP_WebDAV_Server class, now this is changed back to store just %
- PROPFIND/REPORT was urldecoding the caldav_name/path, so % as well as %25 were reported as %25
- multiget REPORT was not finding a caldav_name containing %25 reported in PROPFIND as %2525
--> all above is working now and caldav_name with %25 or %2525 can not read via multiget
2018-10-09 18:04:34 +02:00
Hadi Nategh
c3c887da98 Fix set_account_data turns into an infinite loop because of async ajax call 2018-10-09 17:41:38 +02:00
Ralf Becker
109117316c fix PHP Fatal error: Declaration of EGroupware\Api\CalDAV\Principals::delete(&$options, $id) must be compatible with EGroupware\Api\CalDAV\Handler::delete(&$options, $id, $user) 2018-10-09 13:43:25 +02:00
Ralf Becker
cc22e89242 * CalDAV: CalDAVSynchronizer: only allow owner/organizer to update or delete an event (not users with edit/delete rights) 2018-10-09 13:15:11 +02:00
Ralf Becker
985879b56c remove long decrecated use of <app>/inc/(functions|header).inc.php, giving a PHP Warning because of undefined EGW_APP_INC constant 2018-10-08 12:50:34 +02:00
Ralf Becker
d152738321 fix PHP Warning: Invalid argument supplied for foreach() 2018-10-08 12:48:46 +02:00
nathangray
c197d15a28 Explicitly set async to false for user list 2018-10-04 16:09:42 -06:00
nathangray
20956c4966 Explicitly set async to false for user list 2018-10-04 16:01:44 -06:00
nathangray
590446a701 Use framework tooltips for toolbar button tooltips instead of browser titles
Avoids Firefox actually changing the title text sometimes
2018-10-04 15:21:03 -06:00
Hadi Nategh
cceba01f87 Change default value for async json_request to true 2018-10-04 17:48:13 +02:00
Hadi Nategh
577850cfd0 * Api: change default submit to async call and try to block user interfering with submitted popup until the response 2018-10-04 17:23:30 +02:00
nathangray
13598f5342 Prefer most specific select options, if available 2018-10-02 14:19:12 -06:00
Ralf Becker
c950d7b0c1 check if we have a valid template and/or theme on 17.1 update 2018-10-02 12:43:29 +02:00
Hadi Nategh
d022e555d5 Fix xhr url in Offline options 2018-10-02 10:12:40 +02:00
nathangray
f2cfd94391 Add a keep emails flag (default true), set to false to skip saving merged emails to sent folder 2018-10-01 11:16:17 -06:00
nathangray
20629e2a16 Mail merge - Accept false as folder to skip saving to mail folder 2018-10-01 11:15:31 -06:00
Hadi Nategh
54cafd15d7 Implement Online/Offline connection indicator 2018-10-01 15:54:42 +02:00
nathangray
3daa25ca1a Only set taglist empty label for editable widgets 2018-09-28 10:49:12 -06:00
nathangray
92e818f429 Explicitly set taglist empty label 'Select some options' when missing so it can be translated 2018-09-27 11:46:29 -06:00
nathangray
dd8fc59d6a * Addressbook - fix birthday cache was not cleared when birthday edited 2018-09-26 11:27:50 -06:00
Hadi Nategh
b7c359a6f1 * Mail: implement new preference to configure mail identity label shown as mail folder header 2018-09-25 15:00:01 +02:00
Hadi Nategh
13f3cc5260 Fix some issues with select-country widget:
- Country selection in preferences does not respect selected value
- Fix missing empty labels in country selection in preferences
- Remove flag image from empty labels
2018-09-25 11:24:22 +02:00
Hadi Nategh
5615fbf15e Fix commit 4bd103fd7d 2018-09-24 15:00:17 +02:00
Hadi Nategh
475a25b66c Add list of states for more countries 2018-09-24 14:23:58 +02:00
Hadi Nategh
2010850c16 Fix couple of issues regarding AB country and region selections:
- Use taglist-state widget for US state selector
- Make sure falg class only gets added for select-country widget
- Fix some styling
2018-09-24 13:48:24 +02:00
nathangray
4a819f70d4 Move grant cache to class level to ease testing 2018-09-20 11:05:17 -06:00
Ralf Becker
f7d09e9ec0 * CalDAV: work around problems with Outlook CalDAV Synchroniser (https://caldavsynchronizer.org/)
- sends a DELETE to reject a meeting request --> deletes event for all participants, if user has delete rights on the calendar
- always sends all participants back with status NEEDS-ACTION --> resets status of all participant, if user has edit rights
--> remove all add, edit, delete rights from other users
2018-09-20 15:58:00 +02:00
Hadi Nategh
9e1d9e143e * Mail: fix deleting mails from draft folder does not respect "move to trash" in delete message preference 2018-09-20 15:25:11 +02:00
Hadi Nategh
66bb77b37c Fix 7-5 days switch action in calendar toolbar does not show a right cursor 2018-09-20 14:25:24 +02:00
Hadi Nategh
4bd103fd7d Make sure whitespaces are removed from certkey before doing comparison 2018-09-20 14:14:05 +02:00
Hadi Nategh
6c4cc97a5f Implement new taglist widget to represent list of regions of a selected country 2018-09-19 16:43:19 +02:00
nathangray
e805551575 Keep image tags when merging into HTML templates 2018-09-18 10:21:36 -06:00
Hadi Nategh
1c9836f95e Add more regions into country class 2018-09-18 17:04:37 +02:00
Hadi Nategh
cdae6c4b01 Fix country-select does not set flag when switching between countries 2018-09-18 16:05:32 +02:00
Hadi Nategh
82065b51c3 Fix unwanted autocomplete showing up for country-select widget 2018-09-18 15:16:51 +02:00
Hadi Nategh
6e94639b0a Implement flags indication for country-select widget:
- Migrate AB country selector to select-country tags
- Migrate Country selector in preferences to use select-country tags
2018-09-18 10:46:36 +02:00
Ralf Becker
1eb64136ce fix not working login with permanent redirect to login page: session could not be verified 2018-09-17 15:03:19 +02:00
Ralf Becker
5ceabc8e96 fix parsing of boolean attributes:
- no defaults for disabled/readonly as it defaults depend on readonlys[__ALL__] is set or not
- only cast value to boolean, if it does not contain a variable eg. "!@no_something"
2018-09-17 11:16:38 +02:00
Ralf Becker
321b56e2b6 * Addressbook: private addressbook in newer installations could not be enabled
caused by forced preference value of false casted to string as "", now we write all forced and default preferences with value false as "0" AND update all forced preferences only from "" to "0"
2018-09-14 14:02:51 +02:00
nathangray
cabbacf229 Missing translations from Stefan Unverricht 2018-09-13 14:26:54 -06:00
nathangray
752138cc16 Make link-to results list taller, search box in nextmatch header wider 2018-09-13 11:44:27 -06:00
nathangray
4bafc12326 Remove doubled taglist header 2018-09-13 11:17:30 -06:00
nathangray
075c7851db Translate taglist option labels 2018-09-13 11:16:20 -06:00
Ralf Becker
e483ec4957 automatic cast and defaults for boolean attributes
Not all attributes are implemented, as many dont play any role on server-side.
Fixes taglist-account multiple="false" returns array(<selected id>)
2018-09-13 14:57:50 +02:00
nathangray
822b967fe3 Better handling of HTML tables when merging.
Fixes table within table broke format parsing.
2018-09-12 16:46:36 -06:00
Ralf Becker
9f3f3e501d fix PHP Warning: Use of undefined constant OPENLDAP_LDAPSERVER 2018-09-12 17:06:31 +02:00
Ralf Becker
a646bc6a61 disabling permanent error_log in favor of $debug attribute 2018-09-12 14:52:34 +02:00
nathangray
9368992032 Fix namespace 2018-09-10 15:26:53 -06:00
nathangray
8abbefd9e1 Missing 'move' translation in VFS select dialog 2018-09-10 09:50:41 -06:00
Ralf Becker
58703cbaba * Filemanager/SMB: fix directory creation failed on Samba (smbclient PHP extension)
smbclient treats every non-zero value of $options parameter as recursive, not just &1 and we have by default &8 = STREAM_REPORT_ERRORS set.
2018-09-06 12:04:18 +02:00
nathangray
7efefc6e63 Strip UTF-8 BOM from ical file 2018-09-05 13:29:03 -06:00
nathangray
cf1f99a828 Trying to get tests to pass
- Cast type array to array
- Try explicitly disconnecting db after test
2018-09-05 09:53:57 -06:00
Hadi Nategh
9b742430c5 Allow single or double quoting as valid personal part of email rfc822 2018-09-04 13:51:10 +02:00
Hadi Nategh
d50f444965 Try to stripe extra quoting from personal part of email address 2018-09-03 16:21:32 +02:00
Ralf Becker
1e95f0608b copy 17.1 changelog to master to satisfy update checker 2018-08-31 14:08:46 +00:00
Hadi Nategh
2f8ba269e3 Revert previous commit, since horde smime verification itself takes care of it with extracting email out of cert 2018-08-30 14:19:00 +02:00
Hadi Nategh
e5bd217a77 * Mail: take certificate SAN email into account when verifying SMIME signed message 2018-08-30 14:06:26 +02:00
nathangray
2cf4904e1e Don't use a static reference to egw->db, it breaks tests 2018-08-29 10:04:25 -06:00
nathangray
be34f95723 Add template fetch fallback using egw.link() if template_base_url fails 2018-08-24 12:03:19 -06:00
nathangray
e4308f3d27 Fix positioning to center after template is loaded 2018-08-23 15:41:14 -06:00
Hadi Nategh
b4b2b9d5d2 Implement an admin-config setting to be able to disable PGP encryption feature 2018-08-23 16:58:14 +02:00
Hadi Nategh
08b9138ae6 Fix tutorials json feed and PGP Installation tutorial video 2018-08-23 14:54:37 +02:00
Hadi Nategh
36a6efe837 Fix missing translations for PGP Back/restore feature 2018-08-23 13:47:04 +02:00
Hadi Nategh
45ccd5f780 Add more translations for admin toolbar settings 2018-08-23 13:29:26 +02:00
Neo Morina
8093e6a549
Update Taglist.php
For showing better results.
2018-08-23 11:39:09 +02:00
Hadi Nategh
051531c3d0 Add some translations for admin toolbar settings 2018-08-22 14:11:36 +02:00
Ralf Becker
cf10e4af69 make sure Api\Config::read(_repository) always returns an array
even if not configuration is saved yet
2018-08-22 11:24:05 +02:00
Hadi Nategh
698e77e0cb Implement reset user preferences for admin toolbar actions 2018-08-21 17:22:58 +02:00
Ralf Becker
60e953292a adding sel_options to etemplate2_before_exec hook (for policy) 2018-08-17 14:39:28 +02:00
Hadi Nategh
d7c462149a W.I.P. of toolbar admin default prefs:
- Set default preference by admin
- Consider default preference for the first time login users
2018-08-16 16:52:20 +02:00
Hadi Nategh
2ebbf89b0c Set a placeholder icon if nothing found 2018-08-16 16:49:54 +02:00
Hadi Nategh
bf151cff7b W.I.P. of toolbar admin default prefs:
- Add admin settings button
- Add dialog
2018-08-16 12:29:35 +02:00
Ralf Becker
bbe551d4cc sending appliction/json aka JSON as direct payload for all POST ajax requests
instead of additionally encoding them as form-data
2018-08-16 11:07:50 +02:00
Hadi Nategh
ccda87b157 W.I.P. of toolbar admin default prefs 2018-08-15 16:50:46 +02:00
Hadi Nategh
c69532e7f0 Another attempt to invalidate zero with space (\u200B) char in the beginning an email address 2018-08-15 11:36:37 +02:00
Hadi Nategh
e433c708df Fix taglist fails to invalidate email address which starts with none visible unicode char 2018-08-14 17:15:35 +02:00
Hadi Nategh
d35a337590 Make an incase sensitive comparison between smime cert email and from email 2018-08-14 16:09:12 +02:00
Ralf Becker
5e7ef5386c allow additional "UPDATED" success message to keyring.importPublicKey 2018-08-14 11:33:28 +02:00
Ralf Becker
584613f0bf fix somehow created async-job with a next time before the keep time
eg. not updated alarm trigger time in the past
2018-08-13 15:40:53 +02:00
Hadi Nategh
e1ee71873a Implements lavatar and replace default photo avatar with generated lavatar 2018-08-13 11:56:05 +02:00
Hadi Nategh
29337d79d1 Show lavatar text in caps 2018-08-13 11:53:57 +02:00
Hadi Nategh
73b6ab8128 IE 11 and below does not support ES6 syntax we need to use some polyfills 2018-08-10 10:31:40 +02:00
nathangray
60e43ab60b Etemplate - getWidgetById() can handle nested[type][names] 2018-08-09 12:41:37 -06:00
nathangray
da45cf2776 Avoid warning if filter is null 2018-08-08 09:27:38 -06:00
nathangray
3c5b7c8ba5 * Addressbook - Allow multiselection for customfield added to link title 2018-08-08 09:18:55 -06:00
Hadi Nategh
7289e80e92 Wait till common translations are loaded then ask for IE browser compatibility 2018-08-08 11:12:57 +02:00
Hadi Nategh
931100c2ac Fix translation 2018-08-08 10:48:40 +02:00
Hadi Nategh
3604e66fa6 Exclude Edge from previous commit 2018-08-07 16:30:53 +02:00
Hadi Nategh
4c7d7fa9ca Add IE browser warning as message after login 2018-08-07 16:26:54 +02:00
Ralf Becker
af6c2a0f25 * CalDAV/Calendar: fix not working snozzing of alarms in Thunderbird
Caused by triggered alarms were - so far - immediatly deleted, now we keep them around for an other day, so TB get them in the update iCal after PUTing its X-MOZ-SNOOZE-TIME-<timestampt>
2018-08-07 15:03:59 +02:00
Hadi Nategh
77aa6cae4e Add translation 2018-08-07 13:51:02 +02:00
Hadi Nategh
dae7c85b42 Warn user on login page if using browser is IE 11 or below. 2018-08-07 13:40:46 +02:00
Hadi Nategh
c5a291218a Fix full_email option in email-url not working 2018-08-03 16:15:24 +02:00