Ralf Becker
7248b6649b
fix a bunch of PHP Warnings
2021-10-12 11:51:28 +02:00
Ralf Becker
044aae3cf8
fix PHP 8.0 error: Undefined constant "EGroupware\Api\Contacts\cat_id"
2021-10-11 18:40:21 +02:00
Ralf Becker
f29a2b5ea8
fix PHP Warning: Illegal string offset 'tmp_name'
2021-10-11 14:02:46 +02:00
Ralf Becker
59794cc3a4
output line and file of exception as trace not always contain it
2021-10-09 08:43:32 +02:00
Ralf Becker
a04cbc0ab4
an other chunk of PHP 8.0 Warnings fixed
2021-10-08 15:43:48 +02:00
Hadi Nategh
f62ff90444
Accept mail externalImages with long url
2021-10-08 14:30:04 +02:00
Ralf Becker
cb991f1243
fix Api\Accounts::username(): Argument #1 ($account_id) must be of type ?int, string given
2021-10-08 14:10:45 +02:00
Ralf Becker
fac81f660d
fix PHP 8.0 errors around ACL dialog and policy:
...
- bitwise AND operator gives TypeError if both values are neither a number nor a numeric string, eg: null, "run"
- Etemplate::setElementAttribute() must NOT be called before instantiating an Etemplate object, you will get fatal error otherwise, because no request object
2021-10-08 09:05:58 +02:00
nathan
d43c27a31b
Fix nested placeholders (customfields from other apps) were not being displayed properly
2021-10-07 14:51:16 -06:00
nathan
c73a7beac8
Add placeholder list for calendar & filemanager
2021-10-07 13:47:14 -06:00
Ralf Becker
417bbccbe3
fix PHP 8.0 Fatal error: Declaration of Api\Etemplate\Request\Session::read($id = null) must be compatible with Api\Etemplate\Request::read($id = null, $handle_not_found = true)
2021-10-07 18:39:40 +02:00
nathan
da6a16e62d
- Add generation target path preference to all apps
...
- Use common method to get merge preferences to reduce duplication
2021-10-07 10:22:45 -06:00
nathan
40af04e38e
Fix broken Merge::get_app_class(), we need it to autoload the class
2021-10-07 09:31:43 -06:00
Ralf Becker
460d8cbe0d
fix not working preferences GUI after ddddc5ba05
2021-10-07 17:28:06 +02:00
Ralf Becker
a8d14ffa0a
fix TypeError: Argument 1 passed to EGroupware\Api\Accounts::username() must be of the type int, null given
2021-10-07 16:53:33 +02:00
Ralf Becker
d915b25bba
fix PHP 8.0 error Illegal string offset
...
folder object need to be cast to string (folder name) as objects are not allowed as array keys
2021-10-07 12:37:10 +02:00
Ralf Becker
b1780a35bc
fix Api\Storage\Merge::document_editable_action(): Argument #1 ($action) must be of type array, null given
2021-10-07 12:17:33 +02:00
Ralf Becker
e4f95d9c20
fix missing icons after previous commit
2021-10-07 11:57:20 +02:00
Ralf Becker
d00d6f65f0
fix PHP 8.0 error when deleting a Kanban card
...
- link deletion failed when link_id was "" as in PHP 8.0 "" < 0 --> gave the error
- link to card was never deleted as board_id is not stored in card
2021-10-07 10:44:23 +02:00
Ralf Becker
91bd7c7aeb
an other chunk of fixed PHP 8.0 Warnings
2021-10-07 10:14:43 +02:00
nathan
45f039da95
* Add preference to set the filename of merged documents using placeholders
2021-10-06 11:59:29 -06:00
Ralf Becker
cb8cac15dc
fix mail account creation under PHP 8.0
...
PHP 8.0: "new" > 0 === true
PHP<8.0: "new" > 0 === false
2021-10-06 12:31:23 +02:00
Hadi Nategh
d3fd2aa76a
PHP8: fix error Illegal offset typePHP, happens while moving mail from one account to another
2021-10-06 11:38:54 +02:00
Hadi Nategh
ffeb929b49
Fix wrong condition on checking url strlen
2021-10-06 11:09:32 +02:00
nathan
a0a89a6b74
Placeholder dialog: Add placeholders for projectmanager, timesheet, tracker
2021-10-05 16:09:39 -06:00
Ralf Becker
b37e7ff57a
quieten permanent error_log
2021-10-05 14:20:29 +02:00
Ralf Becker
ddddc5ba05
next big chunk of fixed PHP 8.0 Warnings
2021-10-05 14:11:11 +02:00
Ralf Becker
357fefaad0
fixing some conditions in the previous commit stalling InfoLog list
2021-10-05 11:14:40 +02:00
nathan
6126bc2ac9
Placeholder dialog: Placeholder groups can now have groups
...
References (info_contact)/ customfields to other apps are expanded so all their placeholders are available as well
2021-10-04 14:45:57 -06:00
Ralf Becker
1747a2236a
fixing a ton of PHP Warnings slowing us down in PHP 8.0
2021-10-04 18:50:51 +02:00
Ralf Becker
ac7faf6036
fix PHP 8.0 error: count(): Argument #1 ($value) must be of type Countable|array, string given
2021-10-04 13:02:34 +02:00
Ralf Becker
1cd5755ae4
fix PHP 8.0 Warning: Argument #2 of array_merge must be of type array, boolean given
2021-10-04 11:01:32 +02:00
Ralf Becker
782c284d37
improve parsing if only a fullName is given to support the following:
...
- Becker, Ralf --> surname: Becker, personal: Ralf
- Ralf Becker --> surname: Becker, personal: Ralf
- Becker --> surname: Becker
2021-10-04 10:41:22 +02:00
Ralf Becker
c647ddab60
improving parsing of country data:
...
- if we got a country-name but no -code, look up the code
- if we got a country-name like "Name (Name2)" try both separate first
- if we have a valid country-code set the -name to be the untranslated one as our UI does
2021-10-04 09:46:17 +02:00
Ralf Becker
9ca8b07de9
fix parsing with no street data and of custom fields
2021-10-03 18:45:34 +02:00
nathan
117b193a63
Add some missing general placeholders
2021-10-01 13:37:17 -06:00
nathan
96bdcd7c0e
Fix some placeholder dialog bugs:
...
- Fix user placeholder does not use selected entry, so looks like a bug. Now hiding entry for user placeholders.
- Fix user & general showed up in entry app selectbox
- Fix insert address dialog was not passing selected entry
2021-10-01 13:35:27 -06:00
Ralf Becker
2d2b16a2f6
if no separate name-components given, simply split first word off as n_given and rest as n_family
2021-10-01 18:27:36 +02:00
nathan
71ef7ccd0d
Fix some merge action bugs:
...
- default document wasn't working properly, missing caption
- Email documents were giving "Unable to generate merge file"
2021-10-01 10:06:29 -06:00
nathan
1dc9dd0c6b
* Add a preference so you can choose where merged documents are put
2021-09-30 12:01:37 -06:00
nathan
fb88f8846b
Merge as PDF:
...
- improve error logging
- remove original merge result when PDF conversion succeeds
2021-09-29 11:01:07 -06:00
Ralf Becker
89923e25c4
add an additional static method Api\Mail\Smtp::mailbox_address()
...
as PHP 8.0 does not allow to call a non-static method static, even if $this is (conditionally) not used
2021-09-29 10:10:48 +02:00
nathan
707c57ecf0
* Add option to merge documents as PDF
2021-09-28 17:00:55 -06:00
nathan
2a4faf0137
* Add filemanager actions to convert editable files to PDF or PNG
2021-09-28 14:48:25 -06:00
nathan
7f930a6221
Placeholder dialog: Support for other apps, starting with Infolog
2021-09-27 14:46:41 -06:00
nathan
eb57294146
Placeholder dialog: Allow & show general fields
2021-09-27 11:09:38 -06:00
nathan
369de2e3d5
Specific ordering for contact merge placeholders
...
also, use switch to using prefix()
2021-09-27 10:54:57 -06:00
nathan
47cf12869b
Utility function to add prefix to placeholder & optionally wrap it with markers, because I was writing it out so many times
2021-09-27 10:54:57 -06:00
Ralf Becker
e640873fc0
implement and document PATCH
2021-09-25 12:38:08 +02:00
Ralf Becker
1280de46d6
REST API allow sending a JSON patch to update or create a new contact (currently only via POST or PUT, not as PATCH!)
...
allows eg. to create a contact from a simple Wordpress contact-form only supporting POST requests and a flat object, see new example in the documentation
2021-09-24 18:06:13 +02:00
Ralf Becker
d9f759f517
fix PHP 8.0 error: implode(): Argument #2 ($array) must be of type ?array, string given
2021-09-24 12:29:48 +02:00
nathan
704b6c6dc2
Add user placeholders into placeholder dialog
2021-09-22 11:15:49 -06:00
nathan
d512238dc0
* Collabora: Add address insert dialog
2021-09-21 14:07:22 -06:00
Ralf Becker
15a2e546ea
missing @type="NameComponent" and updated examples in docu with @type
2021-09-21 18:50:40 +02:00
nathan
8e67e2efad
WIP on placeholders
...
- Some TS cleanup
- Fix error in preview giving wrong results
2021-09-21 10:19:24 -06:00
Ralf Becker
8db7d13c49
Implemented @type attributes for all top-level objects from JsContact Draft 08
2021-09-21 11:09:32 +02:00
nathan
29bd739955
W.I.P on collabora placeholder insert
2021-09-20 15:34:55 -06:00
Ralf Becker
82c8ed51d2
Contacts REST API:
...
- implement missing PUT/POST of distribution list / CardGroups
- implement changes from next JsContact draft:
+ string plus extra localizations attribute instead of localizedString object
+ use "<domain>:<name>" for vendor attributes
- add/parse urn:uuid: prefix if UID is a UUID
2021-09-20 16:01:22 +02:00
Ralf Becker
0a75520a01
* Filemanager/Sharing: create different share-token for different recipients (before recipients where added to the token)
...
- allows to individually remove the token, otherwise new token for the other recipients need to be redistributed
- sending one email to multiple recipients still creates a single share-token for all the recipients (send multiple mails if that's not desired)
2021-09-20 13:27:31 +02:00
Ralf Becker
e9998161a5
finished REST API for contacts modulo docu and bugs ;)
...
- JsCardGroup now used for distribution lists
- responses are not in "responses" attribute (no longer in root of object)
- fix sometimes empty / different members between PROPFIND/REPORT/JSON-GET and GET of group (caused by wrongly implemented limit to given AB)
- JSON pretty-print only if requested by Accept: application/pretty+json
- fix invalid JSON for errors (caused by opening {"responses": already sent
2021-09-19 11:09:44 +02:00
Ralf Becker
3a88aedce1
fix PHP Deprecated: stripos(): Non-string needles will be interpreted as strings in the future
2021-09-18 09:44:46 +02:00
Ralf Becker
7617aae9d0
got POST, PUT and DELETE request to add, update and delete contacts working
...
added JSON exception handler with nicer JsCalendar parse errors
2021-09-17 20:15:36 +02:00
Ralf Becker
8793f7895b
fix excess separator, if not 2nd street-line
2021-09-17 11:58:39 +02:00
Ralf Becker
0768f5fadf
WIP REST Api for contacts
2021-09-16 20:53:43 +02:00
Ralf Becker
38e2167166
WIP REST API for contacts using JsContacts draft
2021-09-15 18:45:45 +02:00
Ralf Becker
be3514c36f
preferring get_rrows over get_rows to fix SQL error in timesheet merge
2021-09-13 18:02:39 +02:00
Ralf Becker
621d69f921
missing files from filemanager mount GUI
2021-09-13 17:41:21 +02:00
Ralf Becker
4727340f1d
* Filemanager: added user-interface to mount WebDAV or SMB shares
2021-09-13 16:16:36 +02:00
nathan
36df64085f
* Api: Fix some merge files were opened in browser instead of downloaded
2021-09-03 09:33:32 -06:00
Ralf Becker
582793d52b
Revert "Bring web-component work into master branch"
...
To many things are not working :(
- addressbook, infolog, even timesheet index lacks at least r/o textbox and problably other widgets
- smallPART (with many extra widgets) is completly unusable
- *box widget seems not to skip empty boxes
--> we need more testing and progress, before we can merge that
This reverts commit 9cee681b94
.
2021-09-03 11:28:22 +02:00
Ralf Becker
a566599b7f
* PostgreSQL/Addressbook/All Apps: fix SQL error in history tab if there are attachments
2021-09-03 09:48:47 +02:00
nathan
9cee681b94
Bring web-component work into master branch
2021-09-02 10:52:10 -06:00
Ralf Becker
e500190728
* Addressbook/PostgreSQL: fix SQL error deleting a contact finally
2021-09-01 09:33:54 +02:00
Ralf Becker
c830bdd923
allow pushing to multiple users in one request
2021-08-31 17:42:28 +02:00
Ralf Becker
6baf07090e
implement some missing features from old eTemplate:
...
- evaluate class set on a grid cell as done for the widget contained (probably more a bug-fix then a feature)
- allow to preset query for link-entry widget by passing an object with a query attribute
- allow to overwrite not only $readonlys[__ALL__] but also widget readonly attribute with a $readonlys value of false
2021-08-19 10:46:34 +02:00
nathan
9231b32fce
Vfs: Fix Stylite/Links/StreamWrapper was not respecting backup parameter
2021-08-18 15:59:54 -06:00
Ralf Becker
61cdef588a
need to catch the statement in line 1347
2021-08-18 10:48:24 +02:00
Ralf Becker
1462fb517a
* PostgreSQL: fix SQL error when accessing eg. InfoLog
...
Links class trys to delete empty attachment directories and virtual / empty attachment directories have non-integer (hash) id causing an SQL error in PostgreSQL.
2021-08-18 09:18:21 +02:00
Ralf Becker
94c98718ef
update script to remove hashes/non-email-addresses from egw_history_log.share_email
2021-08-17 09:15:25 +02:00
nathan
bea880d9b1
* Api: Fix changes in history log had a hash instead of user if the change was made after a share was opened.
2021-08-16 13:07:17 -06:00
Hadi Nategh
2515d457d5
* Knowledge Base: fix pasting/dragging image into htmlarea editor does not work
2021-08-16 11:52:26 +02:00
Hadi Nategh
d07a7ab194
WIP of replacing bower-asset packages:
...
- Get jquery-ui and touch event plugin working (although still modular import is not possible becuase of a wierd issue with jquery-ui tooltip plugin)
- Import timepicker-addon plugin as npm package
- Update composer.lock file
2021-08-12 14:51:38 +02:00
nathan
6c0aed651f
Api: Add some extra parameters to Merge::merge_entries() so overridding classes can still use the parent method, passing in IDs & merge object
2021-08-09 13:44:43 -06:00
Ralf Becker
8f93a7f7c6
* Setup: support uninstalling automatic installed apps (no more reinstalling next update)
2021-08-03 18:53:05 +02:00
Ralf Becker
93068dcfcc
need to call Vfs\StreamWrapper::init_static() after setting Vfs::$user
...
Vfs::$user should be protected and moved to Vfs\Base plus a getter and setter method added for public access,
as after setting it in 21.1+, Api\Vfs\StreamWrapper::init_static() need to be called to set the default user context!
2021-07-22 09:08:49 +02:00
nathan
b95f9e7220
Reset after every job
2021-07-20 14:23:21 -06:00
Ralf Becker
df4137baee
* Filemanager/VFS: when creating a new file as root eg. via (docker exec) filemanager/cli.php do NOT create files unreadable by webserver
2021-07-20 09:34:59 +02:00
Ralf Becker
cc27253b7b
keep original REQUEST_URI in ORIG_REQUEST_URI when modifying it
2021-07-19 14:15:16 +02:00
Ralf Becker
2f155e0d79
fix popups of apps without app.ts/js wont work as eT2 is not available
...
it get's included by the app.ts/js otherwise
2021-07-13 21:02:08 +02:00
Ralf Becker
6502eaeab8
got symlinks working for filesystem streamwrapper and fix one bug in Vfs with symlinks
2021-07-13 13:59:05 +02:00
nathan
da1e7b9fee
Implement symlink for filesystem StreamWrapper with test
...
Whether it works or not depends on filesystem though.
2021-07-09 09:47:23 -06:00
Ralf Becker
d57fe03326
use same method (prefer .min.js over .js) for app.js include in Etemplate and Framework
...
fixes double include of /mail/js/app.js and /mail/js/app.min.js
2021-07-08 16:58:05 +02:00
nathan
2e597997e0
Fix wrong permission constant used, resulting in permissions when there shouldn't be
2021-07-07 14:42:10 -06:00
Ralf Becker
a8ae92e1cc
add cache-buster to framework bundle
2021-07-07 16:51:31 +02:00
Ralf Becker
90f1d9ea37
always show deleted filter and set deleted status in calendar
...
see #29778
2021-07-07 11:21:45 +02:00
nathan
da3f8d8135
Fix symlink directory problem from 2a64e79
and add a unit test to avoid that in the future
2021-07-06 16:44:53 -06:00
nathangray
b021767ac1
Make sure nested document actions open in new tab, same as others.
2021-07-05 09:46:00 -06:00
Ralf Becker
1423616e00
remove some dead code and spelling fixes
2021-07-04 08:52:43 +02:00
nathangray
34d601b102
Api: Fix missed change in nested document actions
...
see 186e03671a
2021-07-02 12:04:38 -06:00
nathangray
2a64e79e65
Api: Fix bug where StreamWrappers that mapped onto other StreamWrappers would be parsed earlier than we want, leading to the first StreamWrapper not getting used.
2021-07-02 12:11:54 +02:00