Commit Graph

594 Commits

Author SHA1 Message Date
nathangray
f8b57077fb A start on some automatic testing for apps
- use 'phpunit -c doc/phpunit.xml' to run tests
 - extend api/src/test/AppTest.php to write application tests
2017-01-06 10:39:16 -07:00
Hadi Nategh
c7089cadd9 Revert unintentional changes to mrconfig and ContentSecurityPolicy from commitacdf079fb180490d8659fad0f4c20dd74ea78503 2017-01-05 15:04:53 +01:00
Hadi Nategh
acdf079fb1 * Etemplate: Fix error "Etemplate\Api\Auth not found" happening while to login 2017-01-05 14:59:20 +01:00
Ralf Becker
dc84982a55 * CalDAV/CardDAV: send unchange REALM for "bad login or password" to allow storing credentials 2017-01-04 10:18:34 +11:00
Hadi Nategh
2d1bb1ecc3 Another patch to previous commit in order to cover empty space 2016-12-12 10:20:46 +01:00
Hadi Nategh
760bd4106f * Mail: Fix accounts selectbox in compose dialog does not include email addresses. Additionally, let local accounts without '@' get explicitly displayed in accounts selectbox. 2016-12-12 09:35:52 +01:00
Ralf Becker
d4a64babbd fix PHP 5.4 Fatal error: Can't use function return value in write context 2016-12-08 16:22:54 +01:00
Hadi Nategh
23aea3864c Keep allowExternalIMGs preference intact and use an explicit preference for allowed domains 2016-12-02 10:09:56 +01:00
Hadi Nategh
6ed3b92298 Work in progress of mail external image handler:
- Fix styling
- Add handler for mobile and display
2016-11-24 14:35:54 +01:00
Hadi Nategh
5fb70c77ab Work in progress of mail external image handler 2016-11-23 18:52:43 +01:00
Ralf Becker
6d472b1592 use openssl_random_pseudo_bytes, if available, to generate etemplate_exec_id, as it is used for CSRF protection too 2016-11-17 11:09:30 +01:00
nathangray
a15aa412e2 Attempt to fix redirects to invalid /index.php 2016-11-16 09:20:03 -07:00
Ralf Becker
6a31d2462a fix identities from aliases or imap-user without @ shown with empty label, if name is empty 2016-11-14 13:43:05 +01:00
Ralf Becker
b38542439a if webserver_url does not match eg. because of proxying, fix it 2016-11-14 13:43:05 +01:00
Klaus Leithoff
e9155a000b * Mail/Z-Push: handle charset-problem on sending mails with added EGW-Signature 2016-11-10 12:50:51 +00:00
nathangray
8ecc188fd7 Customfields required bugs
- Load attributes from modifications array, were previously ignored
- Remove double required check, actual field widget should handle it
2016-11-07 09:22:33 -07:00
Ralf Becker
c20ee5575d allow to use Api\Contacts::search() without Acl check 2016-11-07 09:26:14 +01:00
Ralf Becker
2d35e890fd remove permantent error_log on restore of egw_cal_dates 2016-11-02 14:28:34 +01:00
Ralf Becker
16689ebc27 fix use of old egw class in favor of new Api\Egw 2016-11-02 09:38:37 +01:00
Ralf Becker
225bc0bbc2 fix searching for "group" reveals groups normally hidden by forced account-selection pref "groupmembers" or "none" 2016-10-31 18:46:59 +01:00
Ralf Becker
8040fa49ec remove Exception type, to not get a Type error when PHP 7+ throws an Error 2016-10-31 18:29:32 +01:00
Ralf Becker
dbae12260b fix setting alias and forwards, allow to add/remove from existing ones 2016-10-31 15:41:52 +01:00
Ralf Becker
74e2c62b48 * Admin/Mail: allow to limit users to only create identities for aliases 2016-10-28 14:27:59 +02:00
Ralf Becker
a23ab6a9fb * Addressbook/LDAP: fix error if egroupware-epl-compat (old API) not installed 2016-10-27 10:51:47 +02:00
nathangray
648b6fd759 If searching for an account and you include 'Group ' (or translation) in the search string, it will search just groups instead of all accounts. 2016-10-24 09:21:57 -06:00
Ralf Becker
e989d079d6 removing server-side validation of non-ascii in local part of email, because \x80-\xff gives and invalid utf-8 compilation error in preg_match with /u modifier 2016-10-20 15:21:40 +02:00
Ralf Becker
ab79e193ec * Mail: show validation error if local part (before @) of email-address contains non-ascii chars 2016-10-20 12:29:56 +02:00
Ralf Becker
ad059b81e7 add missing traversable-test mentioned by Scrutinizer 2016-10-20 10:17:20 +02:00
Ralf Becker
2fbafeaa27 add missing false-test mentioned by Scrutinizer 2016-10-20 09:50:57 +02:00
Ralf Becker
c2d1fe6d50 only check vfs for templates, if /etemplates is mounted 2016-10-19 16:44:04 +02:00
Ralf Becker
ae712ff8a1 * Filemanager: break infinit recursion stalling eg. login by introducing max. sub-directory depth of 100
Detects infinit recursion caused eg. by fs_dir pointing to a child-directory.
No idea how to efficently test for that, without scanning all parents of all filesystme nodes.
2016-10-19 15:52:02 +02:00
Klaus Leithoff
7588c9a493 rework of fix for problem regarding send with bcc when using esync 2016-10-19 10:01:38 +00:00
Klaus Leithoff
c47d8a26c3 * Mail: fix problem regarding send with bcc when using esync 2016-10-18 13:59:32 +00:00
Ralf Becker
a81442373c fix typo 2016-10-13 17:58:27 +02:00
Ralf Becker
30cf772c4d move ADOdb row_lock and rollback_lock methods to Db class, use Db::$tablealiases and use them for backup, also added a "backup_(starts|finished)" hook for apps 2016-10-13 17:54:58 +02:00
Ralf Becker
6e1429d833 change to just "Powered by EGroupware <version>" 2016-10-08 14:46:25 +02:00
Hadi Nategh
c3fb98f3c1 Try to correct ckeditor references point to vendor directory 2016-10-07 12:15:03 +02:00
Ralf Becker
315ceed672 error_log if calendar can not send notifications 2016-10-06 19:09:40 +02:00
Hadi Nategh
57349e6386 Remove spellchecker lang from preferences 2016-10-06 18:30:37 +02:00
nathangray
fa8f53e6d4 Fix VFS ajax uploads did not work if path needed expansion 2016-10-05 16:13:31 -06:00
Hadi Nategh
69ce664000 Fix some of content in mails with specific html formats get removed by HtmLawed's balance 2016-10-05 17:13:07 +02:00
Hadi Nategh
93f3826259 Update HTMLawed into version 1.1.22 2016-10-05 16:18:06 +02:00
Ralf Becker
fc086c56cd fix dbb0796 allow to specify a subdirectory in attach_file as part of $file[name] parameter
(subdir was created, but file was copied to main dir)
2016-10-04 16:47:24 +02:00
Ralf Becker
dbb07961f6 allow to specify a subdirectory in attach_file as part of $file[name] parameter 2016-10-04 10:49:55 +02:00
nathangray
3da08fa7a1 Make sure category data is an array before looking inside it, avoids warning if it is not 2016-10-03 09:58:59 -06:00
Ralf Becker
adaeabe592 fix wrong namespaced Exception: \DateTime throws \Exception 2016-09-28 11:17:19 +02:00
Ralf Becker
76c83eb2a9 allow to specify multiple cat_id's 2016-09-26 14:35:52 +02:00
Ralf Becker
e467b48fea allow to import without acl-check and setting modifier 2016-09-26 11:40:02 +02:00
Ralf Becker
d99a283929 fix old class names in docu 2016-09-26 09:27:52 +02:00
Hadi Nategh
83de4986c8 Fix inline images of compose do not get stored as links into integrated applications like infolog, tracker or calendar 2016-09-21 15:52:50 +02:00
nathangray
c2bd221ae0 Silence debug error log 2016-09-13 08:07:52 -06:00
Ralf Becker
9b09267e0b * Calendar/CalDAV: update or removal of (managed) attachments via CalDAV failed 2016-09-13 15:55:55 +02:00
Ralf Becker
4bf26a6c52 Vfs::rename() is supposted to be static, quitens warning that it is used static 2016-09-13 13:53:05 +02:00
Ralf Becker
e82ce99537 fix SQL error happening in sync-colletion in TB caused by Db->Type == 'mysqli' and Db->group_connect returning false 2016-09-12 23:22:56 +02:00
nathangray
7afd7e420b Better version of optgroup fix to still allow additional data (title, color) in option entries 2016-09-12 10:42:12 -06:00
nathangray
dee0caa875 Fix validation of select values in an optgroup always failed 2016-09-12 08:40:48 -06:00
nathangray
4dcb415f44 Try to fix redirects from AJAX calls to static methods 2016-09-09 10:27:33 -06:00
Hadi Nategh
aff9f0eba8 Fix Ctrl+A in context menu does not get translated 2016-09-09 12:54:52 +02:00
Hadi Nategh
ea30baf1a3 Fix syntax issue caught by Travis which happens only for php versions older than 5.6 2016-09-08 10:10:49 +02:00
Hadi Nategh
cc278e0d17 WIP of letter avatar generator:
- Use hash system to pick always the same color for given user
2016-09-05 12:50:04 +02:00
Ralf Becker
4a25a4a1d3 * App apps: async notifications were not using SMTP only account, but personal one with unavailable session password 2016-09-02 18:12:04 +02:00
Hadi Nategh
c3583dbb3c WIP of letter avatar generator 2016-09-02 17:33:55 +02:00
Ralf Becker
d4ce9fce91 enhance filesystem check to also check fs_id of required nodes /, /home, /apps 2016-08-31 19:03:48 +02:00
Hadi Nategh
d8761441b1 * Mail: Fix pdf attachments do not get downloaded in mobile template 2016-08-31 12:10:26 +02:00
Ralf Becker
4b614c91ed * Filemanager: fix missing symlink overlay on mime-icon 2016-08-29 19:42:49 +02:00
Ralf Becker
4cd0d35ff7 possible fix for deactivated / or /apps 2016-08-29 17:14:48 +02:00
Ralf Becker
ef5b160fdd fix for PHP Warning: Illegal string offset 'to_id' in api/src/Etemplate/Widget/Link.php on line 327 2016-08-29 13:50:13 +02:00
Ralf Becker
026fd08125 Sqlfs::mkdir is no longer static, fixing some left over static calls 2016-08-29 13:42:57 +02:00
Ralf Becker
a6189bf9b9 Sqlfs::mkdir is no longer static, fixing some left over static calls 2016-08-29 12:56:35 +02:00
Ralf Becker
c474df28fb fix Scrutinizer bug: Api\Etemplate\Exception does not exist (missing \Exception) and remove old non-static stuff from Api\Etemplate\Widget::setElementAttribute(), as $this is allways unset for methods declared static 2016-08-28 12:51:19 +02:00
Ralf Becker
54bfaeb988 fix Scrutinizer docu bug: Api\Etemplate\Request\Files::__construct($id) $id is not array but string|null 2016-08-28 12:51:19 +02:00
Ralf Becker
8d2d4ef3dd fix Scrutinizer docu bug: Api\Etemplate\Request\Files::__construct($id) $id is not array but string|null 2016-08-28 12:51:19 +02:00
Ralf Becker
4e15b70373 fix Scrutinizer docu bug: Egw::setup() need to support null for $domain_names parameter 2016-08-28 12:51:19 +02:00
Ralf Becker
4dbd49d285 fix Scrutinizer docu bug: Api\Db has no more support for Halt_On_Error attribute 2016-08-28 12:51:19 +02:00
Ralf Becker
bcec596fff fix Scrutinizer docu bug: get_backend returns Sql|Ldap|Ads|Univention backend 2016-08-28 12:51:19 +02:00
Ralf Becker
056e0f97d2 fix Scrutinizer bug: replace new ldap (wrong namespace) with Api\Ldap::factory() 2016-08-28 12:51:19 +02:00
Ralf Becker
6c6f9eae7a fix Scrutinizer bug: non-existing Api\Api\Db\Exception\InvalidSql and delete_list accepts array of list-ids, while check_list does not 2016-08-28 12:51:19 +02:00
Ralf Becker
52ca45a228 fix Scrutinizer bug: remove non-static usage as it gives a PHP Fatal anyway, since Config::save_value() is declared static 2016-08-28 12:51:19 +02:00
Ralf Becker
9082a799e2 fix Scrutinizer docu bug 2016-08-28 12:51:19 +02:00
Ralf Becker
9f073b4c4c fix Scrutinizer bug: get_path only allows array as parameter (calendar&infolog allow int / just the id too) 2016-08-28 12:51:19 +02:00
Ralf Becker
6903ab0f12 fix Scrutinizer bug: missing required parameters 2016-08-28 12:51:19 +02:00
Ralf Becker
2ec05f8936 fix Scrutinizer docu bug 2016-08-28 12:51:19 +02:00
Ralf Becker
d2e05d5a41 fix Scrutinizer bug: Api\Auth\Exception does not exist 2016-08-28 12:51:19 +02:00
Ralf Becker
b400f38b75 fix Scurtinizer bug by explicitly returning $other_cronlines instead of not declared class var 2016-08-28 12:51:19 +02:00
Ralf Becker
87f54ac14f fix Scurtinizer bug 2016-08-28 12:51:19 +02:00
Ralf Becker
3a6be10253 * Calendar: use proxy config from setup >> configuration to download holiday calendars 2016-08-26 14:00:12 +02:00
Ralf Becker
1088278b37 no need to call accounts class, if we have no id 2016-08-24 19:43:37 +02:00
nathangray
a5b31c62ab Add ISO 8601 (Y-m-dTH:i:s) format to list of checked date formats when importing to catch double parsed dates 2016-08-24 08:22:17 -06:00
Ralf Becker
e724752600 remove deprecated use of read without id (1. parameter) to accounts class in phpgwapi 2016-08-24 16:10:52 +02:00
Ralf Becker
afa17b8236 fix PHP Fatal Call to a member function update() on null 2016-08-24 13:06:06 +02:00
Ralf Becker
6a4c89d61a * Mail: iCal attachments are shown as such, only meeting requests trigger calendar interface with accept/reject buttons 2016-08-23 17:22:55 +02:00
Ralf Becker
a8268adfb5 fix enhanced (multi-)select boxes in old eTemplate where broken and displayed only as regular select-boxes 2016-08-19 16:47:33 +02:00
Ralf Becker
b6c5ad31db log menuaction of eT2 requests, instead of eT2 itself, to do so move update of access-log to destructor of Session class 2016-08-18 13:05:51 +02:00
Ralf Becker
f1f8c4e98d * Filemanager/WebDAV: generally deny user to delete directories /, /home, /apps, /templates (last 2 incl. subdirectories) 2016-08-18 10:04:36 +02:00
nathangray
73dbaa0dfb Preserve link order set by application 2016-08-17 10:52:45 -06:00
Ralf Becker
94bc949cfa * All apps: symlink files to not yet saved entries were not working 2016-08-17 16:05:26 +02:00
Hadi Nategh
a64adb19e6 Fix app.js files included in wrong order 2016-08-16 11:13:11 +02:00
Ralf Becker
9e0ff222f2 missed passing $append parameter to include_modules 2016-08-15 18:55:29 +02:00
Ralf Becker
c3a8012408 adding documented, but never implemented $append parameter to Framework::includeJS 2016-08-15 18:35:26 +02:00
Ralf Becker
a8e1980a15 * Addresssbook: fixed category tree looses unavailable categories (eg. private categories of other users) 2016-08-15 18:22:38 +02:00
Ralf Becker
afafc8ccba calling (static) EGroupware\Api\Vfs::chown instead of using old egw_vfs not available in minimal install in account::deleted hook when moving home directory to /home/$new_user/old-home-$old_user 2016-08-15 15:43:34 +02:00
Ralf Becker
f3649bf021 fix PHP Fatal from old code using EGW_API_INC, that should point to old api and usage is decrecated in favor of autoloading anyway 2016-08-12 11:25:20 +02:00
Ralf Becker
780d35c096 add not yet detected unicode in name-part of email, like "zero width space" 2016-08-12 11:22:56 +02:00
Ralf Becker
bd24602a42 * Filemanager: fix not working changing owner or group of a file/directory (as root!) 2016-08-12 09:29:40 +02:00
Ralf Becker
ac45503630 Handle recursive directory creation in vfs layer, as not all underlaying
wrappers, eg. smb(client), support it themselfs
2016-08-12 08:49:06 +02:00
Ralf Becker
78893ad901 * Filemanager: fix PHP Fatal error when changing ownership or permissions 2016-08-11 22:39:35 +02:00
Ralf Becker
281c6d8761 * Mail: fix lost mail account password on user password change 2016-08-09 14:05:51 +02:00
Ralf Becker
4315999573 use Etemplate\Widget::registerWidget, not some third class extended from Etemplate\Widget, as that might screw up autoloading if it happes to create a circle 2016-08-09 10:11:29 +02:00
Ralf Becker
7822f84943 * PostgreSQL/Setup: fix SQL error in Backup or update: Invalid SQL: SELECT * FROM egw_pm_members
ADOdb drive for PostgreSQL requires 2. parameter for RowLock, while MySQL(i) defaults to all rows
2016-08-09 09:31:36 +02:00
Ralf Becker
674db7912e try fixing error in installtion in Travis using Postgres during admin account creation 2016-08-06 12:41:20 +02:00
Ralf Becker
ee468f40ff try creating egroupware database for postgres with psql, as creating it through SQL seem not to work in Travis 2016-08-06 11:10:28 +02:00
Ralf Becker
b26e102ded debugging db creation in Travis for postgres 2016-08-06 10:54:33 +02:00
leithoff
a41896f802 fix charset/transfer encoding issue when sending plain ascii mails but adding utf-8 signature 2016-08-05 15:12:21 +02:00
Ralf Becker
e65812d07d * Admin: fix email address for groups could not be stored for accounts in SQL 2016-08-03 18:24:14 +02:00
Ralf Becker
a72db03fdb * EPL/Filemanager: fix PHP Fatal using file-a-file dialog (upload with setting eg. a comment) 2016-08-03 15:26:30 +02:00
Ralf Becker
7dde8d0938 fix not working removing of directories and changing group ownership 2016-08-02 12:19:23 +02:00
Ralf Becker
a2439dec02 fix "PHP Fatal error: APCuIterator::__construct(): APC must be enabled to use" in setup-cli 2016-08-02 11:42:37 +02:00
Ralf Becker
2a4535be58 fix PHP Fatal error: Class 'EGroupware\Api\Vfs\Config' not found 2016-08-02 10:19:13 +02:00
Ralf Becker
71a384798f fix PHP Strict Standards: Only variables should be assigned by reference 2016-08-02 10:16:31 +02:00
Ralf Becker
ad5cf7abfe move old schema tests to api/src/Db/test/, not (yet) running via phpUnit/Travis 2016-08-01 13:58:06 +02:00
Ralf Becker
ba18f3f594 allow eg. unit-tests to set/change schema used by db class: Db::set_table_definition() 2016-08-01 13:34:25 +02:00
Ralf Becker
c033435122 fix RenameTable for PostgreSQL to only use old logic, if we still have an old sequence, and if old logic is used, set sequence value 2016-08-01 13:32:43 +02:00
Ralf Becker
27468f0dac fix PHP Warning: filemtime(): stat failed for phpgwapi/setup/setup.inc.php 2016-07-31 10:29:52 +02:00
Ralf Becker
d3043c2a45 * Templates: disable old idots and jerryr template, as new calendar does not work with them 2016-07-29 11:55:41 +02:00
nathangray
474e32db67 Slightly more intelligent detection of plain text fields in a document that has HTML parsing turned on 2016-07-28 14:14:20 -06:00
Ralf Becker
f6f3b89f8b * Filemanager/EPL: fix broken notification / subscription to folders
Do not check for (no longer existing) $GLOBALS[egw]->hooks but for no class setup_process, to not call them during install or update.
2016-07-28 15:10:39 +02:00
Ralf Becker
e3bdf129dc fix Travis error for HHVM 2016-07-28 13:51:47 +02:00
Ralf Becker
96caf6effd * Admin/APC(u): fix error in clear cache: if APC(u) runs out of memory clearing just instance cache clear whole cache 2016-07-28 12:02:21 +02:00
Ralf Becker
86823a7e8c make is-directory check more robust, by checking for PHP's directory-mode / Sqlfs::DIR_MODE too, not only for mime-type which is set eg. by stylite.links to "egs/$app" 2016-07-28 11:11:34 +02:00
Ralf Becker
9c13d84a67 define Vfs::LINK_MODE constant again, since we no longer inherit from Vfs\StreamWrapper 2016-07-28 10:05:14 +02:00
Ralf Becker
015ed03bb6 fix cant attach files, if none have been attached to an entry before: Sqlfs\StreamWrapper::mkdir('/apps/calendar/123',0,1) already exist! 2016-07-28 09:40:23 +02:00
Ralf Becker
6ba07ef64b fixed SQL error caused by sql_mode ONLY_FULL_GROUP_BY under MySQL 5.7+ in VFS file-system-check 2016-07-28 09:11:38 +02:00
Ralf Becker
6496f33da6 fix PHP Fatal error: Access to undeclared static property: EGroupware\Api\Vfs\StreamWrapper::$is_root 2016-07-27 11:09:07 +02:00
Ralf Becker
ffa5b37776 fix not working forced password change on login page with fallback auth 2016-07-27 10:19:48 +02:00
Ralf Becker
28cddb8e64 * Api: fixed not working HTTP authentication 2016-07-26 17:07:42 +02:00
Ralf Becker
be08b46767 * eMail/UCS: fix setting of mailbox ACL for IMAP login-type "email" 2016-07-26 14:51:18 +02:00
Ralf Becker
f0a739d7ed * LDAP: fix not working password change by user 2016-07-26 08:47:31 +02:00
Ralf Becker
a0d419a145 log execeptions happening during mergeprint for easier debugging 2016-07-25 14:53:30 +02:00
Ralf Becker
4b58e87080 fix not working symlinking vfs files to infologs/links, fixed multiple PHP deprecated should not call non-static self::url_stat static 2016-07-22 18:22:46 +02:00
nathangray
3b1ce04608 Avoid a Illegal string offset warning from link-entry widgets when they have only-app attribute set
Happened on infologs added from projectmanager element list
2016-07-21 12:51:32 -06:00
Ralf Becker
fefc2b5f88 fix PHP Fatal error: Call to undefined function EGroupware\Api\Vfs\Sqlfs() 2016-07-21 18:35:58 +02:00
Ralf Becker
6108123fe7 fix PHP Fatal in propatch 2016-07-21 17:43:28 +02:00
Ralf Becker
45c272dac2 make Vfs\StreamWrapper::symlinkCache_remove public, to allow calling from Vfs 2016-07-21 12:15:54 +02:00
Ralf Becker
d26d1dd7f8 fix rename and load_wrapper missing in Vfs class 2016-07-21 11:17:01 +02:00
Ralf Becker
52be4ee14b implement PHP 5.4+ stream_metadata method for VFS, allowing to use that functionality from other stream-wrappers like php-smbclient 2016-07-21 09:51:36 +02:00
Ralf Becker
f04dd8ace6 Vfs no longer extends Vfs\StreamWrapper, as this is the only way to keep static function signatures for Vfs class, also cleans up a bit 2016-07-19 13:29:43 +02:00
Ralf Becker
b65d87bc68 fixing our wrong static methods in stream-wrapper: unlink, rmdir, mkdir, rename and url_stat (they are not static, so PHP can pass in $context) 2016-07-19 11:59:16 +02:00
Ralf Becker
f4acec1b82 fix not working forced password change on login screen 2016-07-15 14:47:13 +02:00
Ralf Becker
f4521e3401 fix missing slash in path of adLDAP.php 2016-07-15 14:24:30 +02:00
Ralf Becker
52d3aa70cd enable APCu for caching with >= 32M and fix post_install to patch Ubuntu-16.04 /etc/php/7.0/cli/conf.d/20-apcu.ini 2016-07-15 13:23:39 +02:00